From eeac0a878829e15b86429b164244ac18a740633d Mon Sep 17 00:00:00 2001 From: Bjorn Andersson Date: Tue, 13 Sep 2016 12:16:20 -0700 Subject: [PATCH] remoteproc: Drop unnecessary NULL check rproc_alloc() will make sure that the "firmware" pointer is either a driver supplied value or pointing to a generated firmware filename, it can't be NULL. So drop the extra check in the rproc_boot() path. Signed-off-by: Bjorn Andersson --- drivers/remoteproc/remoteproc_core.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 0d3c191b6bc3..92a1037c1b2e 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -1034,13 +1034,6 @@ static int __rproc_boot(struct rproc *rproc, bool wait) return ret; } - /* loading a firmware is required */ - if (!rproc->firmware) { - dev_err(dev, "%s: no firmware to load\n", __func__); - ret = -EINVAL; - goto unlock_mutex; - } - /* prevent underlying implementation from being removed */ if (!try_module_get(dev->parent->driver->owner)) { dev_err(dev, "%s: can't get owner\n", __func__); -- GitLab