From ee7830df97dc70ed2b860a61b90235e2cf642419 Mon Sep 17 00:00:00 2001 From: Jing Xiangfeng Date: Tue, 20 Apr 2021 19:46:42 +0800 Subject: [PATCH] ipmi: remve duplicate code in __ipmi_bmc_register() mainline inclusion from mainline-5.9 commit a7f0f92aa82fced7df891282b67387d247e44ca8 category: bugfix bugzilla: NA CVE: NA ------------------------------------------------- __ipmi_bmc_register() jumps to the label 'out_free_my_dev_name' in an error path. So we can remove duplicate code in the if (rv). Signed-off-by: Jing Xiangfeng Message-Id: <20200720080838.148737-1-jingxiangfeng@huawei.com> Signed-off-by: Corey Minyard Signed-off-by: Wenchao Hao Reviewed-by: Miaohe Lin Signed-off-by: Yang Yingliang --- drivers/char/ipmi/ipmi_msghandler.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c index e6b985d04ac9..069833172411 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ -3021,8 +3021,6 @@ static int __ipmi_bmc_register(struct ipmi_smi *intf, rv = sysfs_create_link(&bmc->pdev.dev.kobj, &intf->si_dev->kobj, intf->my_dev_name); if (rv) { - kfree(intf->my_dev_name); - intf->my_dev_name = NULL; dev_err(intf->si_dev, PFX "Unable to create symlink to bmc: %d\n", rv); goto out_free_my_dev_name; -- GitLab