From edf8c7d2c6261a13a8edc8ab05d1064422d4e240 Mon Sep 17 00:00:00 2001 From: Cheng Jian Date: Wed, 14 Apr 2021 11:58:54 +0800 Subject: [PATCH] sched/fair: fix try_steal compile error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit hulk inclusion category: bugfix bugzilla: 38261, https://bugzilla.openeuler.org/show_bug.cgi?id=23 CVE: NA --------------------------- If we disable CONFIG_SMP, try_steal will lose its definition, resulting in a compile error as follows. kernel/sched/fair.c: In function ‘pick_next_task_fair’: kernel/sched/fair.c:7001:15: error: implicit declaration of function ‘try_steal’ [-Werror=implicit-function-declaration] new_tasks = try_steal(rq, rf); ^~~~~~~~~ We can use allnoconfig to reproduce this problem. Signed-off-by: Cheng Jian Reviewed-by: Bin Li Signed-off-by: Yang Yingliang Reviewed-by: Xie XiuQi Signed-off-by: Yang Yingliang --- kernel/sched/fair.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 2aca6f86eb34..e8b111fb51c6 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3901,6 +3901,7 @@ static inline int idle_balance(struct rq *rq, struct rq_flags *rf) static inline void rq_idle_stamp_update(struct rq *rq) {} static inline void rq_idle_stamp_clear(struct rq *rq) {} +static inline int try_steal(struct rq *this_rq, struct rq_flags *rf) { return 0; } static inline void overload_clear(struct rq *rq) {} static inline void overload_set(struct rq *rq) {} -- GitLab