提交 e24203ef 编写于 作者: M Miaoqian Lin 提交者: Zheng Zengkai

irqchip/gic-v3: Fix error handling in gic_populate_ppi_partitions

stable inclusion
from stable-v5.10.124
commit 7c9dd9d23f26dabcfb14148b9acdfba540418b19
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I5L6E7

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=7c9dd9d23f26dabcfb14148b9acdfba540418b19

--------------------------------

[ Upstream commit ec8401a4 ]

of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
When kcalloc fails, it missing of_node_put() and results in refcount
leak. Fix this by goto out_put_node label.

Fixes: 52085d3f ("irqchip/gic-v3: Dynamically allocate PPI partition descriptors")
Signed-off-by: NMiaoqian Lin <linmq006@gmail.com>
Signed-off-by: NMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220601080930.31005-5-linmq006@gmail.comSigned-off-by: NSasha Levin <sashal@kernel.org>
Signed-off-by: NZheng Zengkai <zhengzengkai@huawei.com>
Reviewed-by: NWei Li <liwei391@huawei.com>
上级 d180296f
...@@ -1838,7 +1838,7 @@ static void __init gic_populate_ppi_partitions(struct device_node *gic_node) ...@@ -1838,7 +1838,7 @@ static void __init gic_populate_ppi_partitions(struct device_node *gic_node)
gic_data.ppi_descs = kcalloc(gic_data.ppi_nr, sizeof(*gic_data.ppi_descs), GFP_KERNEL); gic_data.ppi_descs = kcalloc(gic_data.ppi_nr, sizeof(*gic_data.ppi_descs), GFP_KERNEL);
if (!gic_data.ppi_descs) if (!gic_data.ppi_descs)
return; goto out_put_node;
nr_parts = of_get_child_count(parts_node); nr_parts = of_get_child_count(parts_node);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册