提交 da27ef68 编写于 作者: J Jia-Ju Bai 提交者: Mauro Carvalho Chehab

media: pci: cobalt: Replace GFP_ATOMIC with GFP_KERNEL in cobalt_probe()

cobalt_probe() is never called in atomic context.
It calls kzalloc() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: NJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>
上级 a8a4d304
...@@ -670,7 +670,7 @@ static int cobalt_probe(struct pci_dev *pci_dev, ...@@ -670,7 +670,7 @@ static int cobalt_probe(struct pci_dev *pci_dev,
/* FIXME - module parameter arrays constrain max instances */ /* FIXME - module parameter arrays constrain max instances */
i = atomic_inc_return(&cobalt_instance) - 1; i = atomic_inc_return(&cobalt_instance) - 1;
cobalt = kzalloc(sizeof(struct cobalt), GFP_ATOMIC); cobalt = kzalloc(sizeof(struct cobalt), GFP_KERNEL);
if (cobalt == NULL) if (cobalt == NULL)
return -ENOMEM; return -ENOMEM;
cobalt->pci_dev = pci_dev; cobalt->pci_dev = pci_dev;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册