You need to sign in or sign up before continuing.
提交 d616f56d 编写于 作者: W Wolfram Sang 提交者: Greg Kroah-Hartman

debugfs: only accept read attributes for blobs

Blobs can only be read. So, keep only 'read' file attributes because the
others will not work and only confuse users.
Signed-off-by: NWolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20210504131350.46586-1-wsa+renesas@sang-engineering.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
上级 0733d839
...@@ -980,7 +980,8 @@ static const struct file_operations fops_blob = { ...@@ -980,7 +980,8 @@ static const struct file_operations fops_blob = {
/** /**
* debugfs_create_blob - create a debugfs file that is used to read a binary blob * debugfs_create_blob - create a debugfs file that is used to read a binary blob
* @name: a pointer to a string containing the name of the file to create. * @name: a pointer to a string containing the name of the file to create.
* @mode: the permission that the file should have * @mode: the read permission that the file should have (other permissions are
* masked out)
* @parent: a pointer to the parent dentry for this file. This should be a * @parent: a pointer to the parent dentry for this file. This should be a
* directory dentry if set. If this parameter is %NULL, then the * directory dentry if set. If this parameter is %NULL, then the
* file will be created in the root of the debugfs filesystem. * file will be created in the root of the debugfs filesystem.
...@@ -1004,7 +1005,7 @@ struct dentry *debugfs_create_blob(const char *name, umode_t mode, ...@@ -1004,7 +1005,7 @@ struct dentry *debugfs_create_blob(const char *name, umode_t mode,
struct dentry *parent, struct dentry *parent,
struct debugfs_blob_wrapper *blob) struct debugfs_blob_wrapper *blob)
{ {
return debugfs_create_file_unsafe(name, mode, parent, blob, &fops_blob); return debugfs_create_file_unsafe(name, mode & 0444, parent, blob, &fops_blob);
} }
EXPORT_SYMBOL_GPL(debugfs_create_blob); EXPORT_SYMBOL_GPL(debugfs_create_blob);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册