From cd641f68d628e5c44350447d4b8d661991419e60 Mon Sep 17 00:00:00 2001 From: Stefan Richter Date: Thu, 2 Nov 2006 21:16:08 +0100 Subject: [PATCH] ieee1394: sbp2: use list_move_tail() It's OK to reorder list_del() and sbp2util_free_command_dma() here. Signed-off-by: Stefan Richter --- drivers/ieee1394/sbp2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c index a7fb588d3ca7..2b6d9a0fa737 100644 --- a/drivers/ieee1394/sbp2.c +++ b/drivers/ieee1394/sbp2.c @@ -619,9 +619,8 @@ static void sbp2util_mark_command_completed( struct sbp2_lu *lu, struct sbp2_command_info *cmd) { - list_del(&cmd->list); sbp2util_free_command_dma(cmd); - list_add_tail(&cmd->list, &lu->cmd_orb_completed); + list_move_tail(&cmd->list, &lu->cmd_orb_completed); } /* -- GitLab