提交 cbc1c998 编写于 作者: X Xu Kuohai 提交者: Andrii Nakryiko

selftest/bpf: Fix error usage of ASSERT_OK in xdp_adjust_tail.c

xdp_adjust_tail.c calls ASSERT_OK() to check the return value of
bpf_prog_test_load(), but the condition is not correct. Fix it.

Fixes: 791cad02 ("bpf: selftests: Get rid of CHECK macro in xdp_adjust_tail.c")
Signed-off-by: NXu Kuohai <xukuohai@huawei.com>
Signed-off-by: NAndrii Nakryiko <andrii@kernel.org>
Acked-by: NMartin KaFai Lau <martin.lau@kernel.org>
Link: https://lore.kernel.org/bpf/20221011120108.782373-7-xukuohai@huaweicloud.com
上级 4abdb1d5
...@@ -18,7 +18,7 @@ static void test_xdp_adjust_tail_shrink(void) ...@@ -18,7 +18,7 @@ static void test_xdp_adjust_tail_shrink(void)
); );
err = bpf_prog_test_load(file, BPF_PROG_TYPE_XDP, &obj, &prog_fd); err = bpf_prog_test_load(file, BPF_PROG_TYPE_XDP, &obj, &prog_fd);
if (ASSERT_OK(err, "test_xdp_adjust_tail_shrink")) if (!ASSERT_OK(err, "test_xdp_adjust_tail_shrink"))
return; return;
err = bpf_prog_test_run_opts(prog_fd, &topts); err = bpf_prog_test_run_opts(prog_fd, &topts);
...@@ -53,7 +53,7 @@ static void test_xdp_adjust_tail_grow(void) ...@@ -53,7 +53,7 @@ static void test_xdp_adjust_tail_grow(void)
); );
err = bpf_prog_test_load(file, BPF_PROG_TYPE_XDP, &obj, &prog_fd); err = bpf_prog_test_load(file, BPF_PROG_TYPE_XDP, &obj, &prog_fd);
if (ASSERT_OK(err, "test_xdp_adjust_tail_grow")) if (!ASSERT_OK(err, "test_xdp_adjust_tail_grow"))
return; return;
err = bpf_prog_test_run_opts(prog_fd, &topts); err = bpf_prog_test_run_opts(prog_fd, &topts);
...@@ -90,7 +90,7 @@ static void test_xdp_adjust_tail_grow2(void) ...@@ -90,7 +90,7 @@ static void test_xdp_adjust_tail_grow2(void)
); );
err = bpf_prog_test_load(file, BPF_PROG_TYPE_XDP, &obj, &prog_fd); err = bpf_prog_test_load(file, BPF_PROG_TYPE_XDP, &obj, &prog_fd);
if (ASSERT_OK(err, "test_xdp_adjust_tail_grow")) if (!ASSERT_OK(err, "test_xdp_adjust_tail_grow"))
return; return;
/* Test case-64 */ /* Test case-64 */
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册