提交 c7db7801 编写于 作者: H Heiner Kallweit 提交者: sanglipeng

net: mdio: validate parameter addr in mdiobus_get_phy()

stable inclusion
from stable-v5.10.166
commit 4bc5f1f6bc94e695dfd912122af96e7115a0ddb8
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I7TH9O

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=4bc5f1f6bc94e695dfd912122af96e7115a0ddb8

--------------------------------

[ Upstream commit 867dbe78 ]

The caller may pass any value as addr, what may result in an out-of-bounds
access to array mdio_map. One existing case is stmmac_init_phy() that
may pass -1 as addr. Therefore validate addr before using it.

Fixes: 7f854420 ("phy: Add API for {un}registering an mdio device to a bus.")
Signed-off-by: NHeiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: NAndrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/cdf664ea-3312-e915-73f8-021678d08887@gmail.comSigned-off-by: NPaolo Abeni <pabeni@redhat.com>
Signed-off-by: NSasha Levin <sashal@kernel.org>
Signed-off-by: Nsanglipeng <sanglipeng1@jd.com>
上级 be9cb619
...@@ -108,7 +108,12 @@ EXPORT_SYMBOL(mdiobus_unregister_device); ...@@ -108,7 +108,12 @@ EXPORT_SYMBOL(mdiobus_unregister_device);
struct phy_device *mdiobus_get_phy(struct mii_bus *bus, int addr) struct phy_device *mdiobus_get_phy(struct mii_bus *bus, int addr)
{ {
struct mdio_device *mdiodev = bus->mdio_map[addr]; struct mdio_device *mdiodev;
if (addr < 0 || addr >= ARRAY_SIZE(bus->mdio_map))
return NULL;
mdiodev = bus->mdio_map[addr];
if (!mdiodev) if (!mdiodev)
return NULL; return NULL;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册