From c3e7843dd57c29ac7d450d635eb69d6e7da714a5 Mon Sep 17 00:00:00 2001 From: Stefan Berger Date: Wed, 11 Jan 2023 08:41:26 +0000 Subject: [PATCH] ima: Do not print policy rule with inactive LSM labels mainline inclusion from mainline-v5.17-rc4 commit 89677197ae709eb1ab3646952c44f6a171c9e74c category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I692HU CVE: NA -------------------------------- Before printing a policy rule scan for inactive LSM labels in the policy rule. Inactive LSM labels are identified by args_p != NULL and rule == NULL. Fixes: 483ec26eed42 ("ima: ima/lsm policy rule loading logic bug fixes") Signed-off-by: Stefan Berger Cc: # v5.6+ Acked-by: Christian Brauner [zohar@linux.ibm.com: Updated "Fixes" tag] Signed-off-by: Mimi Zohar Signed-off-by: GUO Zihua Reviewed-by: Xiu Jianfeng Signed-off-by: Yongqiang Liu --- security/integrity/ima/ima_policy.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c index 2aff6f9ef0e9..6cc862ce3563 100644 --- a/security/integrity/ima/ima_policy.c +++ b/security/integrity/ima/ima_policy.c @@ -1240,6 +1240,14 @@ int ima_policy_show(struct seq_file *m, void *v) rcu_read_lock(); + /* Do not print rules with inactive LSM labels */ + for (i = 0; i < MAX_LSM_RULES; i++) { + if (entry->lsm[i].args_p && !entry->lsm[i].rule) { + rcu_read_unlock(); + return 0; + } + } + if (entry->action & MEASURE) seq_puts(m, pt(Opt_measure)); if (entry->action & DONT_MEASURE) -- GitLab