From c1f783ee9aff0709520dd424a11e33fa2d2ea985 Mon Sep 17 00:00:00 2001 From: Jonathan Bell Date: Tue, 14 May 2019 17:17:59 +0100 Subject: [PATCH] net: genet: enable link energy detect powerdown for external PHYs raspberrypi inclusion category: feature bugzilla: 50432 -------------------------------- There are several warts surrounding bcmgenet_mii_probe() as this function is called from ndo_open, but it's calling registration-type functions. The probe should be called at probe time and refactored such that the PHY device data can be extracted to limit the scope of this flag to Broadcom PHYs. For now, pass this flag in as it puts our attached PHY into a low-power state when disconnected. Signed-off-by: Jonathan Bell Signed-off-by: Fang Yafen Signed-off-by: Zheng Zengkai --- drivers/net/ethernet/broadcom/genet/bcmmii.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c index 6fb6c3556285..2e516f4c435e 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -293,6 +293,8 @@ int bcmgenet_mii_probe(struct net_device *dev) /* Communicate the integrated PHY revision */ if (priv->internal_phy) phy_flags = priv->gphy_rev; + else + phy_flags = PHY_BRCM_AUTO_PWRDWN_ENABLE; /* Initialize link state variables that bcmgenet_mii_setup() uses */ priv->old_link = -1; -- GitLab