提交 beb69f15 编写于 作者: G Gustavo A. R. Silva

energy_model.h: Replace zero-length array with flexible-array member

The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by
this change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732 ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: NGustavo A. R. Silva <gustavo@embeddedor.com>
上级 19219946
...@@ -36,7 +36,7 @@ struct em_cap_state { ...@@ -36,7 +36,7 @@ struct em_cap_state {
struct em_perf_domain { struct em_perf_domain {
struct em_cap_state *table; struct em_cap_state *table;
int nr_cap_states; int nr_cap_states;
unsigned long cpus[0]; unsigned long cpus[];
}; };
#ifdef CONFIG_ENERGY_MODEL #ifdef CONFIG_ENERGY_MODEL
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册