From b5a80252e09c2791380cdf10a6ebd7987900748c Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Tue, 5 Nov 2019 09:41:42 +0100 Subject: [PATCH] USB: legousbtower: drop redundant open_count check Drop redundant open_count check in release; the open count is used as a flag and is only set to 0 or 1. Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191105084152.16322-5-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/legousbtower.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c index c880d58e8683..1626a0d2b12b 100644 --- a/drivers/usb/misc/legousbtower.c +++ b/drivers/usb/misc/legousbtower.c @@ -421,13 +421,6 @@ static int tower_release (struct inode *inode, struct file *file) mutex_lock(&dev->lock); - if (dev->open_count != 1) { - dev_dbg(&dev->udev->dev, "%s: device not opened exactly once\n", - __func__); - retval = -ENODEV; - goto unlock_exit; - } - if (dev->disconnected) { /* the device was unplugged before the file was released */ @@ -444,7 +437,6 @@ static int tower_release (struct inode *inode, struct file *file) tower_abort_transfers (dev); dev->open_count = 0; -unlock_exit: mutex_unlock(&dev->lock); exit: return retval; -- GitLab