提交 b3703861 编写于 作者: C Christian Lamparter 提交者: Zheng Zengkai

ARM: dts: gemini: NAS4220-B: fis-index-block with 128 KiB sectors

stable inclusion
from stable-v5.10.94
commit 958a8819d41420d7a74ed922a09cacc0ba3a4218
bugzilla: https://gitee.com/openeuler/kernel/issues/I531X9

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=958a8819d41420d7a74ed922a09cacc0ba3a4218

--------------------------------

[ Upstream commit 4754eab7 ]

Steven Maddox reported in the OpenWrt bugzilla, that his
RaidSonic IB-NAS4220-B was no longer booting with the new
OpenWrt 21.02 (uses linux 5.10's device-tree). However, it was
working with the previous OpenWrt 19.07 series (uses 4.14).

|[    5.548038] No RedBoot partition table detected in 30000000.flash
|[    5.618553] Searching for RedBoot partition table in 30000000.flash at offset 0x0
|[    5.739093] No RedBoot partition table detected in 30000000.flash
|...
|[    7.039504] Waiting for root device /dev/mtdblock3...

The provided bootlog shows that the RedBoot partition parser was
looking for the partition table "at offset 0x0". Which is strange
since the comment in the device-tree says it should be at 0xfe0000.

Further digging on the internet led to a review site that took
some useful PCB pictures of their review unit back in February 2009.
Their picture shows a Spansion S29GL128N11TFI01 flash chip.

>From Spansion's Datasheet:
"S29GL128N: One hundred twenty-eight 64 Kword (128 Kbyte) sectors"
Steven also provided a "cat /sys/class/mtd/mtd0/erasesize" from his
unit: "131072".

With the 128 KiB Sector/Erasesize in mind. This patch changes the
fis-index-block property to (0xfe0000 / 0x20000) = 0x7f.

Fixes: b5a923f8 ("ARM: dts: gemini: Switch to redboot partition parsing")
Reported-by: NSteven Maddox <s.maddox@lantizia.me.uk>
Signed-off-by: NChristian Lamparter <chunkeey@gmail.com>
Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>
Tested-by: NSteven Maddox <s.maddox@lantizia.me.uk>
Link: https://lore.kernel.org/r/20211206004334.4169408-1-linus.walleij@linaro.org'
Bugzilla: https://bugs.openwrt.org/index.php?do=details&task_id=4137Signed-off-by: NArnd Bergmann <arnd@arndb.de>
Signed-off-by: NSasha Levin <sashal@kernel.org>
Signed-off-by: NZheng Zengkai <zhengzengkai@huawei.com>
Acked-by: NXie XiuQi <xiexiuqi@huawei.com>
上级 b5dca66b
...@@ -84,7 +84,7 @@ ...@@ -84,7 +84,7 @@
partitions { partitions {
compatible = "redboot-fis"; compatible = "redboot-fis";
/* Eraseblock at 0xfe0000 */ /* Eraseblock at 0xfe0000 */
fis-index-block = <0x1fc>; fis-index-block = <0x7f>;
}; };
}; };
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册