From b2f5e27ea3b0d9acf6eb1a2f2a7960fa692942ec Mon Sep 17 00:00:00 2001 From: Liu Xiang Date: Tue, 12 Oct 2021 16:37:43 +0800 Subject: [PATCH] mm: hugetlb: fix type of delta parameter and related local variables in gather_surplus_pages() mainline inclusion from mainline-v5.11-rc1 commit 0a4f3d1bb91cac4efdd780373638b6a1a4c24c51 category: bugfix bugzilla: 108349 https://gitee.com/openeuler/kernel/issues/I4DDEL Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0a4f3d1bb91cac4efdd780373638b6a1a4c24c51 ----------------------------------------------- On 64-bit machine, delta variable in hugetlb_acct_memory() may be larger than 0xffffffff, but gather_surplus_pages() can only use the low 32-bit value now. So we need to fix type of delta parameter and related local variables in gather_surplus_pages(). Link: https://lkml.kernel.org/r/1605793733-3573-1-git-send-email-liu.xiang@zlingsmart.com Reported-by: Ma Chenggong Signed-off-by: Liu Xiang Signed-off-by: Pan Jiagen Reviewed-by: Mike Kravetz Cc: Liu Xiang Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Tong Tiangen Reviewed-by: Chen Wandun Signed-off-by: Chen Jun Signed-off-by: Zheng Zengkai --- mm/hugetlb.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 19f83ef14ee4..44b57cc363ff 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -2070,13 +2070,14 @@ struct page *alloc_huge_page_vma(struct hstate *h, struct vm_area_struct *vma, * Increase the hugetlb pool such that it can accommodate a reservation * of size 'delta'. */ -static int gather_surplus_pages(struct hstate *h, int delta) +static int gather_surplus_pages(struct hstate *h, long delta) __must_hold(&hugetlb_lock) { struct list_head surplus_list; struct page *page, *tmp; - int ret, i; - int needed, allocated; + int ret; + long i; + long needed, allocated; bool alloc_ok = true; lockdep_assert_held(&hugetlb_lock); -- GitLab