scsi: mpt3sas: Stop fw fault watchdog work item during system shutdown

  mainline inclusion
  from mainline-5.19
  commit 0fde22c5
  category: bugfix
  bugzilla: https://gitee.com/openeuler/kernel/issues/I5LODY
  CVE: N/A

  --------------------------------

  commit 0fde22c5 upstream.

  During system shutdown or reboot, mpt3sas will reset the firmware back to
  ready state. However, the driver leaves running a watchdog work item
  intended to keep the firmware in operational state. This causes a second,
  unneeded reset on shutdown and moves the firmware back to operational
  instead of in ready state as intended. And if the mpt3sas_fwfault_debug
  module parameter is set, this extra reset also panics the system.

  mpt3sas's scsih_shutdown needs to stop the watchdog before resetting the
  firmware back to ready state.

  Link: https://lore.kernel.org/r/20220722142448.6289-1-djeffery@redhat.com
  Fixes: fae21608 ("scsi: mpt3sas: Transition IOC to Ready state during shutdown")
Tested-by: NLaurence Oberman <loberman@redhat.com>
Acked-by: NSreekanth Reddy <sreekanth.reddy@broadcom.com>
Signed-off-by: NDavid Jeffery <djeffery@redhat.com>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: NFengfei.Xi <xi.fengfei@h3c.com>

drivers/scsi/mpt3sas/mpt3sas_scsih.c

@@ -10276,6 +10276,7 @@ scsih_shutdown(struct pci_dev *pdev)
 	_scsih_ir_shutdown(ioc);
 	_scsih_nvme_shutdown(ioc);
 	mpt3sas_base_mask_interrupts(ioc);
+	mpt3sas_base_stop_watchdog(ioc);
 	ioc->shost_recovery = 1;
 	mpt3sas_base_make_ioc_ready(ioc, SOFT_RESET);
 	ioc->shost_recovery = 0;