diff --git a/drivers/staging/brcm80211/brcmfmac/dhd_linux.c b/drivers/staging/brcm80211/brcmfmac/dhd_linux.c index be6ac308604f30b45f29e044b39ecfb01dbca8bf..9c9b8baeb7d96a6ab7cf4d4561af82aa7a7b8b29 100644 --- a/drivers/staging/brcm80211/brcmfmac/dhd_linux.c +++ b/drivers/staging/brcm80211/brcmfmac/dhd_linux.c @@ -339,7 +339,7 @@ int dhd_idletime = DHD_IDLETIME_TICKS; module_param(dhd_idletime, int, 0); /* Use polling */ -uint dhd_poll = false; +uint dhd_poll; module_param(dhd_poll, uint, 0); /* Use cfg80211 */ @@ -1817,9 +1817,12 @@ dhd_add_if(dhd_info_t *dhd, int ifidx, void *handle, char *name, ASSERT(dhd && (ifidx < DHD_MAX_IFS)); ifp = dhd->iflist[ifidx]; - if (!ifp && !(ifp = kmalloc(sizeof(dhd_if_t), GFP_ATOMIC))) { - DHD_ERROR(("%s: OOM - dhd_if_t\n", __func__)); - return -ENOMEM; + if (!ifp) { + ifp = kmalloc(sizeof(dhd_if_t), GFP_ATOMIC); + if (!ifp) { + DHD_ERROR(("%s: OOM - dhd_if_t\n", __func__)); + return -ENOMEM; + } } memset(ifp, 0, sizeof(dhd_if_t)); diff --git a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c index 399d7a8efa4699a255720d3794789b303e03350d..235cc5906d9ad203f2f394bcef70c155924b7138 100644 --- a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c +++ b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c @@ -323,9 +323,8 @@ static void wl_debugfs_remove_netdev(struct wl_priv *wl); #define WL_PRIV_GET() \ ({ \ - struct wl_iface *ci; \ - if (unlikely(!(wl_cfg80211_dev && \ - (ci = wl_get_drvdata(wl_cfg80211_dev))))) { \ + struct wl_iface *ci = wl_get_drvdata(wl_cfg80211_dev); \ + if (unlikely(!ci)) { \ WL_ERR("wl_cfg80211_dev is unavailable\n"); \ BUG(); \ } \ @@ -4298,7 +4297,11 @@ static void wl_set_drvdata(struct wl_dev *dev, void *data) static void *wl_get_drvdata(struct wl_dev *dev) { - return dev->driver_data; + void *data = NULL; + + if (dev) + data = dev->driver_data; + return data; } s32 wl_cfg80211_read_fw(s8 *buf, u32 size) diff --git a/drivers/staging/brcm80211/brcmfmac/wl_iw.c b/drivers/staging/brcm80211/brcmfmac/wl_iw.c index 71c8c68039d9e3f32f7f20998f58f66b1ee36d8e..e8b45ae489a3728e36ff6cc45f08303cfb558ab5 100644 --- a/drivers/staging/brcm80211/brcmfmac/wl_iw.c +++ b/drivers/staging/brcm80211/brcmfmac/wl_iw.c @@ -1170,7 +1170,7 @@ static int _iscan_sysioc_thread(void *data) { u32 status; iscan_info_t *iscan = (iscan_info_t *) data; - static bool iscan_pass_abort = false; + static bool iscan_pass_abort; allow_signal(SIGTERM); status = WL_SCAN_RESULTS_PARTIAL;