提交 a7be0ab1 编写于 作者: D Daniel Xu 提交者: Daniel Borkmann

selftests/bpf: Fix vmtest.sh getopts optstring

Before, you could see the following errors:

  $ ./vmtest.sh -j
  ./vmtest.sh: option requires an argument -- j
  ./vmtest.sh: line 357: OPTARG: unbound variable

  $ ./vmtest.sh -z
  ./vmtest.sh: illegal option -- z
  ./vmtest.sh: line 357: OPTARG: unbound variable

Fix by adding ':' as first character of optstring. Reason is that getopts
requires ':' as the first character for OPTARG to be set in the `?` and `:`
error cases.

Note that the ':' as the first character of the optstring switches getopts
to silent mode. The desire to run in this mode seems to have been there all
along, as the script takes care of reporting errors.
Signed-off-by: NDaniel Xu <dxu@dxuuu.xyz>
Signed-off-by: NDaniel Borkmann <daniel@iogearbox.net>
Acked-by: NDaniel Müller <deso@posteo.net>
Link: https://lore.kernel.org/bpf/0f93b56198328b6b4da7b4cf4662d05c3edb5fd2.1660064925.git.dxu@dxuuu.xyz
上级 d020b236
......@@ -333,7 +333,7 @@ main()
local exit_command="poweroff -f"
local debug_shell="no"
while getopts 'hskid:j:' opt; do
while getopts ':hskid:j:' opt; do
case ${opt} in
i)
update_image="yes"
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册