From 97fd0dd5589a8496eee6e1c77a9749fd168049cc Mon Sep 17 00:00:00 2001 From: Alexander Potapenko Date: Tue, 26 May 2020 12:07:43 +0800 Subject: [PATCH] fs/binfmt_elf.c: allocate initialized memory in fill_thread_core_info() mainline inclusion from mainline-next commit bb77be1c3196eb3c05ec68f4ffeb155503053d09 category: bugfix bugzilla: 13690 CVE: CVE-2020-10732 ------------------------------------------------- KMSAN reported uninitialized data being written to disk when dumping core. As a result, several kilobytes of kmalloc memory may be written to the core file and then read by a non-privileged user. Link: http://lkml.kernel.org/r/20200419100848.63472-1-glider@google.com Link: https://github.com/google/kmsan/issues/76 Signed-off-by: Alexander Potapenko Reported-by: sam Acked-by: Kees Cook Cc: Alexey Dobriyan Cc: Signed-off-by: Andrew Morton Signed-off-by: Stephen Rothwell Signed-off-by: Yang Yingliang Reviewed-by: Jason Yan Signed-off-by: Yang Yingliang --- fs/binfmt_elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index e7fd0b5b9234..975dd0dbc252 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -1766,7 +1766,7 @@ static int fill_thread_core_info(struct elf_thread_core_info *t, (!regset->active || regset->active(t->task, regset) > 0)) { int ret; size_t size = regset_size(t->task, regset); - void *data = kmalloc(size, GFP_KERNEL); + void *data = kzalloc(size, GFP_KERNEL); if (unlikely(!data)) return 0; ret = regset->get(t->task, regset, -- GitLab