From 8da084ce498c10a3d7a839f55cfa719e7da1cf6f Mon Sep 17 00:00:00 2001 From: Zhihao Cheng Date: Mon, 15 Nov 2021 19:52:16 +0800 Subject: [PATCH] ubifs: Add missing iput if do_tmpfile() failed in rename whiteout hulk inclusion category: bugfix bugzilla: 185658 https://gitee.com/openeuler/kernel/issues/I4DDEL --------------------------- whiteout inode should be put when do_tmpfile() failed if inode has been initialized. Otherwise we will get following warning during umount: UBIFS error (ubi0:0 pid 1494): ubifs_assert_failed [ubifs]: UBIFS assert failed: c->bi.dd_growth == 0, in fs/ubifs/super.c:1930 VFS: Busy inodes after unmount of ubifs. Self-destruct in 5 seconds. Fixes: 9e0a1fff8db56ea ("ubifs: Implement RENAME_WHITEOUT") Signed-off-by: Zhihao Cheng Reviewed-by: Zhang Yi Signed-off-by: Chen Jun Signed-off-by: Zheng Zengkai --- fs/ubifs/dir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c index e0b2dbc36517..9888858bb9e5 100644 --- a/fs/ubifs/dir.c +++ b/fs/ubifs/dir.c @@ -1332,6 +1332,8 @@ static int do_rename(struct inode *old_dir, struct dentry *old_dentry, err = do_tmpfile(old_dir, old_dentry, S_IFCHR | WHITEOUT_MODE, &whiteout); if (err) { + if (whiteout) + iput(whiteout); kfree(dev); goto out_release; } -- GitLab