From 8bed43713ffcae3d9db1c69e4641d1609d5e3829 Mon Sep 17 00:00:00 2001 From: Miaohe Lin Date: Wed, 14 Apr 2021 11:57:40 +0800 Subject: [PATCH] mm/hugetlb: fix potential double free in hugetlb_register_node() error path stable inclusion from linux-4.19.178 commit 2d0324108fa80446d6b41228bac40c03cd3b5d35 -------------------------------- [ Upstream commit cc2205a67dec5a700227a693fc113441e73e4641 ] In hugetlb_sysfs_add_hstate(), we would do kobject_put() on hstate_kobjs when failed to create sysfs group but forget to set hstate_kobjs to NULL. Then in hugetlb_register_node() error path, we may free it again via hugetlb_unregister_node(). Link: https://lkml.kernel.org/r/20210107123249.36964-1-linmiaohe@huawei.com Fixes: a3437870160c ("hugetlb: new sysfs interface") Signed-off-by: Miaohe Lin Reviewed-by: Mike Kravetz Reviewed-by: Muchun Song Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin Signed-off-by: Yang Yingliang Signed-off-by: Cheng Jian --- mm/hugetlb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 8f1fc2dc355c..824252c70366 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -2776,8 +2776,10 @@ static int hugetlb_sysfs_add_hstate(struct hstate *h, struct kobject *parent, return -ENOMEM; retval = sysfs_create_group(hstate_kobjs[hi], hstate_attr_group); - if (retval) + if (retval) { kobject_put(hstate_kobjs[hi]); + hstate_kobjs[hi] = NULL; + } return retval; } -- GitLab