提交 8888ea77 编写于 作者: N Nayna Jain 提交者: Michael Ellerman

powerpc/pseries: cleanup error logs in plpks driver

Logging H_CALL return codes in PLPKS driver are easy to confuse with
Linux error codes.

Let the caller of the function log the converted linux error code.
Signed-off-by: NNayna Jain <nayna@linux.ibm.com>
Signed-off-by: NMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20221106205839.600442-5-nayna@linux.ibm.com
上级 bb8e4c7c
...@@ -312,10 +312,6 @@ int plpks_write_var(struct plpks_var var) ...@@ -312,10 +312,6 @@ int plpks_write_var(struct plpks_var var)
if (!rc) if (!rc)
rc = plpks_confirm_object_flushed(label, auth); rc = plpks_confirm_object_flushed(label, auth);
if (rc)
pr_err("Failed to write variable %s for component %s with error %d\n",
var.name, var.component, rc);
rc = pseries_status_to_err(rc); rc = pseries_status_to_err(rc);
kfree(label); kfree(label);
out: out:
...@@ -350,10 +346,6 @@ int plpks_remove_var(char *component, u8 varos, struct plpks_var_name vname) ...@@ -350,10 +346,6 @@ int plpks_remove_var(char *component, u8 varos, struct plpks_var_name vname)
if (!rc) if (!rc)
rc = plpks_confirm_object_flushed(label, auth); rc = plpks_confirm_object_flushed(label, auth);
if (rc)
pr_err("Failed to remove variable %s for component %s with error %d\n",
vname.name, component, rc);
rc = pseries_status_to_err(rc); rc = pseries_status_to_err(rc);
kfree(label); kfree(label);
out: out:
...@@ -395,8 +387,6 @@ static int plpks_read_var(u8 consumer, struct plpks_var *var) ...@@ -395,8 +387,6 @@ static int plpks_read_var(u8 consumer, struct plpks_var *var)
maxobjsize); maxobjsize);
if (rc != H_SUCCESS) { if (rc != H_SUCCESS) {
pr_err("Failed to read variable %s for component %s with error %d\n",
var->name, var->component, rc);
rc = pseries_status_to_err(rc); rc = pseries_status_to_err(rc);
goto out_free_output; goto out_free_output;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册