提交 84e21493 编写于 作者: S Suresh Siddha 提交者: Ingo Molnar

x86, intr-remap: Avoid irq_chip mask/unmask in fixup_irqs() for intr-remapping

In the presence of interrupt-remapping, irqs will be migrated in
the process context and we don't do (and there is no need to)
irq_chip mask/unmask while migrating the interrupt.

Similarly fix the fixup_irqs() that get called during cpu
offline and avoid calling irq_chip mask/unmask for irqs that are
ok to be migrated in the process context.

While we didn't observe any race condition with the existing
code, this change takes complete advantage of
interrupt-remapping in the newer generation platforms and avoids
any potential HW lockup's (that often worry Eric :)
Signed-off-by: NSuresh Siddha <suresh.b.siddha@intel.com>
Acked-by: NEric W. Biederman <ebiederm@xmission.com>
Cc: garyhade@us.ibm.com
LKML-Reference: <20091026230001.661423939@sbs-t61.sc.intel.com>
Signed-off-by: NIngo Molnar <mingo@elte.hu>
上级 7a7732bc
...@@ -310,7 +310,7 @@ void fixup_irqs(void) ...@@ -310,7 +310,7 @@ void fixup_irqs(void)
affinity = cpu_all_mask; affinity = cpu_all_mask;
} }
if (desc->chip->mask) if (!(desc->status & IRQ_MOVE_PCNTXT) && desc->chip->mask)
desc->chip->mask(irq); desc->chip->mask(irq);
if (desc->chip->set_affinity) if (desc->chip->set_affinity)
...@@ -318,7 +318,7 @@ void fixup_irqs(void) ...@@ -318,7 +318,7 @@ void fixup_irqs(void)
else if (!(warned++)) else if (!(warned++))
set_affinity = 0; set_affinity = 0;
if (desc->chip->unmask) if (!(desc->status & IRQ_MOVE_PCNTXT) && desc->chip->unmask)
desc->chip->unmask(irq); desc->chip->unmask(irq);
spin_unlock(&desc->lock); spin_unlock(&desc->lock);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册