提交 644a9d3b 编写于 作者: A Axel Lin 提交者: Greg Kroah-Hartman

misc: apds9802als: Fix the logic checking timeout in als_wait_for_data_ready()

In the case of timeout waiting for data ready, the retry variable is -1.
This also fixes a bug: current code returns -ETIMEDOUT if latest retry success
( which means retry is 0 when exiting the while loop ).
Signed-off-by: NAxel Lin <axel.lin@ingics.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
上级 ebf1b764
...@@ -68,7 +68,7 @@ static int als_wait_for_data_ready(struct device *dev) ...@@ -68,7 +68,7 @@ static int als_wait_for_data_ready(struct device *dev)
ret = i2c_smbus_read_byte_data(client, 0x86); ret = i2c_smbus_read_byte_data(client, 0x86);
} while (!(ret & 0x80) && retry--); } while (!(ret & 0x80) && retry--);
if (!retry) { if (retry < 0) {
dev_warn(dev, "timeout waiting for data ready\n"); dev_warn(dev, "timeout waiting for data ready\n");
return -ETIMEDOUT; return -ETIMEDOUT;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册