From 60ed8cf78f886753e454b671841c0a3a0e55e915 Mon Sep 17 00:00:00 2001 From: Miklos Szeredi Date: Wed, 16 Mar 2011 18:17:54 +0100 Subject: [PATCH] fix cdev leak on O_PATH final fput() __fput doesn't need a cdev_put() for O_PATH handles. Signed-off-by: mszeredi@suse.cz Signed-off-by: Al Viro --- fs/file_table.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/file_table.c b/fs/file_table.c index 74a9544ac770..db30d3497f1a 100644 --- a/fs/file_table.c +++ b/fs/file_table.c @@ -246,8 +246,10 @@ static void __fput(struct file *file) file->f_op->release(inode, file); security_file_free(file); ima_file_free(file); - if (unlikely(S_ISCHR(inode->i_mode) && inode->i_cdev != NULL)) + if (unlikely(S_ISCHR(inode->i_mode) && inode->i_cdev != NULL && + !(file->f_mode & FMODE_PATH))) { cdev_put(inode->i_cdev); + } fops_put(file->f_op); put_pid(file->f_owner.pid); file_sb_list_del(file); -- GitLab