提交 441d38c6 编写于 作者: G Gustavo A. R. Silva 提交者: Sebastian Reichel

power: supply: cros_usbpd: Use struct_size() helper in kzalloc()

Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows that,
in the worst scenario, could lead to heap overflows.

Also, address the following sparse warnings:
drivers/power/supply/cros_usbpd-charger.c:107:23: warning: using sizeof on a flexible structure

Link: https://github.com/KSPP/linux/issues/174Signed-off-by: NGustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>
上级 e783362e
...@@ -104,7 +104,7 @@ static int cros_usbpd_charger_ec_command(struct charger_data *charger, ...@@ -104,7 +104,7 @@ static int cros_usbpd_charger_ec_command(struct charger_data *charger,
struct cros_ec_command *msg; struct cros_ec_command *msg;
int ret; int ret;
msg = kzalloc(sizeof(*msg) + max(outsize, insize), GFP_KERNEL); msg = kzalloc(struct_size(msg, data, max(outsize, insize)), GFP_KERNEL);
if (!msg) if (!msg)
return -ENOMEM; return -ENOMEM;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册