提交 30b1047f 编写于 作者: K Krzysztof Kozlowski 提交者: Zheng Zengkai

thermal/drivers/imx_sc: Add missing of_node_put for loop iteration

stable inclusion
from stable-5.10.53
commit 20babcd830922e3aa233c95515cd2052bd6da71f
bugzilla: 175574 https://gitee.com/openeuler/kernel/issues/I4DTUX

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=20babcd830922e3aa233c95515cd2052bd6da71f

--------------------------------

[ Upstream commit 3da97620 ]

Early exits from for_each_available_child_of_node() should decrement the
node reference counter.  Reported by Coccinelle:

  drivers/thermal/imx_sc_thermal.c:93:1-33: WARNING:
    Function "for_each_available_child_of_node" should have of_node_put() before return around line 97.
Signed-off-by: NKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: NJacky Bai <ping.bai@nxp.com>
Signed-off-by: NDaniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210614192230.19248-1-krzysztof.kozlowski@canonical.comSigned-off-by: NSasha Levin <sashal@kernel.org>
Signed-off-by: NChen Jun <chenjun102@huawei.com>
Acked-by: NWeilong Chen <chenweilong@huawei.com>
Signed-off-by: NChen Jun <chenjun102@huawei.com>
Signed-off-by: NZheng Zengkai <zhengzengkai@huawei.com>
上级 fa593b46
...@@ -93,6 +93,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev) ...@@ -93,6 +93,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
for_each_available_child_of_node(np, child) { for_each_available_child_of_node(np, child) {
sensor = devm_kzalloc(&pdev->dev, sizeof(*sensor), GFP_KERNEL); sensor = devm_kzalloc(&pdev->dev, sizeof(*sensor), GFP_KERNEL);
if (!sensor) { if (!sensor) {
of_node_put(child);
of_node_put(sensor_np); of_node_put(sensor_np);
return -ENOMEM; return -ENOMEM;
} }
...@@ -104,6 +105,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev) ...@@ -104,6 +105,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
dev_err(&pdev->dev, dev_err(&pdev->dev,
"failed to get valid sensor resource id: %d\n", "failed to get valid sensor resource id: %d\n",
ret); ret);
of_node_put(child);
break; break;
} }
...@@ -114,6 +116,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev) ...@@ -114,6 +116,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
if (IS_ERR(sensor->tzd)) { if (IS_ERR(sensor->tzd)) {
dev_err(&pdev->dev, "failed to register thermal zone\n"); dev_err(&pdev->dev, "failed to register thermal zone\n");
ret = PTR_ERR(sensor->tzd); ret = PTR_ERR(sensor->tzd);
of_node_put(child);
break; break;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册