提交 25bbe844 编写于 作者: D David Gow 提交者: Christian König

drm: test: Fix 32-bit issue in drm_buddy_test

The drm_buddy_test KUnit tests verify that returned blocks have sizes
which are powers of two using is_power_of_2(). However, is_power_of_2()
operations on a 'long', but the block size is a u64. So on systems where
long is 32-bit, this can sometimes fail even on correctly sized blocks.

This only reproduces randomly, as the parameters passed to the buddy
allocator in this test are random. The seed 0xb2e06022 reproduced it
fine here.

For now, just hardcode an is_power_of_2() implementation using
x & (x - 1).
Signed-off-by: NDavid Gow <davidgow@google.com>
Acked-by: NChristian König <christian.koenig@amd.com>
Reviewed-by: NMaíra Canal <mcanal@igalia.com>
Reviewed-by: NArunpravin Paneer Selvam <arunpravin.paneerselvam@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230329065532.2122295-2-davidgow@google.comSigned-off-by: NChristian König <christian.koenig@amd.com>
上级 4453545b
...@@ -89,7 +89,8 @@ static int check_block(struct kunit *test, struct drm_buddy *mm, ...@@ -89,7 +89,8 @@ static int check_block(struct kunit *test, struct drm_buddy *mm,
err = -EINVAL; err = -EINVAL;
} }
if (!is_power_of_2(block_size)) { /* We can't use is_power_of_2() for a u64 on 32-bit systems. */
if (block_size & (block_size - 1)) {
kunit_err(test, "block size not power of two\n"); kunit_err(test, "block size not power of two\n");
err = -EINVAL; err = -EINVAL;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册