提交 1e42f82c 编写于 作者: U Uwe Kleine-König 提交者: Vinod Koul

dmaengine: sprd: Cleanup in .remove() after pm_runtime_get_sync() failed

It's not allowed to quit remove early without cleaning up completely.
Otherwise this results in resource leaks that probably yield graver
problems later. Here for example some tasklets might survive the lifetime
of the sprd-dma device and access sdev which is freed after .remove()
returns.

As none of the device freeing requires an active device, just ignore the
return value of pm_runtime_get_sync().
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: NBaolin Wang <baolin.wang7@gmail.com>
Link: https://lore.kernel.org/r/20220721204054.323602-1-u.kleine-koenig@pengutronix.deSigned-off-by: NVinod Koul <vkoul@kernel.org>
上级 36834c67
...@@ -1237,11 +1237,8 @@ static int sprd_dma_remove(struct platform_device *pdev) ...@@ -1237,11 +1237,8 @@ static int sprd_dma_remove(struct platform_device *pdev)
{ {
struct sprd_dma_dev *sdev = platform_get_drvdata(pdev); struct sprd_dma_dev *sdev = platform_get_drvdata(pdev);
struct sprd_dma_chn *c, *cn; struct sprd_dma_chn *c, *cn;
int ret;
ret = pm_runtime_get_sync(&pdev->dev); pm_runtime_get_sync(&pdev->dev);
if (ret < 0)
return ret;
/* explicitly free the irq */ /* explicitly free the irq */
if (sdev->irq > 0) if (sdev->irq > 0)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册