From 11cdc06e56c47525e174f34d25260c209745faae Mon Sep 17 00:00:00 2001 From: Jason Yan Date: Thu, 6 Jun 2019 15:31:08 +0800 Subject: [PATCH] scsi: libsas: fix race of setting phy linkrate with lldd hulk inclusion category: bugfix bugzilla: NA CVE: NA --------------------------- The linkrate for direct phys is set by lldd. We should not set it because the phy event is async with the lldd events. After commit 24fa9796a5b0 ("{topost} scsi: libsas: re-init the negotiated_linkrate when phy down v2") has already set this in sas_phy_disconnected() and this function is directly called by the lldd, we do not need this in sas_deform_port(). Fixes: 6dd8639f22e5 ("scsi: libsas: re-init the negotiated_linkrate when phy down") Signed-off-by: Jason Yan Reviewed-by: zhengbin Signed-off-by: Yang Yingliang --- drivers/scsi/libsas/sas_port.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/libsas/sas_port.c b/drivers/scsi/libsas/sas_port.c index 2dff8fad9817..ddf004bf667e 100644 --- a/drivers/scsi/libsas/sas_port.c +++ b/drivers/scsi/libsas/sas_port.c @@ -215,8 +215,6 @@ void sas_deform_port(struct asd_sas_phy *phy, int gone) struct domain_device *dev; unsigned long flags; - phy->phy->negotiated_linkrate = SAS_LINK_RATE_UNKNOWN; - if (!port) return; /* done by a phy event */ -- GitLab