From 111ad9a2ee4b90a0719cede8cac9b0790a5f24bd Mon Sep 17 00:00:00 2001 From: tanshukun Date: Tue, 8 Oct 2019 13:45:47 +0800 Subject: [PATCH] crypto/hisilicon/zip: fix judge of COMMAND reg value driver inclusion category: bugfix bugzilla: NA CVE: NA fix judge of COMMAND reg value Feature or Bugfix:Bugfix Signed-off-by: tanshukun (A) Reviewed-by: wangzhou Reviewed-by: Yang Yingliang Signed-off-by: Yang Yingliang --- drivers/crypto/hisilicon/zip/zip_main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/hisilicon/zip/zip_main.c b/drivers/crypto/hisilicon/zip/zip_main.c index 0c876b74a3f4..44918bf43b80 100644 --- a/drivers/crypto/hisilicon/zip/zip_main.c +++ b/drivers/crypto/hisilicon/zip/zip_main.c @@ -99,6 +99,7 @@ #define HZIP_REG_RD_INTVRL_US 10 #define HZIP_REG_RD_TMOUT_US 1000 #define HZIP_RESET_WAIT_TIMEOUT 400 +#define HZIP_PCI_COMMAND_INVALID 0xFFFFFFFF static const char hisi_zip_name[] = "hisi_zip"; static struct dentry *hzip_debugfs_root; @@ -1426,10 +1427,8 @@ static void hisi_zip_flr_reset_complete(struct hisi_zip *hisi_zip) u32 id; pci_read_config_dword(zip->qm.pdev, PCI_COMMAND, &id); - if (id == ~0) { - hisi_zip_remove(zip->qm.pdev); + if (id == HZIP_PCI_COMMAND_INVALID) dev_err(dev, "Device can not be used!\n"); - } clear_bit(HISI_ZIP_RESET, &zip->status); } -- GitLab