From 0b86f78920919cf36239f4e187ebad7f5d78b5f8 Mon Sep 17 00:00:00 2001 From: Lihong Kou Date: Mon, 5 Aug 2019 15:27:24 +0800 Subject: [PATCH] f2fs: remove duplicate code in f2fs_file_write_iter We will do the same check in generic_write_checks. if (iocb->ki_flags & IOCB_NOWAIT) && !(iocb->ki_flags & IOCB_DIRECT) return -EINVAL; just remove the same check in f2fs_file_write_iter. Signed-off-by: Lihong Kou Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim --- fs/f2fs/file.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 16f39c0c457d..b1f38f2795bc 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -3160,11 +3160,6 @@ static ssize_t f2fs_file_write_iter(struct kiocb *iocb, struct iov_iter *from) goto out; } - if ((iocb->ki_flags & IOCB_NOWAIT) && !(iocb->ki_flags & IOCB_DIRECT)) { - ret = -EINVAL; - goto out; - } - if (!inode_trylock(inode)) { if (iocb->ki_flags & IOCB_NOWAIT) { ret = -EAGAIN; -- GitLab