From 0b48e2787c5b20473cc50970cff2940a976b603b Mon Sep 17 00:00:00 2001 From: Vasily Averin Date: Mon, 31 May 2021 15:47:33 +0800 Subject: [PATCH] fuse: don't ignore errors from fuse_writepages_fill() mainline inclusion from mainline-v5.8-rc6 commit 7779b047a57f6824a43d0e1f70de2741b7426b9d category: bugfix bugzilla: 39163 CVE: NA ------------------------------------------------- fuse_writepages() ignores some errors taken from fuse_writepages_fill() I believe it is a bug: if .writepages is called with WB_SYNC_ALL it should either guarantee that all data was successfully saved or return error. Fixes: 26d614df1da9 ("fuse: Implement writepages callback") Signed-off-by: Vasily Averin Signed-off-by: Miklos Szeredi Signed-off-by: Yu Kuai Reviewed-by: Zhang Yi Signed-off-by: Yang Yingliang --- fs/fuse/file.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/fuse/file.c b/fs/fuse/file.c index c1af038920dc..9c1189784572 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -1936,10 +1936,8 @@ static int fuse_writepages(struct address_space *mapping, err = write_cache_pages(mapping, wbc, fuse_writepages_fill, &data); if (data.req) { - /* Ignore errors if we can write at least one page */ BUG_ON(!data.req->num_pages); fuse_writepages_send(&data); - err = 0; } if (data.ff) fuse_file_put(data.ff, false, false); -- GitLab