From 0a58f474928cbace609fb563295ecb32491b1c4a Mon Sep 17 00:00:00 2001 From: Colin Ian King Date: Fri, 22 Jul 2016 19:04:12 +0100 Subject: [PATCH] kcm: remove redundant -ve error check and return path The check for a -ve error is redundant, remove it and just immediately return the return value from the call to seq_open_net. Signed-off-by: Colin Ian King Signed-off-by: David S. Miller --- net/kcm/kcmproc.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/kcm/kcmproc.c b/net/kcm/kcmproc.c index fda7f4715c58..16c2e03bd388 100644 --- a/net/kcm/kcmproc.c +++ b/net/kcm/kcmproc.c @@ -88,13 +88,9 @@ struct kcm_proc_mux_state { static int kcm_seq_open(struct inode *inode, struct file *file) { struct kcm_seq_muxinfo *muxinfo = PDE_DATA(inode); - int err; - err = seq_open_net(inode, file, &muxinfo->seq_ops, + return seq_open_net(inode, file, &muxinfo->seq_ops, sizeof(struct kcm_proc_mux_state)); - if (err < 0) - return err; - return err; } static void kcm_format_mux_header(struct seq_file *seq) -- GitLab