From 0894f746ad7752d6e5e639b04cf8350446baf033 Mon Sep 17 00:00:00 2001 From: Liu Jian Date: Mon, 18 Feb 2019 22:35:03 +0800 Subject: [PATCH] driver: uio: fix possible memory leak in __uio_register_device mainline inclusion from mainline-5.x commit: 1a392b3de7c5747506b38fc14b2e79977d3c7770 category: bugfix bugzilla: NA CVE: NA --------------------------- 'idev' is malloced in __uio_register_device() and leak free it before leaving from the uio_get_minor() error handing case, it will cause memory leak. Fixes: a93e7b331568 ("uio: Prevent device destruction while fds are open") Signed-off-by: Liu Jian Reviewed-by: Hamish Martin Signed-off-by: Greg Kroah-Hartman Signed-off-by: Yang Yingliang Reviewed-by: Liu Jian Signed-off-by: Yang Yingliang --- drivers/uio/uio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c index 6c8114f77cfa..12a39f67d86f 100644 --- a/drivers/uio/uio.c +++ b/drivers/uio/uio.c @@ -938,8 +938,10 @@ int __uio_register_device(struct module *owner, atomic_set(&idev->event, 0); ret = uio_get_minor(idev); - if (ret) + if (ret) { + kfree(idev); return ret; + } idev->dev.devt = MKDEV(uio_major, idev->minor); idev->dev.class = &uio_class; -- GitLab