intel_lvds.c 31.7 KB
Newer Older
J
Jesse Barnes 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29
/*
 * Copyright © 2006-2007 Intel Corporation
 * Copyright (c) 2006 Dave Airlie <airlied@linux.ie>
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 * DEALINGS IN THE SOFTWARE.
 *
 * Authors:
 *	Eric Anholt <eric@anholt.net>
 *      Dave Airlie <airlied@linux.ie>
 *      Jesse Barnes <jesse.barnes@intel.com>
 */

30
#include <acpi/button.h>
31
#include <linux/dmi.h>
J
Jesse Barnes 已提交
32
#include <linux/i2c.h>
33
#include <linux/slab.h>
34
#include <drm/drmP.h>
35
#include <drm/drm_atomic_helper.h>
36 37
#include <drm/drm_crtc.h>
#include <drm/drm_edid.h>
J
Jesse Barnes 已提交
38
#include "intel_drv.h"
39
#include <drm/i915_drm.h>
J
Jesse Barnes 已提交
40
#include "i915_drv.h"
41
#include <linux/acpi.h>
J
Jesse Barnes 已提交
42

43
/* Private structure for the integrated LVDS support */
44 45
struct intel_lvds_connector {
	struct intel_connector base;
46

47
	struct notifier_block lid_notifier;
48 49
};

50
struct intel_lvds_encoder {
C
Chris Wilson 已提交
51
	struct intel_encoder base;
52

53
	bool is_dual_link;
D
Daniel Vetter 已提交
54
	u32 reg;
55
	u32 a3_power;
56

57
	struct intel_lvds_connector *attached_connector;
58 59
};

60
static struct intel_lvds_encoder *to_lvds_encoder(struct drm_encoder *encoder)
C
Chris Wilson 已提交
61
{
62
	return container_of(encoder, struct intel_lvds_encoder, base.base);
C
Chris Wilson 已提交
63 64
}

65
static struct intel_lvds_connector *to_lvds_connector(struct drm_connector *connector)
66
{
67
	return container_of(connector, struct intel_lvds_connector, base.base);
68 69
}

70 71 72 73 74
static bool intel_lvds_get_hw_state(struct intel_encoder *encoder,
				    enum pipe *pipe)
{
	struct drm_device *dev = encoder->base.dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
D
Daniel Vetter 已提交
75
	struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
76
	enum intel_display_power_domain power_domain;
D
Daniel Vetter 已提交
77
	u32 tmp;
78

79
	power_domain = intel_display_port_power_domain(encoder);
80
	if (!intel_display_power_is_enabled(dev_priv, power_domain))
81 82
		return false;

D
Daniel Vetter 已提交
83
	tmp = I915_READ(lvds_encoder->reg);
84 85 86 87 88 89 90 91 92 93 94 95

	if (!(tmp & LVDS_PORT_EN))
		return false;

	if (HAS_PCH_CPT(dev))
		*pipe = PORT_TO_PIPE_CPT(tmp);
	else
		*pipe = PORT_TO_PIPE(tmp);

	return true;
}

96
static void intel_lvds_get_config(struct intel_encoder *encoder,
97
				  struct intel_crtc_state *pipe_config)
98 99 100 101
{
	struct drm_device *dev = encoder->base.dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	u32 lvds_reg, tmp, flags = 0;
102
	int dotclock;
103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118

	if (HAS_PCH_SPLIT(dev))
		lvds_reg = PCH_LVDS;
	else
		lvds_reg = LVDS;

	tmp = I915_READ(lvds_reg);
	if (tmp & LVDS_HSYNC_POLARITY)
		flags |= DRM_MODE_FLAG_NHSYNC;
	else
		flags |= DRM_MODE_FLAG_PHSYNC;
	if (tmp & LVDS_VSYNC_POLARITY)
		flags |= DRM_MODE_FLAG_NVSYNC;
	else
		flags |= DRM_MODE_FLAG_PVSYNC;

119
	pipe_config->base.adjusted_mode.flags |= flags;
120

121 122 123 124 125 126 127
	/* gen2/3 store dither state in pfit control, needs to match */
	if (INTEL_INFO(dev)->gen < 4) {
		tmp = I915_READ(PFIT_CONTROL);

		pipe_config->gmch_pfit.control |= tmp & PANEL_8TO6_DITHER_ENABLE;
	}

128 129 130 131 132
	dotclock = pipe_config->port_clock;

	if (HAS_PCH_SPLIT(dev_priv->dev))
		ironlake_check_encoder_dotclock(pipe_config, dotclock);

133
	pipe_config->base.adjusted_mode.crtc_clock = dotclock;
134 135
}

136
static void intel_pre_enable_lvds(struct intel_encoder *encoder)
137 138 139 140
{
	struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
	struct drm_device *dev = encoder->base.dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
141
	struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
142
	const struct drm_display_mode *adjusted_mode =
143
		&crtc->config->base.adjusted_mode;
144
	int pipe = crtc->pipe;
145 146
	u32 temp;

147 148 149 150 151 152 153 154
	if (HAS_PCH_SPLIT(dev)) {
		assert_fdi_rx_pll_disabled(dev_priv, pipe);
		assert_shared_dpll_disabled(dev_priv,
					    intel_crtc_to_shared_dpll(crtc));
	} else {
		assert_pll_disabled(dev_priv, pipe);
	}

155 156
	temp = I915_READ(lvds_encoder->reg);
	temp |= LVDS_PORT_EN | LVDS_A0A2_CLKA_POWER_UP;
157 158 159 160

	if (HAS_PCH_CPT(dev)) {
		temp &= ~PORT_TRANS_SEL_MASK;
		temp |= PORT_TRANS_SEL_CPT(pipe);
161
	} else {
162 163 164 165 166
		if (pipe == 1) {
			temp |= LVDS_PIPEB_SELECT;
		} else {
			temp &= ~LVDS_PIPEB_SELECT;
		}
167
	}
168

169
	/* set the corresponsding LVDS_BORDER bit */
170
	temp &= ~LVDS_BORDER_ENABLE;
171
	temp |= crtc->config->gmch_pfit.lvds_border_bits;
172 173 174 175 176 177 178 179 180 181
	/* Set the B0-B3 data pairs corresponding to whether we're going to
	 * set the DPLLs for dual-channel mode or not.
	 */
	if (lvds_encoder->is_dual_link)
		temp |= LVDS_B0B3_POWER_UP | LVDS_CLKB_POWER_UP;
	else
		temp &= ~(LVDS_B0B3_POWER_UP | LVDS_CLKB_POWER_UP);

	/* It would be nice to set 24 vs 18-bit mode (LVDS_A3_POWER_UP)
	 * appropriately here, but we need to look more thoroughly into how
182 183
	 * panels behave in the two modes. For now, let's just maintain the
	 * value we got from the BIOS.
184
	 */
185 186
	 temp &= ~LVDS_A3_POWER_MASK;
	 temp |= lvds_encoder->a3_power;
187 188 189 190 191

	/* Set the dithering flag on LVDS as needed, note that there is no
	 * special lvds dither control bit on pch-split platforms, dithering is
	 * only controlled through the PIPECONF reg. */
	if (INTEL_INFO(dev)->gen == 4) {
192 193
		/* Bspec wording suggests that LVDS port dithering only exists
		 * for 18bpp panels. */
194
		if (crtc->config->dither && crtc->config->pipe_bpp == 18)
195 196 197 198 199
			temp |= LVDS_ENABLE_DITHER;
		else
			temp &= ~LVDS_ENABLE_DITHER;
	}
	temp &= ~(LVDS_HSYNC_POLARITY | LVDS_VSYNC_POLARITY);
200
	if (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC)
201
		temp |= LVDS_HSYNC_POLARITY;
202
	if (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC)
203 204 205 206 207
		temp |= LVDS_VSYNC_POLARITY;

	I915_WRITE(lvds_encoder->reg, temp);
}

J
Jesse Barnes 已提交
208 209 210
/**
 * Sets the power state for the panel.
 */
211
static void intel_enable_lvds(struct intel_encoder *encoder)
J
Jesse Barnes 已提交
212
{
213
	struct drm_device *dev = encoder->base.dev;
214
	struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
215 216
	struct intel_connector *intel_connector =
		&lvds_encoder->attached_connector->base;
J
Jesse Barnes 已提交
217
	struct drm_i915_private *dev_priv = dev->dev_private;
D
Daniel Vetter 已提交
218
	u32 ctl_reg, stat_reg;
219

220
	if (HAS_PCH_SPLIT(dev)) {
221
		ctl_reg = PCH_PP_CONTROL;
222
		stat_reg = PCH_PP_STATUS;
223 224
	} else {
		ctl_reg = PP_CONTROL;
225
		stat_reg = PP_STATUS;
226
	}
J
Jesse Barnes 已提交
227

D
Daniel Vetter 已提交
228
	I915_WRITE(lvds_encoder->reg, I915_READ(lvds_encoder->reg) | LVDS_PORT_EN);
229

230
	I915_WRITE(ctl_reg, I915_READ(ctl_reg) | POWER_TARGET_ON);
D
Daniel Vetter 已提交
231
	POSTING_READ(lvds_encoder->reg);
232 233
	if (wait_for((I915_READ(stat_reg) & PP_ON) != 0, 1000))
		DRM_ERROR("timed out waiting for panel to power on\n");
234

235
	intel_panel_enable_backlight(intel_connector);
236 237
}

238
static void intel_disable_lvds(struct intel_encoder *encoder)
239
{
240
	struct drm_device *dev = encoder->base.dev;
241
	struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
242 243
	struct intel_connector *intel_connector =
		&lvds_encoder->attached_connector->base;
244
	struct drm_i915_private *dev_priv = dev->dev_private;
D
Daniel Vetter 已提交
245
	u32 ctl_reg, stat_reg;
246 247 248

	if (HAS_PCH_SPLIT(dev)) {
		ctl_reg = PCH_PP_CONTROL;
249
		stat_reg = PCH_PP_STATUS;
250 251
	} else {
		ctl_reg = PP_CONTROL;
252
		stat_reg = PP_STATUS;
253 254
	}

255
	intel_panel_disable_backlight(intel_connector);
256 257

	I915_WRITE(ctl_reg, I915_READ(ctl_reg) & ~POWER_TARGET_ON);
258 259
	if (wait_for((I915_READ(stat_reg) & PP_ON) == 0, 1000))
		DRM_ERROR("timed out waiting for panel to power off\n");
260

D
Daniel Vetter 已提交
261 262
	I915_WRITE(lvds_encoder->reg, I915_READ(lvds_encoder->reg) & ~LVDS_PORT_EN);
	POSTING_READ(lvds_encoder->reg);
J
Jesse Barnes 已提交
263 264
}

265 266 267
static enum drm_mode_status
intel_lvds_mode_valid(struct drm_connector *connector,
		      struct drm_display_mode *mode)
J
Jesse Barnes 已提交
268
{
269 270
	struct intel_connector *intel_connector = to_intel_connector(connector);
	struct drm_display_mode *fixed_mode = intel_connector->panel.fixed_mode;
J
Jesse Barnes 已提交
271

272 273 274 275
	if (mode->hdisplay > fixed_mode->hdisplay)
		return MODE_PANEL;
	if (mode->vdisplay > fixed_mode->vdisplay)
		return MODE_PANEL;
J
Jesse Barnes 已提交
276 277 278 279

	return MODE_OK;
}

280
static bool intel_lvds_compute_config(struct intel_encoder *intel_encoder,
281
				      struct intel_crtc_state *pipe_config)
J
Jesse Barnes 已提交
282
{
283 284 285
	struct drm_device *dev = intel_encoder->base.dev;
	struct intel_lvds_encoder *lvds_encoder =
		to_lvds_encoder(&intel_encoder->base);
286 287
	struct intel_connector *intel_connector =
		&lvds_encoder->attached_connector->base;
288
	struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
289
	struct intel_crtc *intel_crtc = lvds_encoder->base.new_crtc;
290
	unsigned int lvds_bpp;
J
Jesse Barnes 已提交
291 292

	/* Should never happen!! */
293
	if (INTEL_INFO(dev)->gen < 4 && intel_crtc->pipe == 0) {
294
		DRM_ERROR("Can't support LVDS on pipe A\n");
J
Jesse Barnes 已提交
295 296 297
		return false;
	}

298
	if (lvds_encoder->a3_power == LVDS_A3_POWER_UP)
299 300 301 302
		lvds_bpp = 8*3;
	else
		lvds_bpp = 6*3;

303
	if (lvds_bpp != pipe_config->pipe_bpp && !pipe_config->bw_constrained) {
304 305 306 307
		DRM_DEBUG_KMS("forcing display bpp (was %d) to LVDS (%d)\n",
			      pipe_config->pipe_bpp, lvds_bpp);
		pipe_config->pipe_bpp = lvds_bpp;
	}
308

J
Jesse Barnes 已提交
309
	/*
310
	 * We have timings from the BIOS for the panel, put them in
J
Jesse Barnes 已提交
311 312 313 314
	 * to the adjusted mode.  The CRTC will be set up for this mode,
	 * with the panel scaling set up to source from the H/VDisplay
	 * of the original mode.
	 */
315
	intel_fixed_panel_mode(intel_connector->panel.fixed_mode,
316
			       adjusted_mode);
317 318

	if (HAS_PCH_SPLIT(dev)) {
319 320
		pipe_config->has_pch_encoder = true;

321 322
		intel_pch_panel_fitting(intel_crtc, pipe_config,
					intel_connector->panel.fitting_mode);
323 324 325
	} else {
		intel_gmch_panel_fitting(intel_crtc, pipe_config,
					 intel_connector->panel.fitting_mode);
J
Jesse Barnes 已提交
326

327
	}
328

J
Jesse Barnes 已提交
329 330 331 332 333 334 335 336 337 338 339 340
	/*
	 * XXX: It would be nice to support lower refresh rates on the
	 * panels to reduce power consumption, and perhaps match the
	 * user's requested refresh rate.
	 */

	return true;
}

/**
 * Detect the LVDS connection.
 *
341 342 343
 * Since LVDS doesn't have hotlug, we use the lid as a proxy.  Open means
 * connected and closed means disconnected.  We also send hotplug events as
 * needed, using lid status notification from the input layer.
J
Jesse Barnes 已提交
344
 */
345
static enum drm_connector_status
346
intel_lvds_detect(struct drm_connector *connector, bool force)
J
Jesse Barnes 已提交
347
{
348
	struct drm_device *dev = connector->dev;
349
	enum drm_connector_status status;
350

351
	DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
352
		      connector->base.id, connector->name);
353

354 355 356
	status = intel_panel_detect(dev);
	if (status != connector_status_unknown)
		return status;
357

358
	return connector_status_connected;
J
Jesse Barnes 已提交
359 360 361 362 363 364 365
}

/**
 * Return the list of DDC modes if available, or the BIOS fixed mode otherwise.
 */
static int intel_lvds_get_modes(struct drm_connector *connector)
{
366
	struct intel_lvds_connector *lvds_connector = to_lvds_connector(connector);
J
Jesse Barnes 已提交
367
	struct drm_device *dev = connector->dev;
368
	struct drm_display_mode *mode;
J
Jesse Barnes 已提交
369

370
	/* use cached edid if we have one */
371
	if (!IS_ERR_OR_NULL(lvds_connector->base.edid))
372
		return drm_add_edid_modes(connector, lvds_connector->base.edid);
J
Jesse Barnes 已提交
373

374
	mode = drm_mode_duplicate(dev, lvds_connector->base.panel.fixed_mode);
C
Chris Wilson 已提交
375
	if (mode == NULL)
376
		return 0;
J
Jesse Barnes 已提交
377

378 379
	drm_mode_probed_add(connector, mode);
	return 1;
J
Jesse Barnes 已提交
380 381
}

382 383
static int intel_no_modeset_on_lid_dmi_callback(const struct dmi_system_id *id)
{
384
	DRM_INFO("Skipping forced modeset for %s\n", id->ident);
385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401
	return 1;
}

/* The GPU hangs up on these systems if modeset is performed on LID open */
static const struct dmi_system_id intel_no_modeset_on_lid[] = {
	{
		.callback = intel_no_modeset_on_lid_dmi_callback,
		.ident = "Toshiba Tecra A11",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
			DMI_MATCH(DMI_PRODUCT_NAME, "TECRA A11"),
		},
	},

	{ }	/* terminating entry */
};

402
/*
403 404 405
 * Lid events. Note the use of 'modeset':
 *  - we set it to MODESET_ON_LID_OPEN on lid close,
 *    and set it to MODESET_DONE on open
406
 *  - we use it as a "only once" bit (ie we ignore
407 408 409 410
 *    duplicate events where it was already properly set)
 *  - the suspend/resume paths will set it to
 *    MODESET_SUSPENDED and ignore the lid open event,
 *    because they restore the mode ("lid open").
411
 */
412 413 414
static int intel_lid_notify(struct notifier_block *nb, unsigned long val,
			    void *unused)
{
415 416 417 418 419
	struct intel_lvds_connector *lvds_connector =
		container_of(nb, struct intel_lvds_connector, lid_notifier);
	struct drm_connector *connector = &lvds_connector->base.base;
	struct drm_device *dev = connector->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
420

421 422 423
	if (dev->switch_power_state != DRM_SWITCH_POWER_ON)
		return NOTIFY_OK;

424 425 426
	mutex_lock(&dev_priv->modeset_restore_lock);
	if (dev_priv->modeset_restore == MODESET_SUSPENDED)
		goto exit;
427 428 429 430
	/*
	 * check and update the status of LVDS connector after receiving
	 * the LID nofication event.
	 */
431
	connector->status = connector->funcs->detect(connector, false);
432

433 434
	/* Don't force modeset on machines where it causes a GPU lockup */
	if (dmi_check_system(intel_no_modeset_on_lid))
435
		goto exit;
436
	if (!acpi_lid_open()) {
437 438 439
		/* do modeset on next lid open event */
		dev_priv->modeset_restore = MODESET_ON_LID_OPEN;
		goto exit;
440
	}
441

442 443
	if (dev_priv->modeset_restore == MODESET_DONE)
		goto exit;
444

445 446 447 448 449 450 451 452 453 454 455 456 457
	/*
	 * Some old platform's BIOS love to wreak havoc while the lid is closed.
	 * We try to detect this here and undo any damage. The split for PCH
	 * platforms is rather conservative and a bit arbitrary expect that on
	 * those platforms VGA disabling requires actual legacy VGA I/O access,
	 * and as part of the cleanup in the hw state restore we also redisable
	 * the vga plane.
	 */
	if (!HAS_PCH_SPLIT(dev)) {
		drm_modeset_lock_all(dev);
		intel_modeset_setup_hw_state(dev, true);
		drm_modeset_unlock_all(dev);
	}
458

459 460 461 462
	dev_priv->modeset_restore = MODESET_DONE;

exit:
	mutex_unlock(&dev_priv->modeset_restore_lock);
463 464 465
	return NOTIFY_OK;
}

J
Jesse Barnes 已提交
466 467 468 469 470 471 472 473 474
/**
 * intel_lvds_destroy - unregister and free LVDS structures
 * @connector: connector to free
 *
 * Unregister the DDC bus for this connector then free the driver private
 * structure.
 */
static void intel_lvds_destroy(struct drm_connector *connector)
{
475 476
	struct intel_lvds_connector *lvds_connector =
		to_lvds_connector(connector);
J
Jesse Barnes 已提交
477

478 479
	if (lvds_connector->lid_notifier.notifier_call)
		acpi_lid_notifier_unregister(&lvds_connector->lid_notifier);
J
Jesse Barnes 已提交
480

481 482 483
	if (!IS_ERR_OR_NULL(lvds_connector->base.edid))
		kfree(lvds_connector->base.edid);

484
	intel_panel_fini(&lvds_connector->base.panel);
485

J
Jesse Barnes 已提交
486 487 488 489
	drm_connector_cleanup(connector);
	kfree(connector);
}

490 491 492 493
static int intel_lvds_set_property(struct drm_connector *connector,
				   struct drm_property *property,
				   uint64_t value)
{
494
	struct intel_connector *intel_connector = to_intel_connector(connector);
495 496
	struct drm_device *dev = connector->dev;

497
	if (property == dev->mode_config.scaling_mode_property) {
498
		struct drm_crtc *crtc;
499

500 501
		if (value == DRM_MODE_SCALE_NONE) {
			DRM_DEBUG_KMS("no scaling not supported\n");
502
			return -EINVAL;
503
		}
504

505
		if (intel_connector->panel.fitting_mode == value) {
506 507 508
			/* the LVDS scaling property is not changed */
			return 0;
		}
509
		intel_connector->panel.fitting_mode = value;
510 511

		crtc = intel_attached_encoder(connector)->base.crtc;
512 513 514 515 516
		if (crtc && crtc->enabled) {
			/*
			 * If the CRTC is enabled, the display will be changed
			 * according to the new panel fitting mode.
			 */
517
			intel_crtc_restore_mode(crtc);
518 519 520
		}
	}

521 522 523
	return 0;
}

J
Jesse Barnes 已提交
524 525 526
static const struct drm_connector_helper_funcs intel_lvds_connector_helper_funcs = {
	.get_modes = intel_lvds_get_modes,
	.mode_valid = intel_lvds_mode_valid,
527
	.best_encoder = intel_best_encoder,
J
Jesse Barnes 已提交
528 529 530
};

static const struct drm_connector_funcs intel_lvds_connector_funcs = {
531
	.dpms = intel_connector_dpms,
J
Jesse Barnes 已提交
532 533
	.detect = intel_lvds_detect,
	.fill_modes = drm_helper_probe_single_connector_modes,
534
	.set_property = intel_lvds_set_property,
J
Jesse Barnes 已提交
535
	.destroy = intel_lvds_destroy,
536
	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
J
Jesse Barnes 已提交
537 538 539
};

static const struct drm_encoder_funcs intel_lvds_enc_funcs = {
C
Chris Wilson 已提交
540
	.destroy = intel_encoder_destroy,
J
Jesse Barnes 已提交
541 542
};

543
static int intel_no_lvds_dmi_callback(const struct dmi_system_id *id)
544
{
545
	DRM_INFO("Skipping LVDS initialization for %s\n", id->ident);
546 547
	return 1;
}
J
Jesse Barnes 已提交
548

549
/* These systems claim to have LVDS, but really don't */
550
static const struct dmi_system_id intel_no_lvds[] = {
551 552 553 554
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Apple Mac Mini (Core series)",
		.matches = {
555
			DMI_MATCH(DMI_SYS_VENDOR, "Apple"),
556 557 558 559 560 561 562
			DMI_MATCH(DMI_PRODUCT_NAME, "Macmini1,1"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Apple Mac Mini (Core 2 series)",
		.matches = {
563
			DMI_MATCH(DMI_SYS_VENDOR, "Apple"),
564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582
			DMI_MATCH(DMI_PRODUCT_NAME, "Macmini2,1"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "MSI IM-945GSE-A",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "MSI"),
			DMI_MATCH(DMI_PRODUCT_NAME, "A9830IMS"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Dell Studio Hybrid",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
			DMI_MATCH(DMI_PRODUCT_NAME, "Studio Hybrid 140g"),
		},
	},
583 584
	{
		.callback = intel_no_lvds_dmi_callback,
585 586 587 588 589 590 591 592
		.ident = "Dell OptiPlex FX170",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
			DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex FX170"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
593 594 595 596 597 598
		.ident = "AOpen Mini PC",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "AOpen"),
			DMI_MATCH(DMI_PRODUCT_NAME, "i965GMx-IF"),
		},
	},
599 600 601 602 603 604 605 606
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "AOpen Mini PC MP915",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
			DMI_MATCH(DMI_BOARD_NAME, "i915GMx-F"),
		},
	},
607 608 609 610 611 612 613 614
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "AOpen i915GMm-HFS",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
			DMI_MATCH(DMI_BOARD_NAME, "i915GMm-HFS"),
		},
	},
615 616 617 618 619 620 621 622
	{
		.callback = intel_no_lvds_dmi_callback,
                .ident = "AOpen i45GMx-I",
                .matches = {
                        DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
                        DMI_MATCH(DMI_BOARD_NAME, "i45GMx-I"),
                },
        },
623 624 625 626 627 628 629
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Aopen i945GTt-VFA",
		.matches = {
			DMI_MATCH(DMI_PRODUCT_VERSION, "AO00001JW"),
		},
	},
630 631 632 633 634 635 636 637
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Clientron U800",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Clientron"),
			DMI_MATCH(DMI_PRODUCT_NAME, "U800"),
		},
	},
638
	{
639 640 641 642 643 644 645 646
                .callback = intel_no_lvds_dmi_callback,
                .ident = "Clientron E830",
                .matches = {
                        DMI_MATCH(DMI_SYS_VENDOR, "Clientron"),
                        DMI_MATCH(DMI_PRODUCT_NAME, "E830"),
                },
        },
        {
647 648 649 650 651 652 653
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Asus EeeBox PC EB1007",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK Computer INC."),
			DMI_MATCH(DMI_PRODUCT_NAME, "EB1007"),
		},
	},
654 655 656 657 658 659 660 661
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Asus AT5NM10T-I",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
			DMI_MATCH(DMI_BOARD_NAME, "AT5NM10T-I"),
		},
	},
662 663
	{
		.callback = intel_no_lvds_dmi_callback,
664
		.ident = "Hewlett-Packard HP t5740",
665 666
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
667
			DMI_MATCH(DMI_PRODUCT_NAME, " t5740"),
668 669
		},
	},
670 671 672 673 674
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Hewlett-Packard t5745",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
675
			DMI_MATCH(DMI_PRODUCT_NAME, "hp t5745"),
676 677 678 679 680 681 682
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Hewlett-Packard st5747",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
683
			DMI_MATCH(DMI_PRODUCT_NAME, "hp st5747"),
684 685
		},
	},
686 687 688 689 690 691 692 693
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "MSI Wind Box DC500",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "MICRO-STAR INTERNATIONAL CO., LTD"),
			DMI_MATCH(DMI_BOARD_NAME, "MS-7469"),
		},
	},
694 695 696 697 698 699 700 701
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Gigabyte GA-D525TUD",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co., Ltd."),
			DMI_MATCH(DMI_BOARD_NAME, "D525TUD"),
		},
	},
702 703 704 705 706 707 708 709
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Supermicro X7SPA-H",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Supermicro"),
			DMI_MATCH(DMI_PRODUCT_NAME, "X7SPA-H"),
		},
	},
710 711 712 713 714 715 716 717
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Fujitsu Esprimo Q900",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
			DMI_MATCH(DMI_PRODUCT_NAME, "ESPRIMO Q900"),
		},
	},
718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Intel D410PT",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
			DMI_MATCH(DMI_BOARD_NAME, "D410PT"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Intel D425KT",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
			DMI_EXACT_MATCH(DMI_BOARD_NAME, "D425KT"),
		},
	},
734 735 736 737 738 739 740 741
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Intel D510MO",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
			DMI_EXACT_MATCH(DMI_BOARD_NAME, "D510MO"),
		},
	},
742 743 744 745 746 747 748 749
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Intel D525MW",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
			DMI_EXACT_MATCH(DMI_BOARD_NAME, "D525MW"),
		},
	},
750 751 752

	{ }	/* terminating entry */
};
J
Jesse Barnes 已提交
753

754 755 756 757 758 759 760
/*
 * Enumerate the child dev array parsed from VBT to check whether
 * the LVDS is present.
 * If it is present, return 1.
 * If it is not present, return false.
 * If no child dev is parsed from VBT, it assumes that the LVDS is present.
 */
761 762
static bool lvds_is_present_in_vbt(struct drm_device *dev,
				   u8 *i2c_pin)
763 764
{
	struct drm_i915_private *dev_priv = dev->dev_private;
765
	int i;
766

767
	if (!dev_priv->vbt.child_dev_num)
768
		return true;
769

770
	for (i = 0; i < dev_priv->vbt.child_dev_num; i++) {
771 772
		union child_device_config *uchild = dev_priv->vbt.child_dev + i;
		struct old_child_dev_config *child = &uchild->old;
773 774 775 776

		/* If the device type is not LFP, continue.
		 * We have to check both the new identifiers as well as the
		 * old for compatibility with some BIOSes.
777
		 */
778 779
		if (child->device_type != DEVICE_TYPE_INT_LFP &&
		    child->device_type != DEVICE_TYPE_LFP)
780 781
			continue;

782 783
		if (intel_gmbus_is_port_valid(child->i2c_pin))
			*i2c_pin = child->i2c_pin;
784

785 786 787 788
		/* However, we cannot trust the BIOS writers to populate
		 * the VBT correctly.  Since LVDS requires additional
		 * information from AIM blocks, a non-zero addin offset is
		 * a good indicator that the LVDS is actually present.
789
		 */
790 791 792 793 794 795 796 797 798 799
		if (child->addin_offset)
			return true;

		/* But even then some BIOS writers perform some black magic
		 * and instantiate the device without reference to any
		 * additional data.  Trust that if the VBT was written into
		 * the OpRegion then they have validated the LVDS's existence.
		 */
		if (dev_priv->opregion.vbt)
			return true;
800
	}
801 802

	return false;
803 804
}

805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823
static int intel_dual_link_lvds_callback(const struct dmi_system_id *id)
{
	DRM_INFO("Forcing lvds to dual link mode on %s\n", id->ident);
	return 1;
}

static const struct dmi_system_id intel_dual_link_lvds[] = {
	{
		.callback = intel_dual_link_lvds_callback,
		.ident = "Apple MacBook Pro (Core i5/i7 Series)",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
			DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro8,2"),
		},
	},
	{ }	/* terminating entry */
};

bool intel_is_dual_link_lvds(struct drm_device *dev)
824 825 826 827
{
	struct intel_encoder *encoder;
	struct intel_lvds_encoder *lvds_encoder;

828
	for_each_intel_encoder(dev, encoder) {
829 830 831 832 833 834 835 836 837 838
		if (encoder->type == INTEL_OUTPUT_LVDS) {
			lvds_encoder = to_lvds_encoder(&encoder->base);

			return lvds_encoder->is_dual_link;
		}
	}

	return false;
}

D
Daniel Vetter 已提交
839
static bool compute_is_dual_link_lvds(struct intel_lvds_encoder *lvds_encoder)
840
{
D
Daniel Vetter 已提交
841
	struct drm_device *dev = lvds_encoder->base.base.dev;
842 843 844 845
	unsigned int val;
	struct drm_i915_private *dev_priv = dev->dev_private;

	/* use the module option value if specified */
846 847
	if (i915.lvds_channel_mode > 0)
		return i915.lvds_channel_mode == 2;
848 849 850 851

	if (dmi_check_system(intel_dual_link_lvds))
		return true;

852 853 854 855 856
	/* BIOS should set the proper LVDS register value at boot, but
	 * in reality, it doesn't set the value when the lid is closed;
	 * we need to check "the value to be set" in VBT when LVDS
	 * register is uninitialized.
	 */
D
Daniel Vetter 已提交
857
	val = I915_READ(lvds_encoder->reg);
858
	if (!(val & ~(LVDS_PIPE_MASK | LVDS_DETECTED)))
859
		val = dev_priv->vbt.bios_lvds_val;
860

861 862 863
	return (val & LVDS_CLKB_POWER_MASK) == LVDS_CLKB_POWER_UP;
}

864 865 866 867
static bool intel_lvds_supported(struct drm_device *dev)
{
	/* With the introduction of the PCH we gained a dedicated
	 * LVDS presence pin, use it. */
868
	if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev))
869 870 871 872
		return true;

	/* Otherwise LVDS was only attached to mobile products,
	 * except for the inglorious 830gm */
873 874 875 876
	if (INTEL_INFO(dev)->gen <= 4 && IS_MOBILE(dev) && !IS_I830(dev))
		return true;

	return false;
877 878
}

J
Jesse Barnes 已提交
879 880 881 882 883 884 885
/**
 * intel_lvds_init - setup LVDS connectors on this device
 * @dev: drm device
 *
 * Create the connector, register the LVDS DDC bus, and try to figure out what
 * modes we can display on the LVDS panel (if present).
 */
886
void intel_lvds_init(struct drm_device *dev)
J
Jesse Barnes 已提交
887 888
{
	struct drm_i915_private *dev_priv = dev->dev_private;
889
	struct intel_lvds_encoder *lvds_encoder;
890
	struct intel_encoder *intel_encoder;
891
	struct intel_lvds_connector *lvds_connector;
892
	struct intel_connector *intel_connector;
J
Jesse Barnes 已提交
893 894 895
	struct drm_connector *connector;
	struct drm_encoder *encoder;
	struct drm_display_mode *scan; /* *modes, *bios_mode; */
896
	struct drm_display_mode *fixed_mode = NULL;
897
	struct drm_display_mode *downclock_mode = NULL;
898
	struct edid *edid;
J
Jesse Barnes 已提交
899 900
	struct drm_crtc *crtc;
	u32 lvds;
901 902
	int pipe;
	u8 pin;
J
Jesse Barnes 已提交
903

904 905 906 907 908 909 910 911 912 913 914
	/*
	 * Unlock registers and just leave them unlocked. Do this before
	 * checking quirk lists to avoid bogus WARNINGs.
	 */
	if (HAS_PCH_SPLIT(dev)) {
		I915_WRITE(PCH_PP_CONTROL,
			   I915_READ(PCH_PP_CONTROL) | PANEL_UNLOCK_REGS);
	} else {
		I915_WRITE(PP_CONTROL,
			   I915_READ(PP_CONTROL) | PANEL_UNLOCK_REGS);
	}
915
	if (!intel_lvds_supported(dev))
916
		return;
917

918 919
	/* Skip init on machines we know falsely report LVDS */
	if (dmi_check_system(intel_no_lvds))
920
		return;
921

922 923
	pin = GMBUS_PORT_PANEL;
	if (!lvds_is_present_in_vbt(dev, &pin)) {
924
		DRM_DEBUG_KMS("LVDS is not present in VBT\n");
925
		return;
A
Adam Jackson 已提交
926
	}
927

928
	if (HAS_PCH_SPLIT(dev)) {
929
		if ((I915_READ(PCH_LVDS) & LVDS_DETECTED) == 0)
930
			return;
931
		if (dev_priv->vbt.edp_support) {
932
			DRM_DEBUG_KMS("disable LVDS for eDP support\n");
933
			return;
934
		}
935 936
	}

937
	lvds_encoder = kzalloc(sizeof(*lvds_encoder), GFP_KERNEL);
938
	if (!lvds_encoder)
939
		return;
J
Jesse Barnes 已提交
940

941
	lvds_connector = kzalloc(sizeof(*lvds_connector), GFP_KERNEL);
942
	if (!lvds_connector) {
943
		kfree(lvds_encoder);
944
		return;
945 946
	}

947 948
	lvds_encoder->attached_connector = lvds_connector;

949
	intel_encoder = &lvds_encoder->base;
950
	encoder = &intel_encoder->base;
951
	intel_connector = &lvds_connector->base;
C
Chris Wilson 已提交
952
	connector = &intel_connector->base;
953
	drm_connector_init(dev, &intel_connector->base, &intel_lvds_connector_funcs,
J
Jesse Barnes 已提交
954 955
			   DRM_MODE_CONNECTOR_LVDS);

956
	drm_encoder_init(dev, &intel_encoder->base, &intel_lvds_enc_funcs,
J
Jesse Barnes 已提交
957 958
			 DRM_MODE_ENCODER_LVDS);

959
	intel_encoder->enable = intel_enable_lvds;
960
	intel_encoder->pre_enable = intel_pre_enable_lvds;
961
	intel_encoder->compute_config = intel_lvds_compute_config;
962
	intel_encoder->disable = intel_disable_lvds;
963
	intel_encoder->get_hw_state = intel_lvds_get_hw_state;
964
	intel_encoder->get_config = intel_lvds_get_config;
965
	intel_connector->get_hw_state = intel_connector_get_hw_state;
966
	intel_connector->unregister = intel_connector_unregister;
967

968
	intel_connector_attach_encoder(intel_connector, intel_encoder);
969
	intel_encoder->type = INTEL_OUTPUT_LVDS;
J
Jesse Barnes 已提交
970

971
	intel_encoder->cloneable = 0;
J
Jesse Barnes 已提交
972 973
	if (HAS_PCH_SPLIT(dev))
		intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
974 975
	else if (IS_GEN4(dev))
		intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
J
Jesse Barnes 已提交
976 977 978
	else
		intel_encoder->crtc_mask = (1 << 1);

J
Jesse Barnes 已提交
979 980 981 982 983
	drm_connector_helper_add(connector, &intel_lvds_connector_helper_funcs);
	connector->display_info.subpixel_order = SubPixelHorizontalRGB;
	connector->interlace_allowed = false;
	connector->doublescan_allowed = false;

D
Daniel Vetter 已提交
984 985 986 987 988 989
	if (HAS_PCH_SPLIT(dev)) {
		lvds_encoder->reg = PCH_LVDS;
	} else {
		lvds_encoder->reg = LVDS;
	}

990 991
	/* create the scaling mode property */
	drm_mode_create_scaling_mode_property(dev);
992
	drm_object_attach_property(&connector->base,
993
				      dev->mode_config.scaling_mode_property,
994
				      DRM_MODE_SCALE_ASPECT);
995
	intel_connector->panel.fitting_mode = DRM_MODE_SCALE_ASPECT;
J
Jesse Barnes 已提交
996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009
	/*
	 * LVDS discovery:
	 * 1) check for EDID on DDC
	 * 2) check for VBT data
	 * 3) check to see if LVDS is already on
	 *    if none of the above, no panel
	 * 4) make sure lid is open
	 *    if closed, act like it's not there for now
	 */

	/*
	 * Attempt to get the fixed panel mode from DDC.  Assume that the
	 * preferred mode is the right one.
	 */
1010
	mutex_lock(&dev->mode_config.mutex);
1011 1012 1013
	edid = drm_get_edid(connector, intel_gmbus_get_adapter(dev_priv, pin));
	if (edid) {
		if (drm_add_edid_modes(connector, edid)) {
1014
			drm_mode_connector_update_edid_property(connector,
1015
								edid);
1016
		} else {
1017 1018
			kfree(edid);
			edid = ERR_PTR(-EINVAL);
1019
		}
1020 1021
	} else {
		edid = ERR_PTR(-ENOENT);
1022
	}
1023 1024 1025
	lvds_connector->base.edid = edid;

	if (IS_ERR_OR_NULL(edid)) {
1026 1027 1028 1029 1030 1031 1032 1033 1034
		/* Didn't get an EDID, so
		 * Set wide sync ranges so we get all modes
		 * handed to valid_mode for checking
		 */
		connector->display_info.min_vfreq = 0;
		connector->display_info.max_vfreq = 200;
		connector->display_info.min_hfreq = 0;
		connector->display_info.max_hfreq = 200;
	}
J
Jesse Barnes 已提交
1035 1036 1037

	list_for_each_entry(scan, &connector->probed_modes, head) {
		if (scan->type & DRM_MODE_TYPE_PREFERRED) {
1038 1039 1040
			DRM_DEBUG_KMS("using preferred mode from EDID: ");
			drm_mode_debug_printmodeline(scan);

1041
			fixed_mode = drm_mode_duplicate(dev, scan);
1042
			if (fixed_mode) {
1043
				downclock_mode =
1044 1045
					intel_find_panel_downclock(dev,
					fixed_mode, connector);
1046 1047
				if (downclock_mode != NULL &&
					i915.lvds_downclock) {
1048 1049 1050 1051 1052 1053 1054 1055 1056 1057
					/* We found the downclock for LVDS. */
					dev_priv->lvds_downclock_avail = true;
					dev_priv->lvds_downclock =
						downclock_mode->clock;
					DRM_DEBUG_KMS("LVDS downclock is found"
					" in EDID. Normal clock %dKhz, "
					"downclock %dKhz\n",
					fixed_mode->clock,
					dev_priv->lvds_downclock);
				}
1058 1059
				goto out;
			}
J
Jesse Barnes 已提交
1060 1061 1062 1063
		}
	}

	/* Failed to get EDID, what about VBT? */
1064
	if (dev_priv->vbt.lfp_lvds_vbt_mode) {
1065
		DRM_DEBUG_KMS("using mode from VBT: ");
1066
		drm_mode_debug_printmodeline(dev_priv->vbt.lfp_lvds_vbt_mode);
1067

1068
		fixed_mode = drm_mode_duplicate(dev, dev_priv->vbt.lfp_lvds_vbt_mode);
1069 1070
		if (fixed_mode) {
			fixed_mode->type |= DRM_MODE_TYPE_PREFERRED;
1071 1072
			goto out;
		}
J
Jesse Barnes 已提交
1073 1074 1075 1076 1077 1078 1079
	}

	/*
	 * If we didn't get EDID, try checking if the panel is already turned
	 * on.  If so, assume that whatever is currently programmed is the
	 * correct mode.
	 */
1080

1081
	/* Ironlake: FIXME if still fail, not try pipe mode now */
1082
	if (HAS_PCH_SPLIT(dev))
1083 1084
		goto failed;

J
Jesse Barnes 已提交
1085 1086
	lvds = I915_READ(LVDS);
	pipe = (lvds & LVDS_PIPEB_SELECT) ? 1 : 0;
1087
	crtc = intel_get_crtc_for_pipe(dev, pipe);
J
Jesse Barnes 已提交
1088 1089

	if (crtc && (lvds & LVDS_PORT_EN)) {
1090 1091
		fixed_mode = intel_crtc_mode_get(dev, crtc);
		if (fixed_mode) {
1092 1093
			DRM_DEBUG_KMS("using current (BIOS) mode: ");
			drm_mode_debug_printmodeline(fixed_mode);
1094
			fixed_mode->type |= DRM_MODE_TYPE_PREFERRED;
1095
			goto out;
J
Jesse Barnes 已提交
1096 1097 1098 1099
		}
	}

	/* If we still don't have a mode after all that, give up. */
1100
	if (!fixed_mode)
J
Jesse Barnes 已提交
1101 1102 1103
		goto failed;

out:
1104 1105
	mutex_unlock(&dev->mode_config.mutex);

D
Daniel Vetter 已提交
1106
	lvds_encoder->is_dual_link = compute_is_dual_link_lvds(lvds_encoder);
1107 1108 1109
	DRM_DEBUG_KMS("detected %s-link lvds configuration\n",
		      lvds_encoder->is_dual_link ? "dual" : "single");

1110 1111 1112
	lvds_encoder->a3_power = I915_READ(lvds_encoder->reg) &
				 LVDS_A3_POWER_MASK;

1113 1114
	lvds_connector->lid_notifier.notifier_call = intel_lid_notify;
	if (acpi_lid_notifier_register(&lvds_connector->lid_notifier)) {
1115
		DRM_DEBUG_KMS("lid notifier registration failed\n");
1116
		lvds_connector->lid_notifier.notifier_call = NULL;
1117
	}
1118
	drm_connector_register(connector);
1119

1120
	intel_panel_init(&intel_connector->panel, fixed_mode, downclock_mode);
1121
	intel_panel_setup_backlight(connector, INVALID_PIPE);
1122

1123
	return;
J
Jesse Barnes 已提交
1124 1125

failed:
1126 1127
	mutex_unlock(&dev->mode_config.mutex);

1128
	DRM_DEBUG_KMS("No LVDS modes found, disabling.\n");
J
Jesse Barnes 已提交
1129
	drm_connector_cleanup(connector);
1130
	drm_encoder_cleanup(encoder);
1131
	kfree(lvds_encoder);
1132
	kfree(lvds_connector);
1133
	return;
J
Jesse Barnes 已提交
1134
}