Add support for identity files as valid SSH options
to our remote plugin. The use case for this is connecting
to Amazon EC2 instances using the provided keypair (.pem
files).

avocado run --remote-hostname my-machine.com --remote-username myuser --remote-key-file /path/to/myfile.pem passtest
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

We use `False` in avocado.conf and remoter should have the same default.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

The slides links are broken.  Let's remove them, and eventually re-add
them when they are put back in place.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The slides links are broken.  Let's remove them, and eventually re-add
them when they are put back in place.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

when the user provides --remote-password and the host is not found
in known_hosts, it raises fabric.network.NetworkError. We catch this
exception in remoter as usually it means the connection timed out
and if we have enough time we try it again.

This patch checks if 'not found in known_hosts' is present in the
exception message breaks the loop to retry, re-raising the exception.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

avocado.core.remoter option to reject remote unknown hosts

avocado: Rename the `args.default_multiplex_tree`

When Avocado runs tests on remote machines it always accepts the
host SSH key fingerprint. This could allow credentials to be stolen
if the remote host name or address is spoofed.

This patch adds to Avocado the configuration option to enable/disable
the reject_unknown_hosts option, so user can choose between safe or
flexible.

Notice there is an issue in Paramiko where it does not recognizes
ecdsa keys in known_hosts file. So for reject_unknown_hosts to work,
we currently have to accept the remote host key fingerprint in RSA format.
To do so, the SSH command shouled be like below:

  $ ssh -oHostKeyAlgorithms='ssh-rsa' <host>

Reference: https://trello.com/c/oqyAvZBqSigned-off-by: NAmador Pahim <apahim@redhat.com>

When the total number of tests is lower than number of executed tests,
avocado reports incorrect number of tests. Let's increase the number of
tests in such case.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This selftest makes sure test statuses are assessed correctly on the
test end inside jsonresult (which also verifies TestResult handling).

Additionally it makes sure jsonresult handles unknown statuses and
missing values in the status correctly.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The TestResult baseclass keeps the count of executed tests and
additionally on test end it calls function associated with the finish
status. This is not used by any plugin as they usually don't care. The
only one which could benefit from it is xunit, but it uses simplified
version. I think it's time to say good bye to this and simplify the
TestResult class (along with minor speedup)
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Add test as "ERROR" when the status is unknown.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The time related variables cause troubles, when the test is interrupted.
Let's initialize them to 0 so they can be used in result postprocessing
if the test is interrupted between early_status and finish.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

TestResult depends on the test status containing all information. The
problem is that on interruption the status might not be complete. Let's
provide understandable defaults for such cases.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Currently all classes inherited from TestResult are storing the full
state per each executed test, although there is actually none using it.
Those who need additional information store them again in their
variables. Let's avoid wasting of memory and only store the counts
instead.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The `args.default_multiplex_tree` stands for default avocado params,
which currently supports only `multiplexer` implementation. This might
change in the future, but this variable could be used by other backends
too. So let's rename it now to `default_avocado_params`.

Additionally it's only set when the system is multiplexer-enabled, but
it has nothing to do with the multiplexer (directly). Multiplexer is
only one of the sources of params. So let's initialize it always. This
avoids a bug in `avocado-virt`, which uses this default params to set
it's params and it does that via this generic API (not dependent on the
multiplexer at all).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

avocado.spec: add python-lxml to build dependencies

Add short section about GPG signing (optional).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

avocado.core.remoter remote actions should fail on prompt [v3]

When avocado is run out of the source tree, it ignores the user local
configuration (~/.config/avocado/avocado.conf).  IMHO this is both
inconsistent and bad for development sessions.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Avocado is not interactive. Remote can prompt for interaction for
a number of reasons: unknown host key, password request and so on.

This patch makes Avocado to fail when interaction for remote access is
needed, forwarding the correspondent Fabric's message for the user.

Reference: https://trello.com/c/GEa8BY2jSigned-off-by: NAmador Pahim <apahim@redhat.com>

Commit 8dad284b introduced a requirement on python-lxml. Let's reflect
that on the SPEC file.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

We're substituting `os.path` with flexmock, let's not forget to clean-up
properly.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

only the basename of the `self.filename` has to be shorter than
maxsize-5, not the full path.

Also the IOError in selftest is rather misleading as it relates to
missing source file. Let's just check the path is correctly set and
additionally verify `_record_reference_*` is not crashing when filename
not associated.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Plugin Improvements