From b54aec68788d59fb1a56c0462a8255a0cb1842e9 Mon Sep 17 00:00:00 2001
From: Cleber Rosa <crosa@redhat.com>
Date: Wed, 18 Apr 2018 15:54:56 -0400
Subject: [PATCH] Glib Plugin: don't attempt to run test reference if not an
 executable

This prevents the plugin from trying to run references such as
Avocado-VT tests or any other that is not backed by an executable
file.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 .../glib/avocado_glib/__init__.py             | 33 +++++++++++--------
 1 file changed, 19 insertions(+), 14 deletions(-)

diff --git a/optional_plugins/glib/avocado_glib/__init__.py b/optional_plugins/glib/avocado_glib/__init__.py
index b28c4beb..fe2663cb 100644
--- a/optional_plugins/glib/avocado_glib/__init__.py
+++ b/optional_plugins/glib/avocado_glib/__init__.py
@@ -16,8 +16,10 @@
 Plugin to run GLib Test Framework tests in Avocado
 """
 
+import os
 import re
 
+from avocado.utils import path
 from avocado.utils import process
 
 from avocado.core import loader
@@ -82,21 +84,24 @@ class GLibLoader(loader.TestLoader):
         if ':' in reference:
             reference, _subtests_filter = reference.split(':', 1)
             subtests_filter = re.compile(_subtests_filter)
-        try:
-            cmd = '%s -l' % (reference)
-            result = process.run(cmd)
-        except Exception as details:
-            if which_tests == loader.ALL:
-                return [(NotGLibTest,
-                         {"name": "%s: %s" % (reference, details)})]
-            return []
 
-        for test in result.stdout.splitlines():
-            test_name = "%s:%s" % (reference, test)
-            if subtests_filter and not subtests_filter.search(test_name):
-                continue
-            avocado_suite.append((GLibTest, {'name': test_name,
-                                             'executable': test_name}))
+        if (os.path.isfile(reference) and
+                path.PathInspector(reference).has_exec_permission()):
+            try:
+                cmd = '%s -l' % (reference)
+                result = process.run(cmd)
+            except Exception as details:
+                if which_tests == loader.ALL:
+                    return [(NotGLibTest,
+                             {"name": "%s: %s" % (reference, details)})]
+                return []
+
+            for test in result.stdout.splitlines():
+                test_name = "%s:%s" % (reference, test)
+                if subtests_filter and not subtests_filter.search(test_name):
+                    continue
+                avocado_suite.append((GLibTest, {'name': test_name,
+                                                 'executable': test_name}))
 
         if which_tests is loader.ALL and not avocado_suite:
             return [(NotGLibTest,
-- 
GitLab