avocado.test: Refactor logger setup code

As pointed out during code review by Rudá.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>
上级 2e2a19d9
......@@ -283,6 +283,14 @@ class Test(unittest.TestCase):
"""
return os.path.join(self.datadir, basename)
def _register_log_file_handler(self, logger, formatter, filename,
log_level=logging.DEBUG):
file_handler = logging.FileHandler(filename=filename)
file_handler.setLevel(log_level)
file_handler.setFormatter(formatter)
logger.addHandler(file_handler)
return file_handler
def start_logging(self):
"""
Simple helper for adding a file logger to the root logger.
......@@ -299,15 +307,10 @@ class Test(unittest.TestCase):
stream_fmt = '%(message)s'
stream_formatter = logging.Formatter(fmt=stream_fmt)
self.stdout_file_handler = logging.FileHandler(filename=self.stdout_file)
self.stdout_file_handler.setLevel(logging.DEBUG)
self.stdout_file_handler.setFormatter(stream_formatter)
self.stdout_log.addHandler(self.stdout_file_handler)
self.stderr_file_handler = logging.FileHandler(filename=self.stderr_file)
self.stderr_file_handler.setLevel(logging.DEBUG)
self.stderr_file_handler.setFormatter(stream_formatter)
self.stderr_log.addHandler(self.stderr_file_handler)
self.stdout_file_handler = self._register_log_file_handler(self.stdout_log, stream_formatter,
self.stdout_file)
self.stderr_file_handler = self._register_log_file_handler(self.stderr_log, stream_formatter,
self.stderr_file)
def stop_logging(self):
"""
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册