diff --git a/src/share/classes/com/sun/tools/javac/jvm/Gen.java b/src/share/classes/com/sun/tools/javac/jvm/Gen.java index 2e7b067f861e6d5bdddca0ffc4588594ceb34373..241845ec0eb3b895c3f4e78901d56f7e7cd2b64e 100644 --- a/src/share/classes/com/sun/tools/javac/jvm/Gen.java +++ b/src/share/classes/com/sun/tools/javac/jvm/Gen.java @@ -1783,7 +1783,16 @@ public class Gen extends JCTree.Visitor { r.load(); code.emitop0(ireturn + Code.truncate(Code.typecode(pt))); } else { + /* If we have a statement like: + * + * return; + * + * we need to store the code.pendingStatPos value before generating + * the finalizer. + */ + int tmpPos = code.pendingStatPos; targetEnv = unwind(env.enclMethod, env); + code.pendingStatPos = tmpPos; code.emitop0(return_); } endFinalizerGaps(env, targetEnv); diff --git a/test/tools/javac/T7008643/InlinedFinallyConfuseDebuggersTest.java b/test/tools/javac/T7008643/InlinedFinallyConfuseDebuggersTest.java new file mode 100644 index 0000000000000000000000000000000000000000..8557f99a383816bb0505610bf13c3b6705e98991 --- /dev/null +++ b/test/tools/javac/T7008643/InlinedFinallyConfuseDebuggersTest.java @@ -0,0 +1,117 @@ +/* + * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 7008643 + * @summary inlined finally clauses confuse debuggers + * @library /tools/javac/lib + * @build ToolBox + * @run main InlinedFinallyConfuseDebuggersTest + */ + +import java.io.File; +import java.nio.file.Paths; + +import com.sun.tools.classfile.ClassFile; +import com.sun.tools.classfile.Code_attribute; +import com.sun.tools.classfile.LineNumberTable_attribute; +import com.sun.tools.classfile.Method; +import com.sun.tools.javac.util.Assert; + +public class InlinedFinallyConfuseDebuggersTest { + + static final String testSource = + /* 01 */ "public class InlinedFinallyTest {\n" + + /* 02 */ " void lookForThisMethod(int value) {\n" + + /* 03 */ " try {\n" + + /* 04 */ " if (value > 0) {\n" + + /* 05 */ " System.out.println(\"if\");\n" + + /* 06 */ " return;\n" + + /* 07 */ " }\n" + + /* 08 */ " } finally {\n" + + /* 09 */ " System.out.println(\"finally\");\n" + + /* 10 */ " }\n" + + /* 11 */ " }\n" + + /* 12 */ "}"; + + static final int[][] expectedLNT = { + // {line-number, start-pc}, + {4, 0}, //if (value > 0) { + {5, 4}, // System.out.println("if"); + {9, 12}, //System.out.println("finally"); + {6, 20}, // return; + {9, 21}, //System.out.println("finally"); + {10, 29}, + {9, 32}, //System.out.println("finally"); + {11, 43}, + }; + + static final String methodToLookFor = "lookForThisMethod"; + + public static void main(String[] args) throws Exception { + new InlinedFinallyConfuseDebuggersTest().run(); + } + + void run() throws Exception { + compileTestClass(); + checkClassFile(new File(Paths.get(System.getProperty("user.dir"), + "InlinedFinallyTest.class").toUri()), methodToLookFor); + } + + void compileTestClass() throws Exception { + ToolBox.JavaToolArgs javacSuccessArgs = + new ToolBox.JavaToolArgs().setSources(testSource); + ToolBox.javac(javacSuccessArgs); + } + + void checkClassFile(final File cfile, String methodToFind) throws Exception { + ClassFile classFile = ClassFile.read(cfile); + boolean methodFound = false; + for (Method method : classFile.methods) { + if (method.getName(classFile.constant_pool).equals(methodToFind)) { + methodFound = true; + Code_attribute code = (Code_attribute) method.attributes.get("Code"); + LineNumberTable_attribute lnt = + (LineNumberTable_attribute) code.attributes.get("LineNumberTable"); + Assert.check(lnt.line_number_table_length == expectedLNT.length, + "The LineNumberTable found has a length different to the expected one"); + int i = 0; + for (LineNumberTable_attribute.Entry entry: lnt.line_number_table) { + Assert.check(entry.line_number == expectedLNT[i][0] && + entry.start_pc == expectedLNT[i][1], + "LNT entry at pos " + i + " differ from expected." + + "Found " + entry.line_number + ":" + entry.start_pc + + ". Expected " + expectedLNT[i][0] + ":" + expectedLNT[i][1]); + i++; + } + } + } + Assert.check(methodFound, "The seek method was not found"); + } + + void error(String msg) { + throw new AssertionError(msg); + } + +}