From 7223135f324a78c1cfb23ec0bd7a62bd18fe972b Mon Sep 17 00:00:00 2001 From: vromero Date: Wed, 31 Jul 2013 10:52:01 +0100 Subject: [PATCH] 8013179: assertion failure in javac when compiling with -source 1.6 -target 1.6 Reviewed-by: jjg --- .../com/sun/tools/javac/comp/TransTypes.java | 6 +++- .../tools/javac/resources/compiler.properties | 4 +++ .../MethodInvokedWithWrongNumberOfArgs.java | 32 +++++++++++++++++++ 3 files changed, 41 insertions(+), 1 deletion(-) create mode 100644 test/tools/javac/diags/examples/MethodInvokedWithWrongNumberOfArgs.java diff --git a/src/share/classes/com/sun/tools/javac/comp/TransTypes.java b/src/share/classes/com/sun/tools/javac/comp/TransTypes.java index 710617bc..47cc589e 100644 --- a/src/share/classes/com/sun/tools/javac/comp/TransTypes.java +++ b/src/share/classes/com/sun/tools/javac/comp/TransTypes.java @@ -674,7 +674,11 @@ public class TransTypes extends TreeTranslator { if (tree.varargsElement != null) tree.varargsElement = types.erasure(tree.varargsElement); else - Assert.check(tree.args.length() == argtypes.length()); + if (tree.args.length() != argtypes.length()) { + log.error(tree.pos(), + "method.invoked.with.incorrect.number.arguments", + tree.args.length(), argtypes.length()); + } tree.args = translateArgs(tree.args, argtypes, tree.varargsElement); tree.type = types.erasure(tree.type); diff --git a/src/share/classes/com/sun/tools/javac/resources/compiler.properties b/src/share/classes/com/sun/tools/javac/resources/compiler.properties index 2017a637..908b0aff 100644 --- a/src/share/classes/com/sun/tools/javac/resources/compiler.properties +++ b/src/share/classes/com/sun/tools/javac/resources/compiler.properties @@ -918,6 +918,10 @@ compiler.err.signature.doesnt.match.supertype=\ compiler.err.signature.doesnt.match.intf=\ signature does not match {0}; incompatible interfaces +# 0: number, 1: number +compiler.err.method.invoked.with.incorrect.number.arguments=\ + method invoked with incorrect number of arguments; expected {0}, found {1} + # 0: symbol, 1: symbol, 2: symbol compiler.err.does.not.override.abstract=\ {0} is not abstract and does not override abstract method {1} in {2} diff --git a/test/tools/javac/diags/examples/MethodInvokedWithWrongNumberOfArgs.java b/test/tools/javac/diags/examples/MethodInvokedWithWrongNumberOfArgs.java new file mode 100644 index 00000000..e4a782b4 --- /dev/null +++ b/test/tools/javac/diags/examples/MethodInvokedWithWrongNumberOfArgs.java @@ -0,0 +1,32 @@ +/* + * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +// key: compiler.err.method.invoked.with.incorrect.number.arguments +// options: -Xlint:-options -source 6 -target 6 + +class MethodInvokedWithWrongNumberOfArgs { + static java.lang.invoke.MethodHandle getNamedMember; + public static Object getMember(String name, Object rec) throws Throwable { + return getNamedMember.invoke(rec, name); + } +} -- GitLab