From fd4cfd65f85d83a6178e73dfb2c9b8d27895d980 Mon Sep 17 00:00:00 2001 From: vinnie Date: Mon, 24 Aug 2009 18:37:37 +0100 Subject: [PATCH] 6872048: bad private keys are generated for 2 specific ECC curves Reviewed-by: wetmore --- src/share/native/sun/security/ec/ec.c | 2 +- test/sun/security/ec/TestEC.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/share/native/sun/security/ec/ec.c b/src/share/native/sun/security/ec/ec.c index d77f110af..0eda7da75 100644 --- a/src/share/native/sun/security/ec/ec.c +++ b/src/share/native/sun/security/ec/ec.c @@ -422,7 +422,7 @@ ec_GenerateRandomPrivateKey(const unsigned char *order, int len, */ if ((privKeyBytes = PORT_Alloc(2*len, kmflag)) == NULL) goto cleanup; if (randomlen != 2 * len) { - goto cleanup; + randomlen = 2 * len; } /* No need to generate - random bytes are now supplied */ /* CHECK_SEC_OK( RNG_GenerateGlobalRandomBytes(privKeyBytes, 2*len) );*/ diff --git a/test/sun/security/ec/TestEC.java b/test/sun/security/ec/TestEC.java index 0f87692a0..12694a03c 100644 --- a/test/sun/security/ec/TestEC.java +++ b/test/sun/security/ec/TestEC.java @@ -53,7 +53,7 @@ public class TestEC { long start = System.currentTimeMillis(); new TestECDH().main(p); new TestECDSA().main(p); - //new TestCurves().main(p); + new TestCurves().main(p); new TestKeyFactory().main(p); new TestECGenSpec().main(p); new ReadPKCS12().main(p); -- GitLab