8162723: Array index overflow in Base64 utility class

Reviewed-by: ascarpino, jnimeh

8162723: Array index overflow in Base64 utility class
Reviewed-by: ascarpino, jnimeh
f4e91231 · mullan · 14232fa8 · f4e91231
显示空白变更内容
内联并排

Showing with 5 addition and 5 deletion

src/share/classes/com/sun/org/apache/xml/internal/security/utils/Base64.java ...om/sun/org/apache/xml/internal/security/utils/Base64.java +5 -5

未找到文件。
--- a/src/share/classes/com/sun/org/apache/xml/internal/security/utils/Base64.java
+++ b/src/share/classes/com/sun/org/apache/xml/internal/security/utils/Base64.java
@@ -376,14 +376,14 @@ public class Base64 {
            return null;
        }
-        int lengthDataBits = binaryData.length * EIGHTBIT;
+        long lengthDataBits = ((long) binaryData.length) * ((long) EIGHTBIT);
-        if (lengthDataBits == 0) {
+        if (lengthDataBits == 0L) {
            return "";
        }
-        int fewerThan24bits = lengthDataBits % TWENTYFOURBITGROUP;
+        long fewerThan24bits = lengthDataBits % TWENTYFOURBITGROUP;
-        int numberTriplets = lengthDataBits / TWENTYFOURBITGROUP;
+        int numberTriplets = (int) (lengthDataBits / TWENTYFOURBITGROUP);
-        int numberQuartet = fewerThan24bits != 0 ? numberTriplets + 1 : numberTriplets;
+        int numberQuartet = fewerThan24bits != 0L ? numberTriplets + 1 : numberTriplets;
        int quartesPerLine = length / 4;
        int numberLines = (numberQuartet - 1) / quartesPerLine;
        char encodedData[] = null;