diff --git a/src/share/classes/javax/swing/PopupFactory.java b/src/share/classes/javax/swing/PopupFactory.java index 99d0359d30345c3a946ca48e27caac02898b455b..4e140c8b0489114e420c403a924aae92412ecd46 100644 --- a/src/share/classes/javax/swing/PopupFactory.java +++ b/src/share/classes/javax/swing/PopupFactory.java @@ -232,7 +232,8 @@ public class PopupFactory { case HEAVY_WEIGHT_POPUP: Popup popup = getHeavyWeightPopup(owner, contents, ownerX, ownerY); if ((AccessController.doPrivileged(OSInfo.getOSTypeAction()) == - OSInfo.OSType.MACOSX) && (EmbeddedFrame.getAppletIfAncestorOf(owner) != null)) { + OSInfo.OSType.MACOSX) && (owner != null) && + (EmbeddedFrame.getAppletIfAncestorOf(owner) != null)) { ((HeavyWeightPopup)popup).setCacheEnabled(false); } return popup; diff --git a/test/javax/swing/PopupFactory/8048506/bug8048506.java b/test/javax/swing/PopupFactory/8048506/bug8048506.java new file mode 100644 index 0000000000000000000000000000000000000000..66167ec08dc676f50372eced6f71868d3c586977 --- /dev/null +++ b/test/javax/swing/PopupFactory/8048506/bug8048506.java @@ -0,0 +1,65 @@ +/* + * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 8048506 + * @summary Tests that popup with null-owner does not throw NPE + * @author Dmitry Markov + */ + +import javax.swing.*; +import javax.swing.plaf.metal.MetalLookAndFeel; + +public class bug8048506 { + + public static void main(String[] args) throws Exception { + UIManager.setLookAndFeel(new MetalLookAndFeel()); + + SwingUtilities.invokeAndWait(new Runnable() { + @Override + public void run() { + createAndShowGUI(); + } + }); + System.out.println("The test passed"); + } + + private static void createAndShowGUI() { + JFrame frame = new JFrame("bug8048506"); + frame.setSize(400, 400); + frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); + frame.setVisible(true); + + PopupFactory factory = PopupFactory.getSharedInstance(); + + // Create and show popup with owner + Popup popup1 = factory.getPopup(frame, new JLabel("Popup with owner"), 100, 100); + popup1.show(); + + //Create and show popup without owner + Popup popup2 = factory.getPopup(null, new JLabel("Popup without owner"), 200, 200); + popup2.show(); + } +} +