diff --git a/src/share/classes/sun/reflect/generics/reflectiveObjects/GenericArrayTypeImpl.java b/src/share/classes/sun/reflect/generics/reflectiveObjects/GenericArrayTypeImpl.java index e356a498e691a823ea739049cd175d0da0487ea4..423a0ebf3f863938c9166ddb3db6a80aebd36a0f 100644 --- a/src/share/classes/sun/reflect/generics/reflectiveObjects/GenericArrayTypeImpl.java +++ b/src/share/classes/sun/reflect/generics/reflectiveObjects/GenericArrayTypeImpl.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2004, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2013, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -27,7 +27,7 @@ package sun.reflect.generics.reflectiveObjects; import java.lang.reflect.GenericArrayType; import java.lang.reflect.Type; - +import java.util.Objects; /** * Implementation of GenericArrayType interface for core reflection. @@ -81,18 +81,13 @@ public class GenericArrayTypeImpl if (o instanceof GenericArrayType) { GenericArrayType that = (GenericArrayType) o; - Type thatComponentType = that.getGenericComponentType(); - return genericComponentType == null ? - thatComponentType == null : - genericComponentType.equals(thatComponentType); + return Objects.equals(genericComponentType, that.getGenericComponentType()); } else return false; } @Override public int hashCode() { - return (genericComponentType == null) ? - 0: - genericComponentType.hashCode(); + return Objects.hashCode(genericComponentType); } } diff --git a/src/share/classes/sun/reflect/generics/reflectiveObjects/ParameterizedTypeImpl.java b/src/share/classes/sun/reflect/generics/reflectiveObjects/ParameterizedTypeImpl.java index 83353aef6a8d560cf8551f4c9780ea5d55e03f54..97524c40a766feffe1b2dfc9f7afb0163f78d8d7 100644 --- a/src/share/classes/sun/reflect/generics/reflectiveObjects/ParameterizedTypeImpl.java +++ b/src/share/classes/sun/reflect/generics/reflectiveObjects/ParameterizedTypeImpl.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2004, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2013, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -33,7 +33,7 @@ import java.lang.reflect.ParameterizedType; import java.lang.reflect.Type; import java.lang.reflect.TypeVariable; import java.util.Arrays; - +import java.util.Objects; /** Implementing class for ParameterizedType interface. */ @@ -47,9 +47,7 @@ public class ParameterizedTypeImpl implements ParameterizedType { Type ownerType) { this.actualTypeArguments = actualTypeArguments; this.rawType = rawType; - if (ownerType != null) { - this.ownerType = ownerType; - } else { this.ownerType = rawType.getDeclaringClass();} + this.ownerType = (ownerType != null) ? ownerType : rawType.getDeclaringClass(); validateConstructorArguments(); } @@ -62,7 +60,6 @@ public class ParameterizedTypeImpl implements ParameterizedType { for (int i = 0; i < actualTypeArguments.length; i++) { // check actuals against formals' bounds } - } /** @@ -189,14 +186,9 @@ public class ParameterizedTypeImpl implements ParameterizedType { return ownerEquality && rawEquality && typeArgEquality; } - return - (ownerType == null ? - thatOwner == null : - ownerType.equals(thatOwner)) && - (rawType == null ? - thatRawType == null : - rawType.equals(thatRawType)) && + Objects.equals(ownerType, thatOwner) && + Objects.equals(rawType, thatRawType) && Arrays.equals(actualTypeArguments, // avoid clone that.getActualTypeArguments()); } else @@ -207,8 +199,8 @@ public class ParameterizedTypeImpl implements ParameterizedType { public int hashCode() { return Arrays.hashCode(actualTypeArguments) ^ - (ownerType == null ? 0 : ownerType.hashCode() ) ^ - (rawType == null ? 0 : rawType.hashCode() ); + Objects.hashCode(ownerType) ^ + Objects.hashCode(rawType); } public String toString() { @@ -239,10 +231,7 @@ public class ParameterizedTypeImpl implements ParameterizedType { for(Type t: actualTypeArguments) { if (!first) sb.append(", "); - if (t instanceof Class) - sb.append(((Class)t).getName()); - else - sb.append(t.toString()); + sb.append(t.getTypeName()); first = false; } sb.append(">"); diff --git a/src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java b/src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java index 0b1a13ee74e08d558437bbb99cbd1f8d2c155845..63da5ea752b899f57db7257c00f277cb03574ad3 100644 --- a/src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java +++ b/src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java @@ -170,13 +170,8 @@ public class TypeVariableImpl GenericDeclaration thatDecl = that.getGenericDeclaration(); String thatName = that.getName(); - return - (genericDeclaration == null ? - thatDecl == null : - genericDeclaration.equals(thatDecl)) && - (name == null ? - thatName == null : - name.equals(thatName)); + return Objects.equals(genericDeclaration, thatDecl) && + Objects.equals(name, thatName); } else return false; diff --git a/src/share/classes/sun/reflect/generics/reflectiveObjects/WildcardTypeImpl.java b/src/share/classes/sun/reflect/generics/reflectiveObjects/WildcardTypeImpl.java index cbbfae0f8722b70d7ca413dcbf450759a9516141..dbb0406dc71167362012a9e3b385f9b13e277be8 100644 --- a/src/share/classes/sun/reflect/generics/reflectiveObjects/WildcardTypeImpl.java +++ b/src/share/classes/sun/reflect/generics/reflectiveObjects/WildcardTypeImpl.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2004, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2013, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -203,10 +203,7 @@ public class WildcardTypeImpl extends LazyReflectiveObjectGenerator sb.append(" & "); first = false; - if (bound instanceof Class) - sb.append(((Class)bound).getName() ); - else - sb.append(bound.toString()); + sb.append(bound.getTypeName()); } return sb.toString(); }