提交 d36abb1c 编写于 作者: D dcherepanov

7011446: ./windows/classes/sun/awt/windows/WToolkit.java needs to avoid spurious wakeup

Reviewed-by: anthony
上级 7a713d60
...@@ -228,12 +228,6 @@ public class WToolkit extends SunToolkit implements Runnable { ...@@ -228,12 +228,6 @@ public class WToolkit extends SunToolkit implements Runnable {
sun.java2d.Disposer.addRecord(anchor, new ToolkitDisposer()); sun.java2d.Disposer.addRecord(anchor, new ToolkitDisposer());
synchronized (this) {
// Fix for bug #4046430 -- Race condition
// where notifyAll can be called before
// the "AWT-Windows" thread's parent thread is
// waiting, resulting in a deadlock on startup.
/* /*
* Fix for 4701990. * Fix for 4701990.
* AWTAutoShutdown state must be changed before the toolkit thread * AWTAutoShutdown state must be changed before the toolkit thread
...@@ -248,11 +242,15 @@ public class WToolkit extends SunToolkit implements Runnable { ...@@ -248,11 +242,15 @@ public class WToolkit extends SunToolkit implements Runnable {
} }
try { try {
synchronized(this) {
while(!inited) {
wait(); wait();
} }
catch (InterruptedException x) {
} }
} catch (InterruptedException x) {
// swallow the exception
} }
SunToolkit.setDataTransfererClassName(DATA_TRANSFERER_CLASS_NAME); SunToolkit.setDataTransfererClassName(DATA_TRANSFERER_CLASS_NAME);
// Enabled "live resizing" by default. It remains controlled // Enabled "live resizing" by default. It remains controlled
...@@ -265,11 +263,7 @@ public class WToolkit extends SunToolkit implements Runnable { ...@@ -265,11 +263,7 @@ public class WToolkit extends SunToolkit implements Runnable {
setExtraMouseButtonsEnabledNative(areExtraMouseButtonsEnabled); setExtraMouseButtonsEnabledNative(areExtraMouseButtonsEnabled);
} }
public void run() { private final void registerShutdownHook() {
Thread.currentThread().setPriority(Thread.NORM_PRIORITY+1);
boolean startPump = init();
if (startPump) {
AccessController.doPrivileged(new PrivilegedAction() { AccessController.doPrivileged(new PrivilegedAction() {
public Object run() { public Object run() {
ThreadGroup currentTG = ThreadGroup currentTG =
...@@ -291,7 +285,16 @@ public class WToolkit extends SunToolkit implements Runnable { ...@@ -291,7 +285,16 @@ public class WToolkit extends SunToolkit implements Runnable {
}); });
} }
public void run() {
Thread.currentThread().setPriority(Thread.NORM_PRIORITY+1);
boolean startPump = init();
if (startPump) {
registerShutdownHook();
}
synchronized(this) { synchronized(this) {
inited = true;
notifyAll(); notifyAll();
} }
...@@ -309,6 +312,8 @@ public class WToolkit extends SunToolkit implements Runnable { ...@@ -309,6 +312,8 @@ public class WToolkit extends SunToolkit implements Runnable {
* eventLoop() should Dispose the toolkit and exit. * eventLoop() should Dispose the toolkit and exit.
*/ */
private native boolean init(); private native boolean init();
private boolean inited = false;
private native void eventLoop(); private native void eventLoop();
private native void shutdown(); private native void shutdown();
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册