From c1bec064139886559da1042f291e350213fd6049 Mon Sep 17 00:00:00 2001
From: scolebourne <unknown>
Date: Thu, 6 Mar 2014 17:31:07 +0000
Subject: [PATCH] 8036818: DateTimeFormatter withResolverFields() fails to
 accept null Reviewed-by: chegar, rriggs Contributed-by: scolebourne@joda.org

---
 .../java/time/format/DateTimeFormatter.java        | 12 +++++++-----
 .../tck/java/time/format/TCKDateTimeFormatter.java | 14 ++++++++++----
 2 files changed, 17 insertions(+), 9 deletions(-)

diff --git a/src/share/classes/java/time/format/DateTimeFormatter.java b/src/share/classes/java/time/format/DateTimeFormatter.java
index 39d91986f..9f5eba72f 100644
--- a/src/share/classes/java/time/format/DateTimeFormatter.java
+++ b/src/share/classes/java/time/format/DateTimeFormatter.java
@@ -1644,12 +1644,13 @@ public final class DateTimeFormatter {
      * @return a formatter based on this formatter with the requested resolver style, not null
      */
     public DateTimeFormatter withResolverFields(TemporalField... resolverFields) {
-        Objects.requireNonNull(resolverFields, "resolverFields");
-        Set<TemporalField> fields = new HashSet<>(Arrays.asList(resolverFields));
+        Set<TemporalField> fields = null;
+        if (resolverFields != null) {
+            fields = Collections.unmodifiableSet(new HashSet<>(Arrays.asList(resolverFields)));
+        }
         if (Objects.equals(this.resolverFields, fields)) {
             return this;
         }
-        fields = Collections.unmodifiableSet(fields);
         return new DateTimeFormatter(printerParser, locale, decimalStyle, resolverStyle, fields, chrono, zone);
     }
 
@@ -1693,11 +1694,12 @@ public final class DateTimeFormatter {
      * @return a formatter based on this formatter with the requested resolver style, not null
      */
     public DateTimeFormatter withResolverFields(Set<TemporalField> resolverFields) {
-        Objects.requireNonNull(resolverFields, "resolverFields");
         if (Objects.equals(this.resolverFields, resolverFields)) {
             return this;
         }
-        resolverFields = Collections.unmodifiableSet(new HashSet<>(resolverFields));
+        if (resolverFields != null) {
+            resolverFields = Collections.unmodifiableSet(new HashSet<>(resolverFields));
+        }
         return new DateTimeFormatter(printerParser, locale, decimalStyle, resolverStyle, resolverFields, chrono, zone);
     }
 
diff --git a/test/java/time/tck/java/time/format/TCKDateTimeFormatter.java b/test/java/time/tck/java/time/format/TCKDateTimeFormatter.java
index 8e2091e98..9c0a783ec 100644
--- a/test/java/time/tck/java/time/format/TCKDateTimeFormatter.java
+++ b/test/java/time/tck/java/time/format/TCKDateTimeFormatter.java
@@ -254,14 +254,20 @@ public class TCKDateTimeFormatter {
         assertEquals(parsed.isSupported(YEAR), false);  // not in the list of resolverFields
     }
 
-    @Test(expectedExceptions = NullPointerException.class)
+    @Test
     public void test_resolverFields_Array_null() throws Exception {
-        DateTimeFormatter.ISO_DATE.withResolverFields((TemporalField[]) null);
+        DateTimeFormatter f = DateTimeFormatter.ISO_DATE.withResolverFields(MONTH_OF_YEAR);
+        assertEquals(f.getResolverFields().size(), 1);
+        f = f.withResolverFields((TemporalField[]) null);
+        assertEquals(f.getResolverFields(), null);
     }
 
-    @Test(expectedExceptions = NullPointerException.class)
+    @Test
     public void test_resolverFields_Set_null() throws Exception {
-        DateTimeFormatter.ISO_DATE.withResolverFields((Set<TemporalField>) null);
+        DateTimeFormatter f = DateTimeFormatter.ISO_DATE.withResolverFields(MONTH_OF_YEAR);
+        assertEquals(f.getResolverFields().size(), 1);
+        f = f.withResolverFields((Set<TemporalField>) null);
+        assertEquals(f.getResolverFields(), null);
     }
 
     //-----------------------------------------------------------------------
-- 
GitLab