From c07ddd4b917c7bb98604ce8fc09e4820f2700557 Mon Sep 17 00:00:00 2001 From: alexp Date: Fri, 15 Apr 2011 21:26:09 +0400 Subject: [PATCH] 6985329: 9 classes in swing.plaf contains words inappropriate for public spec - about some compiler bug Reviewed-by: rupashka --- .../javax/swing/plaf/basic/BasicColorChooserUI.java | 3 +-- .../javax/swing/plaf/basic/BasicDesktopIconUI.java | 3 +-- .../classes/javax/swing/plaf/basic/BasicListUI.java | 3 +-- .../javax/swing/plaf/basic/BasicOptionPaneUI.java | 9 +++------ .../javax/swing/plaf/basic/BasicProgressBarUI.java | 3 +-- .../javax/swing/plaf/basic/BasicTableHeaderUI.java | 3 +-- .../classes/javax/swing/plaf/basic/BasicTableUI.java | 7 ++----- .../classes/javax/swing/plaf/metal/MetalComboBoxUI.java | 9 +++------ .../javax/swing/plaf/metal/MetalTabbedPaneUI.java | 3 +-- 9 files changed, 14 insertions(+), 29 deletions(-) diff --git a/src/share/classes/javax/swing/plaf/basic/BasicColorChooserUI.java b/src/share/classes/javax/swing/plaf/basic/BasicColorChooserUI.java index 15d78f962..8d01287e2 100644 --- a/src/share/classes/javax/swing/plaf/basic/BasicColorChooserUI.java +++ b/src/share/classes/javax/swing/plaf/basic/BasicColorChooserUI.java @@ -335,9 +335,8 @@ public class BasicColorChooserUI extends ColorChooserUI } /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of . + * Instantiate it only within subclasses of {@code BasicColorChooserUI}. */ public class PropertyHandler implements PropertyChangeListener { public void propertyChange(PropertyChangeEvent e) { diff --git a/src/share/classes/javax/swing/plaf/basic/BasicDesktopIconUI.java b/src/share/classes/javax/swing/plaf/basic/BasicDesktopIconUI.java index e99b7525c..e1435a561 100644 --- a/src/share/classes/javax/swing/plaf/basic/BasicDesktopIconUI.java +++ b/src/share/classes/javax/swing/plaf/basic/BasicDesktopIconUI.java @@ -186,9 +186,8 @@ public class BasicDesktopIconUI extends DesktopIconUI { /** * Listens for mouse movements and acts on them. * - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of . + * Instantiate it only within subclasses of {@code BasicDesktopIconUI}. */ public class MouseInputHandler extends MouseInputAdapter { diff --git a/src/share/classes/javax/swing/plaf/basic/BasicListUI.java b/src/share/classes/javax/swing/plaf/basic/BasicListUI.java index 054c1e3df..a4160f962 100644 --- a/src/share/classes/javax/swing/plaf/basic/BasicListUI.java +++ b/src/share/classes/javax/swing/plaf/basic/BasicListUI.java @@ -1555,9 +1555,8 @@ public class BasicListUI extends ListUI } /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of BasicTableUI. + * Instantiate it only within subclasses of {@code BasicListUI}. */ public class FocusHandler implements FocusListener { diff --git a/src/share/classes/javax/swing/plaf/basic/BasicOptionPaneUI.java b/src/share/classes/javax/swing/plaf/basic/BasicOptionPaneUI.java index e7f6a5a3a..6a0b024ce 100644 --- a/src/share/classes/javax/swing/plaf/basic/BasicOptionPaneUI.java +++ b/src/share/classes/javax/swing/plaf/basic/BasicOptionPaneUI.java @@ -911,9 +911,8 @@ public class BasicOptionPaneUI extends OptionPaneUI { * right. If syncAllWidths is true, the widths of each * component will be set to the largest preferred size width. * - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of BasicOptionPaneUI. + * Instantiate it only within subclasses of {@code BasicOptionPaneUI}. */ public static class ButtonAreaLayout implements LayoutManager { protected boolean syncAllWidths; @@ -1115,9 +1114,8 @@ public class BasicOptionPaneUI extends OptionPaneUI { /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of BasicOptionPaneUI. + * Instantiate it only within subclasses of {@code BasicOptionPaneUI}. */ public class PropertyChangeHandler implements PropertyChangeListener { /** @@ -1161,9 +1159,8 @@ public class BasicOptionPaneUI extends OptionPaneUI { } /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of BasicOptionPaneUI. + * Instantiate it only within subclasses of {@code BasicOptionPaneUI}. */ public class ButtonActionListener implements ActionListener { protected int buttonIndex; diff --git a/src/share/classes/javax/swing/plaf/basic/BasicProgressBarUI.java b/src/share/classes/javax/swing/plaf/basic/BasicProgressBarUI.java index 150f874e8..09a45f876 100644 --- a/src/share/classes/javax/swing/plaf/basic/BasicProgressBarUI.java +++ b/src/share/classes/javax/swing/plaf/basic/BasicProgressBarUI.java @@ -1211,9 +1211,8 @@ public class BasicProgressBarUI extends ProgressBarUI { /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of BasicProgressBarUI. + * Instantiate it only within subclasses of {@code BasicProgressBarUI}. */ public class ChangeHandler implements ChangeListener { // NOTE: This class exists only for backward compatability. All diff --git a/src/share/classes/javax/swing/plaf/basic/BasicTableHeaderUI.java b/src/share/classes/javax/swing/plaf/basic/BasicTableHeaderUI.java index 9d2b26d48..23fa230d4 100644 --- a/src/share/classes/javax/swing/plaf/basic/BasicTableHeaderUI.java +++ b/src/share/classes/javax/swing/plaf/basic/BasicTableHeaderUI.java @@ -88,9 +88,8 @@ public class BasicTableHeaderUI extends TableHeaderUI { }; /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of BasicTableUI. + * Instantiate it only within subclasses of {@code BasicTableHeaderUI}. */ public class MouseInputHandler implements MouseInputListener { diff --git a/src/share/classes/javax/swing/plaf/basic/BasicTableUI.java b/src/share/classes/javax/swing/plaf/basic/BasicTableUI.java index 29932c7aa..ad8a34d1e 100644 --- a/src/share/classes/javax/swing/plaf/basic/BasicTableUI.java +++ b/src/share/classes/javax/swing/plaf/basic/BasicTableUI.java @@ -730,9 +730,8 @@ public class BasicTableUI extends TableUI // /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of BasicTableUI. + * Instantiate it only within subclasses of {@code BasicTableUI}. *

As of Java 2 platform v1.3 this class is no longer used. * Instead JTable * overrides processKeyBinding to dispatch the event to @@ -761,9 +760,8 @@ public class BasicTableUI extends TableUI // /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of BasicTableUI. + * Instantiate it only within subclasses of {@code BasicTableUI}. */ public class FocusHandler implements FocusListener { // NOTE: This class exists only for backward compatability. All @@ -784,7 +782,6 @@ public class BasicTableUI extends TableUI // /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. * Instantiate it only within subclasses of BasicTableUI. */ diff --git a/src/share/classes/javax/swing/plaf/metal/MetalComboBoxUI.java b/src/share/classes/javax/swing/plaf/metal/MetalComboBoxUI.java index 3a7ef7f0d..e97416eca 100644 --- a/src/share/classes/javax/swing/plaf/metal/MetalComboBoxUI.java +++ b/src/share/classes/javax/swing/plaf/metal/MetalComboBoxUI.java @@ -199,9 +199,8 @@ public class MetalComboBoxUI extends BasicComboBoxUI { } /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of . + * Instantiate it only within subclasses of {@code MetalComboBoxUI}. */ public class MetalPropertyChangeListener extends BasicComboBoxUI.PropertyChangeHandler { public void propertyChange(PropertyChangeEvent e) { @@ -244,9 +243,8 @@ public class MetalComboBoxUI extends BasicComboBoxUI { } /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of . + * Instantiate it only within subclasses of {@code MetalComboBoxUI}. */ public class MetalComboBoxLayoutManager extends BasicComboBoxUI.ComboBoxLayoutManager { public void layoutContainer( Container parent ) { @@ -356,9 +354,8 @@ public class MetalComboBoxUI extends BasicComboBoxUI { } /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of . + * Instantiate it only within subclasses of {@code MetalComboBoxUI}. * * This class is now obsolete and doesn't do anything and * is only included for backwards API compatibility. Do not call or diff --git a/src/share/classes/javax/swing/plaf/metal/MetalTabbedPaneUI.java b/src/share/classes/javax/swing/plaf/metal/MetalTabbedPaneUI.java index 2cf52393b..1602ad6fe 100644 --- a/src/share/classes/javax/swing/plaf/metal/MetalTabbedPaneUI.java +++ b/src/share/classes/javax/swing/plaf/metal/MetalTabbedPaneUI.java @@ -1196,9 +1196,8 @@ public class MetalTabbedPaneUI extends BasicTabbedPaneUI { } /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of MetalTabbedPaneUI. + * Instantiate it only within subclasses of {@code MetalTabbedPaneUI}. */ public class TabbedPaneLayout extends BasicTabbedPaneUI.TabbedPaneLayout { -- GitLab