From a81bec349f0ba1da5a153a885193bcd9a97781c4 Mon Sep 17 00:00:00 2001 From: mchung Date: Tue, 17 Jan 2012 15:55:40 -0800 Subject: [PATCH] 7117570: Warnings in sun.mangement.* and its subpackages Reviewed-by: mchung, dsamersoff Contributed-by: kurchi.subhra.hazra@oracle.com --- src/share/classes/sun/management/Agent.java | 16 ++--- .../sun/management/ConnectorAddressLink.java | 16 ++--- src/share/classes/sun/management/Flag.java | 2 +- ...rbageCollectionNotifInfoCompositeData.java | 12 ++-- .../sun/management/GarbageCollectorImpl.java | 9 +-- .../classes/sun/management/GcInfoBuilder.java | 2 +- .../sun/management/GcInfoCompositeData.java | 29 ++------ .../sun/management/HotSpotDiagnostic.java | 2 +- .../sun/management/HotspotCompilation.java | 14 ++-- .../classes/sun/management/HotspotThread.java | 2 +- .../sun/management/LazyCompositeData.java | 15 ++--- .../management/ManagementFactoryHelper.java | 6 +- .../sun/management/MappedMXBeanType.java | 66 +++++++++---------- .../management/MonitorInfoCompositeData.java | 2 +- .../NotificationEmitterSupport.java | 12 ++-- .../classes/sun/management/RuntimeImpl.java | 2 +- .../management/ThreadInfoCompositeData.java | 2 +- .../counter/perf/PerfInstrumentation.java | 7 +- .../jmxremote/ConnectorBootstrap.java | 38 +++++------ .../sun/management/snmp/AdaptorBootstrap.java | 7 +- .../jvminstr/JVM_MANAGEMENT_MIB_IMPL.java | 10 +-- .../snmp/jvminstr/JvmMemGCTableMetaImpl.java | 2 + .../jvminstr/JvmMemManagerTableMetaImpl.java | 11 +++- .../JvmMemMgrPoolRelTableMetaImpl.java | 22 ++++--- .../jvminstr/JvmMemPoolTableMetaImpl.java | 11 +++- .../snmp/jvminstr/JvmMemoryImpl.java | 2 +- .../snmp/jvminstr/JvmMemoryMetaImpl.java | 2 + .../management/snmp/jvminstr/JvmOSImpl.java | 2 + .../jvminstr/JvmRTBootClassPathEntryImpl.java | 2 + .../JvmRTBootClassPathTableMetaImpl.java | 5 +- .../jvminstr/JvmRTClassPathEntryImpl.java | 1 + .../jvminstr/JvmRTClassPathTableMetaImpl.java | 5 +- .../jvminstr/JvmRTInputArgsEntryImpl.java | 1 + .../jvminstr/JvmRTInputArgsTableMetaImpl.java | 5 +- .../jvminstr/JvmRTLibraryPathEntryImpl.java | 1 + .../JvmRTLibraryPathTableMetaImpl.java | 4 +- .../snmp/jvminstr/JvmRuntimeMetaImpl.java | 1 + .../jvminstr/JvmThreadInstanceEntryImpl.java | 2 + .../JvmThreadInstanceTableMetaImpl.java | 9 ++- .../snmp/jvminstr/JvmThreadingMetaImpl.java | 2 + .../jvmmib/EnumJvmClassesVerboseLevel.java | 9 +-- .../EnumJvmJITCompilerTimeMonitoring.java | 9 +-- .../snmp/jvmmib/EnumJvmMemManagerState.java | 10 +-- .../EnumJvmMemPoolCollectThreshdSupport.java | 9 +-- .../snmp/jvmmib/EnumJvmMemPoolState.java | 9 +-- .../jvmmib/EnumJvmMemPoolThreshdSupport.java | 9 +-- .../snmp/jvmmib/EnumJvmMemPoolType.java | 9 +-- .../snmp/jvmmib/EnumJvmMemoryGCCall.java | 9 +-- .../jvmmib/EnumJvmMemoryGCVerboseLevel.java | 9 +-- .../jvmmib/EnumJvmRTBootClassPathSupport.java | 9 +-- .../EnumJvmThreadContentionMonitoring.java | 9 +-- .../EnumJvmThreadCpuTimeMonitoring.java | 9 +-- .../snmp/jvmmib/JVM_MANAGEMENT_MIB.java | 1 + .../jvmmib/JVM_MANAGEMENT_MIBOidTable.java | 1 + .../snmp/jvmmib/JvmClassLoadingMeta.java | 1 + .../snmp/jvmmib/JvmCompilationMeta.java | 1 + .../snmp/jvmmib/JvmMemGCEntryMeta.java | 1 + .../snmp/jvmmib/JvmMemGCTableMeta.java | 1 + .../snmp/jvmmib/JvmMemManagerEntryMeta.java | 1 + .../snmp/jvmmib/JvmMemManagerTableMeta.java | 1 + .../jvmmib/JvmMemMgrPoolRelEntryMeta.java | 1 + .../jvmmib/JvmMemMgrPoolRelTableMeta.java | 1 + .../snmp/jvmmib/JvmMemPoolEntryMeta.java | 1 + .../snmp/jvmmib/JvmMemPoolTableMeta.java | 2 + .../sun/management/snmp/jvmmib/JvmOSMeta.java | 2 + .../jvmmib/JvmRTBootClassPathEntryMeta.java | 1 + .../jvmmib/JvmRTBootClassPathTableMeta.java | 1 + .../snmp/jvmmib/JvmRTClassPathEntryMeta.java | 1 + .../snmp/jvmmib/JvmRTClassPathTableMeta.java | 1 + .../snmp/jvmmib/JvmRTInputArgsEntryMeta.java | 1 + .../snmp/jvmmib/JvmRTInputArgsTableMeta.java | 1 + .../jvmmib/JvmRTLibraryPathEntryMeta.java | 1 + .../jvmmib/JvmRTLibraryPathTableMeta.java | 1 + .../snmp/jvmmib/JvmRuntimeMeta.java | 1 + .../jvmmib/JvmThreadInstanceEntryMeta.java | 1 + .../jvmmib/JvmThreadInstanceTableMeta.java | 1 + .../snmp/jvmmib/JvmThreadingMeta.java | 1 + .../sun/management/snmp/util/MibLogger.java | 8 +-- .../snmp/util/SnmpListTableCache.java | 10 +-- .../snmp/util/SnmpNamedListTableCache.java | 26 ++++---- .../management/snmp/util/SnmpTableCache.java | 2 +- 81 files changed, 294 insertions(+), 249 deletions(-) diff --git a/src/share/classes/sun/management/Agent.java b/src/share/classes/sun/management/Agent.java index 0111f71a5..d5900930b 100644 --- a/src/share/classes/sun/management/Agent.java +++ b/src/share/classes/sun/management/Agent.java @@ -216,11 +216,8 @@ public class Agent { adaptorClass.getMethod("initialize", String.class, Properties.class); initializeMethod.invoke(null,snmpPort,props); - } catch (ClassNotFoundException x) { - // The SNMP packages are not present: throws an exception. - throw new UnsupportedOperationException("Unsupported management property: " + SNMP_PORT,x); - } catch (NoSuchMethodException x) { - // should not happen... + } catch (ClassNotFoundException | NoSuchMethodException | IllegalAccessException x) { + // snmp runtime doesn't exist - initialization fails throw new UnsupportedOperationException("Unsupported management property: " + SNMP_PORT,x); } catch (InvocationTargetException x) { final Throwable cause = x.getCause(); @@ -230,9 +227,6 @@ public class Agent { throw (Error) cause; // should not happen... throw new UnsupportedOperationException("Unsupported management property: " + SNMP_PORT,cause); - } catch (IllegalAccessException x) { - // should not happen... - throw new UnsupportedOperationException("Unsupported management property: " + SNMP_PORT,x); } } @@ -273,8 +267,8 @@ public class Agent { } catch (IOException e) { error(CONFIG_FILE_CLOSE_FAILED, fname); } - } - } + } + } } public static void startAgent() throws Exception { @@ -309,7 +303,7 @@ public class Agent { // invoke the premain(String args) method Class clz = ClassLoader.getSystemClassLoader().loadClass(cname); Method premain = clz.getMethod("premain", - new Class[] { String.class }); + new Class[] { String.class }); premain.invoke(null, /* static */ new Object[] { args }); } catch (ClassNotFoundException ex) { diff --git a/src/share/classes/sun/management/ConnectorAddressLink.java b/src/share/classes/sun/management/ConnectorAddressLink.java index 82241e76d..343ec45ab 100644 --- a/src/share/classes/sun/management/ConnectorAddressLink.java +++ b/src/share/classes/sun/management/ConnectorAddressLink.java @@ -117,11 +117,11 @@ public class ConnectorAddressLink { } catch (IllegalArgumentException iae) { throw new IOException(iae.getMessage()); } - List counters = + List counters = new PerfInstrumentation(bb).findByPattern(CONNECTOR_ADDRESS_COUNTER); - Iterator i = counters.iterator(); + Iterator i = counters.iterator(); if (i.hasNext()) { - Counter c = (Counter) i.next(); + Counter c = i.next(); return (String) c.getValue(); } else { return null; @@ -167,13 +167,13 @@ public class ConnectorAddressLink { } catch (IllegalArgumentException iae) { throw new IOException(iae.getMessage()); } - List counters = new PerfInstrumentation(bb).getAllCounters(); - Map properties = new HashMap(); - for (Object c : counters) { - String name = ((Counter) c).getName(); + List counters = new PerfInstrumentation(bb).getAllCounters(); + Map properties = new HashMap<>(); + for (Counter c : counters) { + String name = c.getName(); if (name.startsWith(REMOTE_CONNECTOR_COUNTER_PREFIX) && !name.equals(CONNECTOR_ADDRESS_COUNTER)) { - properties.put(name, ((Counter) c).getValue().toString()); + properties.put(name, c.getValue().toString()); } } return properties; diff --git a/src/share/classes/sun/management/Flag.java b/src/share/classes/sun/management/Flag.java index f9109b8ce..05f5c556e 100644 --- a/src/share/classes/sun/management/Flag.java +++ b/src/share/classes/sun/management/Flag.java @@ -91,7 +91,7 @@ class Flag { Flag[] flags = new Flag[numFlags]; int count = getFlags(names, flags, numFlags); - List result = new ArrayList(); + List result = new ArrayList<>(); for (Flag f : flags) { if (f != null) { result.add(f); diff --git a/src/share/classes/sun/management/GarbageCollectionNotifInfoCompositeData.java b/src/share/classes/sun/management/GarbageCollectionNotifInfoCompositeData.java index 3284b0928..f245c5a6d 100644 --- a/src/share/classes/sun/management/GarbageCollectionNotifInfoCompositeData.java +++ b/src/share/classes/sun/management/GarbageCollectionNotifInfoCompositeData.java @@ -69,11 +69,7 @@ public class GarbageCollectionNotifInfoCompositeData extends LazyCompositeData { Field f = cl.getDeclaredField("builder"); f.setAccessible(true); return (GcInfoBuilder)f.get(gcNotifInfo.getGcInfo()); - } catch(ClassNotFoundException e) { - return null; - } catch(NoSuchFieldException e) { - return null; - } catch(IllegalAccessException e) { + } catch(ClassNotFoundException | NoSuchFieldException | IllegalAccessException e) { return null; } } @@ -82,7 +78,7 @@ public class GarbageCollectionNotifInfoCompositeData extends LazyCompositeData { synchronized(compositeTypeByBuilder) { gict = compositeTypeByBuilder.get(builder); if(gict == null) { - OpenType[] gcNotifInfoItemTypes = new OpenType[] { + OpenType[] gcNotifInfoItemTypes = new OpenType[] { SimpleType.STRING, SimpleType.STRING, SimpleType.STRING, @@ -141,7 +137,7 @@ public class GarbageCollectionNotifInfoCompositeData extends LazyCompositeData { GC_INFO }; private static HashMap compositeTypeByBuilder = - new HashMap(); + new HashMap<>(); public static String getGcName(CompositeData cd) { String gcname = getString(cd, GC_NAME); @@ -195,7 +191,7 @@ public class GarbageCollectionNotifInfoCompositeData extends LazyCompositeData { private static synchronized CompositeType getBaseGcNotifInfoCompositeType() { if (baseGcNotifInfoCompositeType == null) { try { - OpenType[] baseGcNotifInfoItemTypes = new OpenType[] { + OpenType[] baseGcNotifInfoItemTypes = new OpenType[] { SimpleType.STRING, SimpleType.STRING, SimpleType.STRING, diff --git a/src/share/classes/sun/management/GarbageCollectorImpl.java b/src/share/classes/sun/management/GarbageCollectorImpl.java index 09c1ffbec..fa0d61704 100644 --- a/src/share/classes/sun/management/GarbageCollectorImpl.java +++ b/src/share/classes/sun/management/GarbageCollectorImpl.java @@ -70,14 +70,11 @@ class GarbageCollectorImpl extends MemoryManagerImpl private String[] poolNames = null; synchronized String[] getAllPoolNames() { if (poolNames == null) { - List pools = ManagementFactory.getMemoryPoolMXBeans(); + List pools = ManagementFactory.getMemoryPoolMXBeans(); poolNames = new String[pools.size()]; int i = 0; - for (ListIterator iter = pools.listIterator(); - iter.hasNext(); - i++) { - MemoryPoolMXBean p = (MemoryPoolMXBean) iter.next(); - poolNames[i] = p.getName(); + for (MemoryPoolMXBean m : pools) { + poolNames[i++] = m.getName(); } } return poolNames; diff --git a/src/share/classes/sun/management/GcInfoBuilder.java b/src/share/classes/sun/management/GcInfoBuilder.java index 04ac6df3a..1c3f53df0 100644 --- a/src/share/classes/sun/management/GcInfoBuilder.java +++ b/src/share/classes/sun/management/GcInfoBuilder.java @@ -104,7 +104,7 @@ public class GcInfoBuilder { int itemCount = numGcInfoItems + gcExtItemCount; allItemNames = new String[itemCount]; String[] allItemDescs = new String[itemCount]; - OpenType[] allItemTypes = new OpenType[itemCount]; + OpenType[] allItemTypes = new OpenType[itemCount]; System.arraycopy(gcInfoItemNames, 0, allItemNames, 0, numGcInfoItems); System.arraycopy(gcInfoItemNames, 0, allItemDescs, 0, numGcInfoItems); diff --git a/src/share/classes/sun/management/GcInfoCompositeData.java b/src/share/classes/sun/management/GcInfoCompositeData.java index fb423e160..b3050a1c7 100644 --- a/src/share/classes/sun/management/GcInfoCompositeData.java +++ b/src/share/classes/sun/management/GcInfoCompositeData.java @@ -76,11 +76,7 @@ public class GcInfoCompositeData extends LazyCompositeData { Field f = cl.getDeclaredField("builder"); f.setAccessible(true); return (GcInfoBuilder)f.get(info); - } catch(ClassNotFoundException e) { - return null; - } catch(NoSuchFieldException e) { - return null; - } catch(IllegalAccessException e) { + } catch(ClassNotFoundException | NoSuchFieldException | IllegalAccessException e) { return null; } } @@ -92,11 +88,7 @@ public class GcInfoCompositeData extends LazyCompositeData { Field f = cl.getDeclaredField("extAttributes"); f.setAccessible(true); return (Object[])f.get(info); - } catch(ClassNotFoundException e) { - return null; - } catch(NoSuchFieldException e) { - return null; - } catch(IllegalAccessException e) { + } catch(ClassNotFoundException | NoSuchFieldException | IllegalAccessException e) { return null; } } @@ -180,10 +172,7 @@ public class GcInfoCompositeData extends LazyCompositeData { Method m = GcInfo.class.getMethod("getMemoryUsageBeforeGc"); memoryUsageMapType = MappedMXBeanType.getMappedType(m.getGenericReturnType()); - } catch (NoSuchMethodException e) { - // Should never reach here - throw new AssertionError(e); - } catch (OpenDataException e) { + } catch (NoSuchMethodException | OpenDataException e) { // Should never reach here throw new AssertionError(e); } @@ -197,7 +186,7 @@ public class GcInfoCompositeData extends LazyCompositeData { static synchronized OpenType[] getBaseGcInfoItemTypes() { if (baseGcInfoItemTypes == null) { OpenType memoryUsageOpenType = memoryUsageMapType.getOpenType(); - baseGcInfoItemTypes = new OpenType[] { + baseGcInfoItemTypes = new OpenType[] { SimpleType.LONG, SimpleType.LONG, SimpleType.LONG, @@ -225,10 +214,7 @@ public class GcInfoCompositeData extends LazyCompositeData { try { TabularData td = (TabularData) cd.get(MEMORY_USAGE_BEFORE_GC); return cast(memoryUsageMapType.toJavaTypeData(td)); - } catch (InvalidObjectException e) { - // Should never reach here - throw new AssertionError(e); - } catch (OpenDataException e) { + } catch (InvalidObjectException | OpenDataException e) { // Should never reach here throw new AssertionError(e); } @@ -244,10 +230,7 @@ public class GcInfoCompositeData extends LazyCompositeData { TabularData td = (TabularData) cd.get(MEMORY_USAGE_AFTER_GC); //return (Map) return cast(memoryUsageMapType.toJavaTypeData(td)); - } catch (InvalidObjectException e) { - // Should never reach here - throw new AssertionError(e); - } catch (OpenDataException e) { + } catch (InvalidObjectException | OpenDataException e) { // Should never reach here throw new AssertionError(e); } diff --git a/src/share/classes/sun/management/HotSpotDiagnostic.java b/src/share/classes/sun/management/HotSpotDiagnostic.java index dc7a0015b..f48d0988c 100644 --- a/src/share/classes/sun/management/HotSpotDiagnostic.java +++ b/src/share/classes/sun/management/HotSpotDiagnostic.java @@ -48,7 +48,7 @@ public class HotSpotDiagnostic implements HotSpotDiagnosticMXBean { public List getDiagnosticOptions() { List allFlags = Flag.getAllFlags(); - List result = new ArrayList(); + List result = new ArrayList<>(); for (Flag flag : allFlags) { if (flag.isWriteable() && flag.isExternal()) { result.add(flag.getVMOption()); diff --git a/src/share/classes/sun/management/HotspotCompilation.java b/src/share/classes/sun/management/HotspotCompilation.java index 7e9ee0cf2..0c97c897b 100644 --- a/src/share/classes/sun/management/HotspotCompilation.java +++ b/src/share/classes/sun/management/HotspotCompilation.java @@ -120,13 +120,13 @@ class HotspotCompilation // current implementation. We first look up in the SUN_CI namespace // since most counters are in SUN_CI namespace. - if ((c = (Counter) counters.get(SUN_CI + name)) != null) { + if ((c = counters.get(SUN_CI + name)) != null) { return c; } - if ((c = (Counter) counters.get(COM_SUN_CI + name)) != null) { + if ((c = counters.get(COM_SUN_CI + name)) != null) { return c; } - if ((c = (Counter) counters.get(JAVA_CI + name)) != null) { + if ((c = counters.get(JAVA_CI + name)) != null) { return c; } @@ -136,10 +136,8 @@ class HotspotCompilation private void initCompilerCounters() { // Build a tree map of the current list of performance counters - ListIterator iter = getInternalCompilerCounters().listIterator(); - counters = new TreeMap(); - while (iter.hasNext()) { - Counter c = (Counter) iter.next(); + counters = new TreeMap<>(); + for (Counter c: getInternalCompilerCounters()) { counters.put(c.getName(), c); } @@ -200,7 +198,7 @@ class HotspotCompilation } public java.util.List getCompilerThreadStats() { - List list = new ArrayList(threads.length); + List list = new ArrayList<>(threads.length); int i = 0; if (threads[0] == null) { // no adaptor thread diff --git a/src/share/classes/sun/management/HotspotThread.java b/src/share/classes/sun/management/HotspotThread.java index 62329d2e9..b9003c209 100644 --- a/src/share/classes/sun/management/HotspotThread.java +++ b/src/share/classes/sun/management/HotspotThread.java @@ -58,7 +58,7 @@ class HotspotThread String[] names = new String[count]; long[] times = new long[count]; int numThreads = getInternalThreadTimes0(names, times); - Map result = new HashMap(numThreads); + Map result = new HashMap<>(numThreads); for (int i = 0; i < numThreads; i++) { result.put(names[i], new Long(times[i])); } diff --git a/src/share/classes/sun/management/LazyCompositeData.java b/src/share/classes/sun/management/LazyCompositeData.java index 6bae9b94d..c11c9faef 100644 --- a/src/share/classes/sun/management/LazyCompositeData.java +++ b/src/share/classes/sun/management/LazyCompositeData.java @@ -81,7 +81,7 @@ public abstract class LazyCompositeData return compositeData().toString(); } - public Collection values() { + public Collection values() { return compositeData().values(); } @@ -153,16 +153,15 @@ public abstract class LazyCompositeData // We can't use CompositeType.isValue() since it returns false // if the type name doesn't match. - Set allItems = type1.keySet(); + Set allItems = type1.keySet(); // Check all items in the type1 exist in type2 if (!type2.keySet().containsAll(allItems)) return false; - for (Iterator iter = allItems.iterator(); iter.hasNext(); ) { - String item = (String) iter.next(); - OpenType ot1 = type1.getType(item); - OpenType ot2 = type2.getType(item); + for (String item: allItems) { + OpenType ot1 = type1.getType(item); + OpenType ot2 = type2.getType(item); if (ot1 instanceof CompositeType) { if (! (ot2 instanceof CompositeType)) return false; @@ -183,8 +182,8 @@ public abstract class LazyCompositeData protected static boolean isTypeMatched(TabularType type1, TabularType type2) { if (type1 == type2) return true; - List list1 = type1.getIndexNames(); - List list2 = type2.getIndexNames(); + List list1 = type1.getIndexNames(); + List list2 = type2.getIndexNames(); // check if the list of index names are the same if (!list1.equals(list2)) diff --git a/src/share/classes/sun/management/ManagementFactoryHelper.java b/src/share/classes/sun/management/ManagementFactoryHelper.java index d29010683..025b7a26d 100644 --- a/src/share/classes/sun/management/ManagementFactoryHelper.java +++ b/src/share/classes/sun/management/ManagementFactoryHelper.java @@ -110,7 +110,7 @@ public class ManagementFactoryHelper { public static List getMemoryPoolMXBeans() { MemoryPoolMXBean[] pools = MemoryImpl.getMemoryPools(); - List list = new ArrayList(pools.length); + List list = new ArrayList<>(pools.length); for (MemoryPoolMXBean p : pools) { list.add(p); } @@ -119,7 +119,7 @@ public class ManagementFactoryHelper { public static List getMemoryManagerMXBeans() { MemoryManagerMXBean[] mgrs = MemoryImpl.getMemoryManagers(); - List result = new ArrayList(mgrs.length); + List result = new ArrayList<>(mgrs.length); for (MemoryManagerMXBean m : mgrs) { result.add(m); } @@ -128,7 +128,7 @@ public class ManagementFactoryHelper { public static List getGarbageCollectorMXBeans() { MemoryManagerMXBean[] mgrs = MemoryImpl.getMemoryManagers(); - List result = new ArrayList(mgrs.length); + List result = new ArrayList<>(mgrs.length); for (MemoryManagerMXBean m : mgrs) { if (GarbageCollectorMXBean.class.isInstance(m)) { result.add(GarbageCollectorMXBean.class.cast(m)); diff --git a/src/share/classes/sun/management/MappedMXBeanType.java b/src/share/classes/sun/management/MappedMXBeanType.java index 0efe33560..db90899b0 100644 --- a/src/share/classes/sun/management/MappedMXBeanType.java +++ b/src/share/classes/sun/management/MappedMXBeanType.java @@ -62,18 +62,18 @@ import com.sun.management.VMOption; @SuppressWarnings("unchecked") public abstract class MappedMXBeanType { private static final WeakHashMap convertedTypes = - new WeakHashMap(); + new WeakHashMap<>(); boolean isBasicType = false; - OpenType openType = inProgress; - Class mappedTypeClass; + OpenType openType = inProgress; + Class mappedTypeClass; static synchronized MappedMXBeanType newMappedType(Type javaType) throws OpenDataException { MappedMXBeanType mt = null; if (javaType instanceof Class) { - final Class c = (Class) javaType; + final Class c = (Class) javaType; if (c.isEnum()) { mt = new EnumMXBeanType(c); } else if (c.isArray()) { @@ -85,7 +85,7 @@ public abstract class MappedMXBeanType { final ParameterizedType pt = (ParameterizedType) javaType; final Type rawType = pt.getRawType(); if (rawType instanceof Class) { - final Class rc = (Class) rawType; + final Class rc = (Class) rawType; if (rc == List.class) { mt = new ListMXBeanType(pt); } else if (rc == Map.class) { @@ -106,7 +106,7 @@ public abstract class MappedMXBeanType { } // basic types do not require data mapping - static synchronized MappedMXBeanType newBasicType(Class c, OpenType ot) + static synchronized MappedMXBeanType newBasicType(Class c, OpenType ot) throws OpenDataException { MappedMXBeanType mt = new BasicMXBeanType(c, ot); convertedTypes.put(c, mt); @@ -127,7 +127,7 @@ public abstract class MappedMXBeanType { } // Convert a class to an OpenType - public static synchronized OpenType toOpenType(Type t) + public static synchronized OpenType toOpenType(Type t) throws OpenDataException { MappedMXBeanType mt = getMappedType(t); return mt.getOpenType(); @@ -152,7 +152,7 @@ public abstract class MappedMXBeanType { } // Return the mapped open type - OpenType getOpenType() { + OpenType getOpenType() { return openType; } @@ -168,7 +168,7 @@ public abstract class MappedMXBeanType { } // Return the mapped open type - Class getMappedTypeClass() { + Class getMappedTypeClass() { return mappedTypeClass; } @@ -192,8 +192,8 @@ public abstract class MappedMXBeanType { // T <-> T (no conversion) // static class BasicMXBeanType extends MappedMXBeanType { - final Class basicType; - BasicMXBeanType(Class c, OpenType openType) { + final Class basicType; + BasicMXBeanType(Class c, OpenType openType) { this.basicType = c; this.openType = openType; this.mappedTypeClass = c; @@ -228,7 +228,7 @@ public abstract class MappedMXBeanType { // static class EnumMXBeanType extends MappedMXBeanType { final Class enumClass; - EnumMXBeanType(Class c) { + EnumMXBeanType(Class c) { this.enumClass = c; this.openType = STRING; this.mappedTypeClass = String.class; @@ -269,16 +269,16 @@ public abstract class MappedMXBeanType { // E[] <-> openTypeData(E)[] // static class ArrayMXBeanType extends MappedMXBeanType { - final Class arrayClass; + final Class arrayClass; protected MappedMXBeanType componentType; protected MappedMXBeanType baseElementType; - ArrayMXBeanType(Class c) throws OpenDataException { + ArrayMXBeanType(Class c) throws OpenDataException { this.arrayClass = c; this.componentType = getMappedType(c.getComponentType()); StringBuilder className = new StringBuilder(); - Class et = c; + Class et = c; int dim; for (dim = 0; et.isArray(); dim++) { className.append('['); @@ -299,7 +299,7 @@ public abstract class MappedMXBeanType { throw ode; } - openType = new ArrayType(dim, baseElementType.getOpenType()); + openType = new ArrayType<>(dim, baseElementType.getOpenType()); } protected ArrayMXBeanType() { @@ -395,7 +395,7 @@ public abstract class MappedMXBeanType { throw ode; } - openType = new ArrayType(dim, baseElementType.getOpenType()); + openType = new ArrayType<>(dim, baseElementType.getOpenType()); } Type getJavaType() { @@ -428,7 +428,7 @@ public abstract class MappedMXBeanType { throw new OpenDataException("Element Type for " + pt + " not supported"); } - final Class et = (Class) argTypes[0]; + final Class et = (Class) argTypes[0]; if (et.isArray()) { throw new OpenDataException("Element Type for " + pt + " not supported"); @@ -445,7 +445,7 @@ public abstract class MappedMXBeanType { ode.initCause(e); throw ode; } - openType = new ArrayType(1, paramType.getOpenType()); + openType = new ArrayType<>(1, paramType.getOpenType()); } Type getJavaType() { @@ -473,7 +473,7 @@ public abstract class MappedMXBeanType { throws OpenDataException, InvalidObjectException { final Object[] openArray = (Object[]) data; - List result = new ArrayList(openArray.length); + List result = new ArrayList<>(openArray.length); for (Object o : openArray) { result.add(paramType.toJavaTypeData(o)); } @@ -514,7 +514,7 @@ public abstract class MappedMXBeanType { // FIXME: generate typeName for generic typeName = "Map<" + keyType.getName() + "," + valueType.getName() + ">"; - final OpenType[] mapItemTypes = new OpenType[] { + final OpenType[] mapItemTypes = new OpenType[] { keyType.getOpenType(), valueType.getOpenType(), }; @@ -543,7 +543,7 @@ public abstract class MappedMXBeanType { final TabularData table = new TabularDataSupport(tabularType); final CompositeType rowType = tabularType.getRowType(); - for (Map.Entry entry : map.entrySet()) { + for (Map.Entry entry : map.entrySet()) { final Object key = keyType.toOpenTypeData(entry.getKey()); final Object value = valueType.toOpenTypeData(entry.getValue()); final CompositeData row = @@ -560,7 +560,7 @@ public abstract class MappedMXBeanType { final TabularData td = (TabularData) data; - Map result = new HashMap(); + Map result = new HashMap<>(); for (CompositeData row : (Collection) td.values()) { Object key = keyType.toJavaTypeData(row.get(KEY)); Object value = valueType.toJavaTypeData(row.get(VALUE)); @@ -607,7 +607,7 @@ public abstract class MappedMXBeanType { final boolean isCompositeData; Method fromMethod = null; - CompositeDataMXBeanType(Class c) throws OpenDataException { + CompositeDataMXBeanType(Class c) throws OpenDataException { this.javaClass = c; this.mappedTypeClass = COMPOSITE_DATA_CLASS; @@ -639,8 +639,8 @@ public abstract class MappedMXBeanType { return javaClass.getMethods(); } }); - final List names = new ArrayList(); - final List types = new ArrayList(); + final List names = new ArrayList<>(); + final List> types = new ArrayList<>(); /* Select public methods that look like "T getX()" or "boolean isX()", where T is not void and X is not the empty @@ -678,7 +678,7 @@ public abstract class MappedMXBeanType { c.getName(), nameArray, // field names nameArray, // field descriptions - types.toArray(new OpenType[0])); + types.toArray(new OpenType[0])); } } @@ -722,7 +722,7 @@ public abstract class MappedMXBeanType { // so that no other classes are sent over the wire CompositeData cd = (CompositeData) data; CompositeType ct = cd.getCompositeType(); - String[] itemNames = (String[]) ct.keySet().toArray(new String[0]); + String[] itemNames = ct.keySet().toArray(new String[0]); Object[] itemValues = cd.getAll(itemNames); return new CompositeDataSupport(ct, itemNames, itemValues); } @@ -779,9 +779,9 @@ public abstract class MappedMXBeanType { } private static final long serialVersionUID = -3413063475064374490L; } - private static final OpenType inProgress; + private static final OpenType inProgress; static { - OpenType t; + OpenType t; try { t = new InProgress(); } catch (OpenDataException e) { @@ -799,8 +799,8 @@ public abstract class MappedMXBeanType { static { try { for (int i = 0; i < simpleTypes.length; i++) { - final OpenType t = simpleTypes[i]; - Class c; + final OpenType t = simpleTypes[i]; + Class c; try { c = Class.forName(t.getClassName(), false, String.class.getClassLoader()); @@ -816,7 +816,7 @@ public abstract class MappedMXBeanType { if (c.getName().startsWith("java.lang.")) { try { final Field typeField = c.getField("TYPE"); - final Class primitiveType = (Class) typeField.get(null); + final Class primitiveType = (Class) typeField.get(null); MappedMXBeanType.newBasicType(primitiveType, t); } catch (NoSuchFieldException e) { // OK: must not be a primitive wrapper diff --git a/src/share/classes/sun/management/MonitorInfoCompositeData.java b/src/share/classes/sun/management/MonitorInfoCompositeData.java index 58bea9d55..92b1cccc0 100644 --- a/src/share/classes/sun/management/MonitorInfoCompositeData.java +++ b/src/share/classes/sun/management/MonitorInfoCompositeData.java @@ -92,7 +92,7 @@ public class MonitorInfoCompositeData extends LazyCompositeData { monitorInfoCompositeType = (CompositeType) MappedMXBeanType.toOpenType(MonitorInfo.class); Set s = monitorInfoCompositeType.keySet(); - monitorInfoItemNames = (String[]) s.toArray(new String[0]); + monitorInfoItemNames = s.toArray(new String[0]); } catch (OpenDataException e) { // Should never reach here throw new AssertionError(e); diff --git a/src/share/classes/sun/management/NotificationEmitterSupport.java b/src/share/classes/sun/management/NotificationEmitterSupport.java index 436211d4a..580643b03 100644 --- a/src/share/classes/sun/management/NotificationEmitterSupport.java +++ b/src/share/classes/sun/management/NotificationEmitterSupport.java @@ -71,7 +71,7 @@ abstract class NotificationEmitterSupport implements NotificationEmitter { efficient solution would be to clone the listener list every time a notification is sent. */ synchronized (listenerLock) { - List newList = new ArrayList(listenerList.size() + 1); + List newList = new ArrayList<>(listenerList.size() + 1); newList.addAll(listenerList); newList.add(new ListenerInfo(listener, filter, handback)); listenerList = newList; @@ -82,12 +82,12 @@ abstract class NotificationEmitterSupport implements NotificationEmitter { throws ListenerNotFoundException { synchronized (listenerLock) { - List newList = new ArrayList(listenerList); + List newList = new ArrayList<>(listenerList); /* We scan the list of listeners in reverse order because in forward order we would have to repeat the loop with the same index after a remove. */ for (int i=newList.size()-1; i>=0; i--) { - ListenerInfo li = (ListenerInfo)newList.get(i); + ListenerInfo li = newList.get(i); if (li.listener == listener) newList.remove(i); @@ -106,10 +106,10 @@ abstract class NotificationEmitterSupport implements NotificationEmitter { boolean found = false; synchronized (listenerLock) { - List newList = new ArrayList(listenerList); + List newList = new ArrayList<>(listenerList); final int size = newList.size(); for (int i = 0; i < size; i++) { - ListenerInfo li = (ListenerInfo) newList.get(i); + ListenerInfo li = newList.get(i); if (li.listener == listener) { found = true; @@ -148,7 +148,7 @@ abstract class NotificationEmitterSupport implements NotificationEmitter { final int size = currentList.size(); for (int i = 0; i < size; i++) { - ListenerInfo li = (ListenerInfo) currentList.get(i); + ListenerInfo li = currentList.get(i); if (li.filter == null || li.filter.isNotificationEnabled(notification)) { diff --git a/src/share/classes/sun/management/RuntimeImpl.java b/src/share/classes/sun/management/RuntimeImpl.java index 53f33ee73..9f52969e7 100644 --- a/src/share/classes/sun/management/RuntimeImpl.java +++ b/src/share/classes/sun/management/RuntimeImpl.java @@ -128,7 +128,7 @@ class RuntimeImpl implements RuntimeMXBean { public Map getSystemProperties() { Properties sysProps = System.getProperties(); - Map map = new HashMap(); + Map map = new HashMap<>(); // Properties.entrySet() does not include the entries in // the default properties. So use Properties.stringPropertyNames() diff --git a/src/share/classes/sun/management/ThreadInfoCompositeData.java b/src/share/classes/sun/management/ThreadInfoCompositeData.java index 4c483d305..7a911e4fd 100644 --- a/src/share/classes/sun/management/ThreadInfoCompositeData.java +++ b/src/share/classes/sun/management/ThreadInfoCompositeData.java @@ -190,7 +190,7 @@ public class ThreadInfoCompositeData extends LazyCompositeData { threadInfoV6Attributes.length; String[] v5ItemNames = new String[numV5Attributes]; String[] v5ItemDescs = new String[numV5Attributes]; - OpenType[] v5ItemTypes = new OpenType[numV5Attributes]; + OpenType[] v5ItemTypes = new OpenType[numV5Attributes]; int i = 0; for (String n : itemNames) { if (isV5Attribute(n)) { diff --git a/src/share/classes/sun/management/counter/perf/PerfInstrumentation.java b/src/share/classes/sun/management/counter/perf/PerfInstrumentation.java index eb7ae7ac3..2d0cb5bee 100644 --- a/src/share/classes/sun/management/counter/perf/PerfInstrumentation.java +++ b/src/share/classes/sun/management/counter/perf/PerfInstrumentation.java @@ -73,7 +73,7 @@ public class PerfInstrumentation { buffer.position(prologue.getEntryOffset()); nextEntry = buffer.position(); // rebuild all the counters - map = new TreeMap(); + map = new TreeMap<>(); } boolean hasNext() { @@ -154,7 +154,7 @@ public class PerfInstrumentation { map.put(c.getName(), c); } } - return new ArrayList(map.values()); + return new ArrayList<>(map.values()); } public synchronized List findByPattern(String patternString) { @@ -167,7 +167,8 @@ public class PerfInstrumentation { Pattern pattern = Pattern.compile(patternString); Matcher matcher = pattern.matcher(""); - List matches = new ArrayList(); + List matches = new ArrayList<>(); + for (Map.Entry me: map.entrySet()) { String name = me.getKey(); diff --git a/src/share/classes/sun/management/jmxremote/ConnectorBootstrap.java b/src/share/classes/sun/management/jmxremote/ConnectorBootstrap.java index a3b318a8c..710180516 100644 --- a/src/share/classes/sun/management/jmxremote/ConnectorBootstrap.java +++ b/src/share/classes/sun/management/jmxremote/ConnectorBootstrap.java @@ -234,14 +234,15 @@ public final class ConnectorBootstrap { "authenticated Subject is null"); } final Set principals = subject.getPrincipals(); - for (Principal p: principals) { - if (properties.containsKey(p.getName())) { + for (Principal p1: principals) { + if (properties.containsKey(p1.getName())) { return; } } - final Set principalsStr = new HashSet(); - for (Principal p: principals) { - principalsStr.add(p.getName()); + + final Set principalsStr = new HashSet<>(); + for (Principal p2: principals) { + principalsStr.add(p2.getName()); } throw new SecurityException( "Access denied! No entries found in the access file [" + @@ -255,9 +256,9 @@ public final class ConnectorBootstrap { if (fname == null) { return p; } - FileInputStream fin = new FileInputStream(fname); - p.load(fin); - fin.close(); + try (FileInputStream fin = new FileInputStream(fname)) { + p.load(fin); + } return p; } private final Map environment; @@ -430,7 +431,7 @@ public final class ConnectorBootstrap { try { // Export remote connector address and associated configuration // properties to the instrumentation buffer. - Map properties = new HashMap(); + Map properties = new HashMap<>(); properties.put("remoteAddress", url.toString()); properties.put("authenticate", useAuthenticationStr); properties.put("ssl", useSslStr); @@ -456,7 +457,7 @@ public final class ConnectorBootstrap { System.setProperty("java.rmi.server.randomIDs", "true"); // This RMI server should not keep the VM alive - Map env = new HashMap(); + Map env = new HashMap<>(); env.put(RMIExporter.EXPORTER_ATTRIBUTE, new PermanentExporter()); // The local connector server need only be available via the @@ -599,12 +600,9 @@ public final class ConnectorBootstrap { try { // Load the SSL keystore properties from the config file Properties p = new Properties(); - InputStream in = new FileInputStream(sslConfigFileName); - try { + try (InputStream in = new FileInputStream(sslConfigFileName)) { BufferedInputStream bin = new BufferedInputStream(in); p.load(bin); - } finally { - in.close(); } String keyStore = p.getProperty("javax.net.ssl.keyStore"); @@ -628,11 +626,8 @@ public final class ConnectorBootstrap { KeyStore ks = null; if (keyStore != null) { ks = KeyStore.getInstance(KeyStore.getDefaultType()); - FileInputStream ksfis = new FileInputStream(keyStore); - try { + try (FileInputStream ksfis = new FileInputStream(keyStore)) { ks.load(ksfis, keyStorePasswd); - } finally { - ksfis.close(); } } KeyManagerFactory kmf = KeyManagerFactory.getInstance( @@ -642,11 +637,8 @@ public final class ConnectorBootstrap { KeyStore ts = null; if (trustStore != null) { ts = KeyStore.getInstance(KeyStore.getDefaultType()); - FileInputStream tsfis = new FileInputStream(trustStore); - try { + try (FileInputStream tsfis = new FileInputStream(trustStore)) { ts.load(tsfis, trustStorePasswd); - } finally { - tsfis.close(); } } TrustManagerFactory tmf = TrustManagerFactory.getInstance( @@ -689,7 +681,7 @@ public final class ConnectorBootstrap { JMXServiceURL url = new JMXServiceURL("rmi", null, 0); - Map env = new HashMap(); + Map env = new HashMap<>(); PermanentExporter exporter = new PermanentExporter(); diff --git a/src/share/classes/sun/management/snmp/AdaptorBootstrap.java b/src/share/classes/sun/management/snmp/AdaptorBootstrap.java index 27d28fc5f..fdc66ce8d 100644 --- a/src/share/classes/sun/management/snmp/AdaptorBootstrap.java +++ b/src/share/classes/sun/management/snmp/AdaptorBootstrap.java @@ -118,21 +118,22 @@ public final class AdaptorBootstrap { /** * Retrieve the Trap Target List from the ACL file. **/ + @SuppressWarnings("unchecked") private static List getTargetList(InetAddressAcl acl, int defaultTrapPort) { final ArrayList result = - new ArrayList(); + new ArrayList<>(); if (acl != null) { if (log.isDebugOn()) log.debug("getTargetList",Agent.getText("jmxremote.AdaptorBootstrap.getTargetList.processing")); - final Enumeration td=acl.getTrapDestinations(); + final Enumeration td = acl.getTrapDestinations(); for (; td.hasMoreElements() ;) { final InetAddress targetAddr = (InetAddress)td.nextElement(); final Enumeration tc = acl.getTrapCommunities(targetAddr); for (;tc.hasMoreElements() ;) { - final String community = (String) tc.nextElement(); + final String community = (String)tc.nextElement(); final NotificationTarget target = new NotificationTargetImpl(targetAddr, defaultTrapPort, diff --git a/src/share/classes/sun/management/snmp/jvminstr/JVM_MANAGEMENT_MIB_IMPL.java b/src/share/classes/sun/management/snmp/jvminstr/JVM_MANAGEMENT_MIB_IMPL.java index 65b7b1b88..a692889b5 100644 --- a/src/share/classes/sun/management/snmp/jvminstr/JVM_MANAGEMENT_MIB_IMPL.java +++ b/src/share/classes/sun/management/snmp/jvminstr/JVM_MANAGEMENT_MIB_IMPL.java @@ -90,14 +90,14 @@ public class JVM_MANAGEMENT_MIB_IMPL extends JVM_MANAGEMENT_MIB { SnmpOidTable table = null; if(tableRef == null) { table = new JVM_MANAGEMENT_MIBOidTable(); - tableRef = new WeakReference(table); + tableRef = new WeakReference<>(table); return table; } table = tableRef.get(); if(table == null) { table = new JVM_MANAGEMENT_MIBOidTable(); - tableRef = new WeakReference(table); + tableRef = new WeakReference<>(table); } return table; @@ -198,7 +198,7 @@ public class JVM_MANAGEMENT_MIB_IMPL extends JVM_MANAGEMENT_MIB { * List of notification targets. */ private ArrayList notificationTargets = - new ArrayList(); + new ArrayList<>(); private final NotificationEmitter emitter; private final NotificationHandler handler; @@ -215,7 +215,7 @@ public class JVM_MANAGEMENT_MIB_IMPL extends JVM_MANAGEMENT_MIB { } private synchronized void sendTrap(SnmpOid trap, SnmpVarBindList list) { - final Iterator iterator = notificationTargets.iterator(); + final Iterator iterator = notificationTargets.iterator(); final SnmpAdaptorServer adaptor = (SnmpAdaptorServer) getSnmpAdaptor(); @@ -232,7 +232,7 @@ public class JVM_MANAGEMENT_MIB_IMPL extends JVM_MANAGEMENT_MIB { while(iterator.hasNext()) { NotificationTarget target = null; try { - target = (NotificationTarget) iterator.next(); + target = iterator.next(); SnmpPeer peer = new SnmpPeer(target.getAddress(), target.getPort()); SnmpParameters p = new SnmpParameters(); diff --git a/src/share/classes/sun/management/snmp/jvminstr/JvmMemGCTableMetaImpl.java b/src/share/classes/sun/management/snmp/jvminstr/JvmMemGCTableMetaImpl.java index 91facb1b8..c2d1a5387 100644 --- a/src/share/classes/sun/management/snmp/jvminstr/JvmMemGCTableMetaImpl.java +++ b/src/share/classes/sun/management/snmp/jvminstr/JvmMemGCTableMetaImpl.java @@ -58,6 +58,8 @@ import sun.management.snmp.util.JvmContextFactory; */ public class JvmMemGCTableMetaImpl extends JvmMemGCTableMeta { + static final long serialVersionUID = 8250461197108867607L; + /** * This class acts as a filter over the SnmpTableHandler * used for the JvmMemoryManagerTable. It filters out diff --git a/src/share/classes/sun/management/snmp/jvminstr/JvmMemManagerTableMetaImpl.java b/src/share/classes/sun/management/snmp/jvminstr/JvmMemManagerTableMetaImpl.java index 51bd51c86..73cccfaa8 100644 --- a/src/share/classes/sun/management/snmp/jvminstr/JvmMemManagerTableMetaImpl.java +++ b/src/share/classes/sun/management/snmp/jvminstr/JvmMemManagerTableMetaImpl.java @@ -61,12 +61,17 @@ import sun.management.snmp.util.JvmContextFactory; */ public class JvmMemManagerTableMetaImpl extends JvmMemManagerTableMeta { + static final long serialVersionUID = 36176771566817592L; + /** * A concrete implementation of {@link SnmpNamedListTableCache}, for the * jvmMemManagerTable. **/ private static class JvmMemManagerTableCache extends SnmpNamedListTableCache { + + static final long serialVersionUID = 6564294074653009240L; + /** * Create a weak cache for the jvmMemManagerTable. * @param validity validity of the cached data, in ms. @@ -87,7 +92,7 @@ public class JvmMemManagerTableMetaImpl extends JvmMemManagerTableMeta { * MemoryManagerMXBean in the list. * @return ((MemoryManagerMXBean)item).getName() **/ - protected String getKey(Object context, List rawDatas, + protected String getKey(Object context, List rawDatas, int rank, Object item) { if (item == null) return null; final String name = ((MemoryManagerMXBean)item).getName(); @@ -99,7 +104,7 @@ public class JvmMemManagerTableMetaImpl extends JvmMemManagerTableMeta { * Call getTableHandler(JvmContextFactory.getUserData()). **/ public SnmpTableHandler getTableHandler() { - final Map userData = JvmContextFactory.getUserData(); + final Map userData = JvmContextFactory.getUserData(); return getTableDatas(userData); } @@ -114,7 +119,7 @@ public class JvmMemManagerTableMetaImpl extends JvmMemManagerTableMeta { * Call ManagementFactory.getMemoryManagerMXBeans() to * load the raw data of this table. **/ - protected List loadRawDatas(Map userData) { + protected List loadRawDatas(Map userData) { return ManagementFactory.getMemoryManagerMXBeans(); } diff --git a/src/share/classes/sun/management/snmp/jvminstr/JvmMemMgrPoolRelTableMetaImpl.java b/src/share/classes/sun/management/snmp/jvminstr/JvmMemMgrPoolRelTableMetaImpl.java index 36d906667..703c46946 100644 --- a/src/share/classes/sun/management/snmp/jvminstr/JvmMemMgrPoolRelTableMetaImpl.java +++ b/src/share/classes/sun/management/snmp/jvminstr/JvmMemMgrPoolRelTableMetaImpl.java @@ -64,13 +64,17 @@ import sun.management.snmp.util.JvmContextFactory; public class JvmMemMgrPoolRelTableMetaImpl extends JvmMemMgrPoolRelTableMeta implements Serializable { + static final long serialVersionUID = 1896509775012355443L; + /** * A concrete implementation of {@link SnmpTableCache}, for the * jvmMemMgrPoolRelTable. **/ + private static class JvmMemMgrPoolRelTableCache extends SnmpTableCache { + static final long serialVersionUID = 6059937161990659184L; final private JvmMemMgrPoolRelTableMetaImpl meta; /** @@ -87,7 +91,7 @@ public class JvmMemMgrPoolRelTableMetaImpl extends JvmMemMgrPoolRelTableMeta * Call getTableDatas(JvmContextFactory.getUserData()). **/ public SnmpTableHandler getTableHandler() { - final Map userData = JvmContextFactory.getUserData(); + final Map userData = JvmContextFactory.getUserData(); return getTableDatas(userData); } @@ -101,7 +105,7 @@ public class JvmMemMgrPoolRelTableMetaImpl extends JvmMemMgrPoolRelTableMeta return buildPoolIndexMap((SnmpCachedData)handler); // not optimizable... too bad. - final Map m = new HashMap(); + final Map m = new HashMap<>(); SnmpOid index=null; while ((index = handler.getNext(index))!=null) { final MemoryPoolMXBean mpm = @@ -124,7 +128,7 @@ public class JvmMemMgrPoolRelTableMetaImpl extends JvmMemMgrPoolRelTableMeta final SnmpOid[] indexes = cached.indexes; final Object[] datas = cached.datas; final int len = indexes.length; - final Map m = new HashMap(len); + final Map m = new HashMap<>(len); for (int i=0; i index - final Map poolIndexMap = buildPoolIndexMap(mpHandler); + final Map poolIndexMap = buildPoolIndexMap(mpHandler); // For each memory manager, get the list of memory pools // For each memory pool, find its index in the memory pool table // Create a row in the relation table. final TreeMap table = - new TreeMap(SnmpCachedData.oidComparator); + new TreeMap<>(SnmpCachedData.oidComparator); updateTreeMap(table,userData,mmHandler,mpHandler,poolIndexMap); return new SnmpCachedData(time,table); @@ -207,7 +211,7 @@ public class JvmMemMgrPoolRelTableMetaImpl extends JvmMemMgrPoolRelTableMeta protected void updateTreeMap(TreeMap table, Object userData, MemoryManagerMXBean mmm, SnmpOid mmIndex, - Map poolIndexMap) { + Map poolIndexMap) { // The MemoryManager index is an int, so it's the first // and only subidentifier. @@ -230,7 +234,7 @@ public class JvmMemMgrPoolRelTableMetaImpl extends JvmMemMgrPoolRelTableMeta for (int i = 0; i < mpList.length; i++) { final String mpmName = mpList[i]; if (mpmName == null) continue; - final SnmpOid mpIndex = (SnmpOid)poolIndexMap.get(mpmName); + final SnmpOid mpIndex = poolIndexMap.get(mpmName); if (mpIndex == null) continue; // The MemoryPool index is an int, so it's the first @@ -261,7 +265,7 @@ public class JvmMemMgrPoolRelTableMetaImpl extends JvmMemMgrPoolRelTableMeta protected void updateTreeMap(TreeMap table, Object userData, SnmpTableHandler mmHandler, SnmpTableHandler mpHandler, - Map poolIndexMap) { + Map poolIndexMap) { if (mmHandler instanceof SnmpCachedData) { updateTreeMap(table,userData,(SnmpCachedData)mmHandler, mpHandler,poolIndexMap); @@ -280,7 +284,7 @@ public class JvmMemMgrPoolRelTableMetaImpl extends JvmMemMgrPoolRelTableMeta protected void updateTreeMap(TreeMap table, Object userData, SnmpCachedData mmHandler, SnmpTableHandler mpHandler, - Map poolIndexMap) { + Map poolIndexMap) { final SnmpOid[] indexes = mmHandler.indexes; final Object[] datas = mmHandler.datas; diff --git a/src/share/classes/sun/management/snmp/jvminstr/JvmMemPoolTableMetaImpl.java b/src/share/classes/sun/management/snmp/jvminstr/JvmMemPoolTableMetaImpl.java index 1a3bf604d..cb2d68675 100644 --- a/src/share/classes/sun/management/snmp/jvminstr/JvmMemPoolTableMetaImpl.java +++ b/src/share/classes/sun/management/snmp/jvminstr/JvmMemPoolTableMetaImpl.java @@ -61,11 +61,16 @@ import sun.management.snmp.util.JvmContextFactory; */ public class JvmMemPoolTableMetaImpl extends JvmMemPoolTableMeta { + static final long serialVersionUID = -2525820976094284957L; + /** * A concrete implementation of {@link SnmpNamedListTableCache}, for the * jvmMemPoolTable. **/ private static class JvmMemPoolTableCache extends SnmpNamedListTableCache { + + static final long serialVersionUID = -1755520683086760574L; + /** * Create a weak cache for the jvmMemPoolTable. * @param validity validity of the cached data, in ms. @@ -86,7 +91,7 @@ public class JvmMemPoolTableMetaImpl extends JvmMemPoolTableMeta { * MemoryPoolMXBean in the list. * @return ((MemoryPoolMXBean)item).getName() **/ - protected String getKey(Object context, List rawDatas, + protected String getKey(Object context, List rawDatas, int rank, Object item) { if (item == null) return null; final String name = ((MemoryPoolMXBean)item).getName(); @@ -98,7 +103,7 @@ public class JvmMemPoolTableMetaImpl extends JvmMemPoolTableMeta { * Call getTableDatas(JvmContextFactory.getUserData()). **/ public SnmpTableHandler getTableHandler() { - final Map userData = JvmContextFactory.getUserData(); + final Map userData = JvmContextFactory.getUserData(); return getTableDatas(userData); } @@ -113,7 +118,7 @@ public class JvmMemPoolTableMetaImpl extends JvmMemPoolTableMeta { * Call ManagementFactory.getMemoryPoolMXBeans() to * load the raw data of this table. **/ - protected List loadRawDatas(Map userData) { + protected List loadRawDatas(Map userData) { return ManagementFactory.getMemoryPoolMXBeans(); } } diff --git a/src/share/classes/sun/management/snmp/jvminstr/JvmMemoryImpl.java b/src/share/classes/sun/management/snmp/jvminstr/JvmMemoryImpl.java index 63a4e7639..f95ec5853 100644 --- a/src/share/classes/sun/management/snmp/jvminstr/JvmMemoryImpl.java +++ b/src/share/classes/sun/management/snmp/jvminstr/JvmMemoryImpl.java @@ -275,7 +275,7 @@ public class JvmMemoryImpl implements JvmMemoryMBean { */ public EnumJvmMemoryGCCall getJvmMemoryGCCall() throws SnmpStatusException { - final Map m = JvmContextFactory.getUserData(); + final Map m = JvmContextFactory.getUserData(); if (m != null) { final EnumJvmMemoryGCCall cached diff --git a/src/share/classes/sun/management/snmp/jvminstr/JvmMemoryMetaImpl.java b/src/share/classes/sun/management/snmp/jvminstr/JvmMemoryMetaImpl.java index be496066a..207415edd 100644 --- a/src/share/classes/sun/management/snmp/jvminstr/JvmMemoryMetaImpl.java +++ b/src/share/classes/sun/management/snmp/jvminstr/JvmMemoryMetaImpl.java @@ -50,6 +50,8 @@ import sun.management.snmp.util.MibLogger; * The class is used for representing SNMP metadata for the "JvmMemory" group. */ public class JvmMemoryMetaImpl extends JvmMemoryMeta { + + static final long serialVersionUID = -6500448253825893071L; /** * Constructor for the metadata associated to "JvmMemory". */ diff --git a/src/share/classes/sun/management/snmp/jvminstr/JvmOSImpl.java b/src/share/classes/sun/management/snmp/jvminstr/JvmOSImpl.java index 28c2929ec..e00169772 100644 --- a/src/share/classes/sun/management/snmp/jvminstr/JvmOSImpl.java +++ b/src/share/classes/sun/management/snmp/jvminstr/JvmOSImpl.java @@ -47,6 +47,8 @@ import sun.management.snmp.jvmmib.JvmOSMBean; */ public class JvmOSImpl implements JvmOSMBean, Serializable { + static final long serialVersionUID = 1839834731763310809L; + /** * Constructor for the "JvmOS" group. * If the group contains a table, the entries created through an diff --git a/src/share/classes/sun/management/snmp/jvminstr/JvmRTBootClassPathEntryImpl.java b/src/share/classes/sun/management/snmp/jvminstr/JvmRTBootClassPathEntryImpl.java index 6624af601..6e4232999 100644 --- a/src/share/classes/sun/management/snmp/jvminstr/JvmRTBootClassPathEntryImpl.java +++ b/src/share/classes/sun/management/snmp/jvminstr/JvmRTBootClassPathEntryImpl.java @@ -44,6 +44,8 @@ import sun.management.snmp.jvmmib.JvmRTBootClassPathEntryMBean; public class JvmRTBootClassPathEntryImpl implements JvmRTBootClassPathEntryMBean, Serializable { + static final long serialVersionUID = -2282652055235913013L; + private final String item; private final int index; diff --git a/src/share/classes/sun/management/snmp/jvminstr/JvmRTBootClassPathTableMetaImpl.java b/src/share/classes/sun/management/snmp/jvminstr/JvmRTBootClassPathTableMetaImpl.java index abc548e43..df794869b 100644 --- a/src/share/classes/sun/management/snmp/jvminstr/JvmRTBootClassPathTableMetaImpl.java +++ b/src/share/classes/sun/management/snmp/jvminstr/JvmRTBootClassPathTableMetaImpl.java @@ -71,6 +71,8 @@ import sun.management.snmp.util.JvmContextFactory; public class JvmRTBootClassPathTableMetaImpl extends JvmRTBootClassPathTableMeta { + static final long serialVersionUID = -8659886610487538299L; + private SnmpTableCache cache; /** @@ -78,6 +80,7 @@ public class JvmRTBootClassPathTableMetaImpl * JvmRTBootClassPathTable. **/ private static class JvmRTBootClassPathTableCache extends SnmpTableCache { + static final long serialVersionUID = -2637458695413646098L; private JvmRTBootClassPathTableMetaImpl meta; JvmRTBootClassPathTableCache(JvmRTBootClassPathTableMetaImpl meta, @@ -90,7 +93,7 @@ public class JvmRTBootClassPathTableMetaImpl * Call getTableDatas(JvmContextFactory.getUserData()). **/ public SnmpTableHandler getTableHandler() { - final Map userData = JvmContextFactory.getUserData(); + final Map userData = JvmContextFactory.getUserData(); return getTableDatas(userData); } diff --git a/src/share/classes/sun/management/snmp/jvminstr/JvmRTClassPathEntryImpl.java b/src/share/classes/sun/management/snmp/jvminstr/JvmRTClassPathEntryImpl.java index d52d1223a..188051afc 100644 --- a/src/share/classes/sun/management/snmp/jvminstr/JvmRTClassPathEntryImpl.java +++ b/src/share/classes/sun/management/snmp/jvminstr/JvmRTClassPathEntryImpl.java @@ -44,6 +44,7 @@ import sun.management.snmp.jvmmib.JvmRTClassPathEntryMBean; public class JvmRTClassPathEntryImpl implements JvmRTClassPathEntryMBean, Serializable { + static final long serialVersionUID = 8524792845083365742L; private final String item; private final int index; diff --git a/src/share/classes/sun/management/snmp/jvminstr/JvmRTClassPathTableMetaImpl.java b/src/share/classes/sun/management/snmp/jvminstr/JvmRTClassPathTableMetaImpl.java index 0e952cb1d..df6168d02 100644 --- a/src/share/classes/sun/management/snmp/jvminstr/JvmRTClassPathTableMetaImpl.java +++ b/src/share/classes/sun/management/snmp/jvminstr/JvmRTClassPathTableMetaImpl.java @@ -70,6 +70,8 @@ import sun.management.snmp.util.JvmContextFactory; */ public class JvmRTClassPathTableMetaImpl extends JvmRTClassPathTableMeta { + static final long serialVersionUID = -6914494148818455166L; + private SnmpTableCache cache; /** @@ -77,6 +79,7 @@ public class JvmRTClassPathTableMetaImpl extends JvmRTClassPathTableMeta { * JvmRTClassPathTable. **/ private static class JvmRTClassPathTableCache extends SnmpTableCache { + static final long serialVersionUID = 3805032372592117315L; private JvmRTClassPathTableMetaImpl meta; JvmRTClassPathTableCache(JvmRTClassPathTableMetaImpl meta, @@ -89,7 +92,7 @@ public class JvmRTClassPathTableMetaImpl extends JvmRTClassPathTableMeta { * Call getTableDatas(JvmContextFactory.getUserData()). **/ public SnmpTableHandler getTableHandler() { - final Map userData = JvmContextFactory.getUserData(); + final Map userData = JvmContextFactory.getUserData(); return getTableDatas(userData); } diff --git a/src/share/classes/sun/management/snmp/jvminstr/JvmRTInputArgsEntryImpl.java b/src/share/classes/sun/management/snmp/jvminstr/JvmRTInputArgsEntryImpl.java index b480c48c5..80811ed39 100644 --- a/src/share/classes/sun/management/snmp/jvminstr/JvmRTInputArgsEntryImpl.java +++ b/src/share/classes/sun/management/snmp/jvminstr/JvmRTInputArgsEntryImpl.java @@ -44,6 +44,7 @@ import sun.management.snmp.jvmmib.JvmRTInputArgsEntryMBean; public class JvmRTInputArgsEntryImpl implements JvmRTInputArgsEntryMBean, Serializable { + static final long serialVersionUID = 1000306518436503395L; private final String item; private final int index; diff --git a/src/share/classes/sun/management/snmp/jvminstr/JvmRTInputArgsTableMetaImpl.java b/src/share/classes/sun/management/snmp/jvminstr/JvmRTInputArgsTableMetaImpl.java index 259a2844c..13e5d4adf 100644 --- a/src/share/classes/sun/management/snmp/jvminstr/JvmRTInputArgsTableMetaImpl.java +++ b/src/share/classes/sun/management/snmp/jvminstr/JvmRTInputArgsTableMetaImpl.java @@ -70,6 +70,7 @@ import sun.management.snmp.util.JvmContextFactory; */ public class JvmRTInputArgsTableMetaImpl extends JvmRTInputArgsTableMeta { + static final long serialVersionUID = -2083438094888099238L; private SnmpTableCache cache; /** @@ -77,6 +78,8 @@ public class JvmRTInputArgsTableMetaImpl extends JvmRTInputArgsTableMeta { * JvmRTInputArgsTable. **/ private static class JvmRTInputArgsTableCache extends SnmpTableCache { + + static final long serialVersionUID = 1693751105464785192L; private JvmRTInputArgsTableMetaImpl meta; JvmRTInputArgsTableCache(JvmRTInputArgsTableMetaImpl meta, @@ -89,7 +92,7 @@ public class JvmRTInputArgsTableMetaImpl extends JvmRTInputArgsTableMeta { * Call getTableDatas(JvmContextFactory.getUserData()). **/ public SnmpTableHandler getTableHandler() { - final Map userData = JvmContextFactory.getUserData(); + final Map userData = JvmContextFactory.getUserData(); return getTableDatas(userData); } diff --git a/src/share/classes/sun/management/snmp/jvminstr/JvmRTLibraryPathEntryImpl.java b/src/share/classes/sun/management/snmp/jvminstr/JvmRTLibraryPathEntryImpl.java index 5447768d8..554b342b8 100644 --- a/src/share/classes/sun/management/snmp/jvminstr/JvmRTLibraryPathEntryImpl.java +++ b/src/share/classes/sun/management/snmp/jvminstr/JvmRTLibraryPathEntryImpl.java @@ -44,6 +44,7 @@ import sun.management.snmp.jvmmib.JvmRTLibraryPathEntryMBean; public class JvmRTLibraryPathEntryImpl implements JvmRTLibraryPathEntryMBean, Serializable { + static final long serialVersionUID = -3322438153507369765L; private final String item; private final int index; diff --git a/src/share/classes/sun/management/snmp/jvminstr/JvmRTLibraryPathTableMetaImpl.java b/src/share/classes/sun/management/snmp/jvminstr/JvmRTLibraryPathTableMetaImpl.java index 62b5ae82f..971677b85 100644 --- a/src/share/classes/sun/management/snmp/jvminstr/JvmRTLibraryPathTableMetaImpl.java +++ b/src/share/classes/sun/management/snmp/jvminstr/JvmRTLibraryPathTableMetaImpl.java @@ -70,6 +70,7 @@ import sun.management.snmp.util.JvmContextFactory; */ public class JvmRTLibraryPathTableMetaImpl extends JvmRTLibraryPathTableMeta { + static final long serialVersionUID = 6713252710712502068L; private SnmpTableCache cache; /** @@ -77,6 +78,7 @@ public class JvmRTLibraryPathTableMetaImpl extends JvmRTLibraryPathTableMeta { * JvmRTLibraryPathTable. **/ private static class JvmRTLibraryPathTableCache extends SnmpTableCache { + static final long serialVersionUID = 2035304445719393195L; private JvmRTLibraryPathTableMetaImpl meta; JvmRTLibraryPathTableCache(JvmRTLibraryPathTableMetaImpl meta, @@ -89,7 +91,7 @@ public class JvmRTLibraryPathTableMetaImpl extends JvmRTLibraryPathTableMeta { * Call getTableDatas(JvmContextFactory.getUserData()). **/ public SnmpTableHandler getTableHandler() { - final Map userData = JvmContextFactory.getUserData(); + final Map userData = JvmContextFactory.getUserData(); return getTableDatas(userData); } diff --git a/src/share/classes/sun/management/snmp/jvminstr/JvmRuntimeMetaImpl.java b/src/share/classes/sun/management/snmp/jvminstr/JvmRuntimeMetaImpl.java index 895e8d227..1f15b4f80 100644 --- a/src/share/classes/sun/management/snmp/jvminstr/JvmRuntimeMetaImpl.java +++ b/src/share/classes/sun/management/snmp/jvminstr/JvmRuntimeMetaImpl.java @@ -68,6 +68,7 @@ import sun.management.snmp.jvmmib.JvmRTLibraryPathTableMeta; */ public class JvmRuntimeMetaImpl extends JvmRuntimeMeta { + static final long serialVersionUID = -6570428414857608618L; /** * Constructor for the metadata associated to "JvmRuntime". */ diff --git a/src/share/classes/sun/management/snmp/jvminstr/JvmThreadInstanceEntryImpl.java b/src/share/classes/sun/management/snmp/jvminstr/JvmThreadInstanceEntryImpl.java index 4410a7c1b..77acb455b 100644 --- a/src/share/classes/sun/management/snmp/jvminstr/JvmThreadInstanceEntryImpl.java +++ b/src/share/classes/sun/management/snmp/jvminstr/JvmThreadInstanceEntryImpl.java @@ -53,6 +53,8 @@ import sun.management.snmp.util.MibLogger; public class JvmThreadInstanceEntryImpl implements JvmThreadInstanceEntryMBean, Serializable { + static final long serialVersionUID = 910173589985461347L; + public final static class ThreadStateMap { public final static class Byte0 { public final static byte inNative = (byte)0x80; // bit 1 diff --git a/src/share/classes/sun/management/snmp/jvminstr/JvmThreadInstanceTableMetaImpl.java b/src/share/classes/sun/management/snmp/jvminstr/JvmThreadInstanceTableMetaImpl.java index 0c9c2357d..b2ce4774c 100644 --- a/src/share/classes/sun/management/snmp/jvminstr/JvmThreadInstanceTableMetaImpl.java +++ b/src/share/classes/sun/management/snmp/jvminstr/JvmThreadInstanceTableMetaImpl.java @@ -78,6 +78,8 @@ import sun.management.snmp.util.JvmContextFactory; public class JvmThreadInstanceTableMetaImpl extends JvmThreadInstanceTableMeta { + static final long serialVersionUID = -8432271929226397492L; + /** * Maximum depth of the stacktrace that might be returned through * SNMP. @@ -135,6 +137,7 @@ public class JvmThreadInstanceTableMetaImpl private static class JvmThreadInstanceTableCache extends SnmpTableCache { + static final long serialVersionUID = 4947330124563406878L; final private JvmThreadInstanceTableMetaImpl meta; /** @@ -151,7 +154,7 @@ public class JvmThreadInstanceTableMetaImpl * Call getTableDatas(JvmContextFactory.getUserData()). **/ public SnmpTableHandler getTableHandler() { - final Map userData = JvmContextFactory.getUserData(); + final Map userData = JvmContextFactory.getUserData(); return getTableDatas(userData); } @@ -172,7 +175,7 @@ public class JvmThreadInstanceTableMetaImpl SnmpOid indexes[] = new SnmpOid[id.length]; final TreeMap table = - new TreeMap(SnmpCachedData.oidComparator); + new TreeMap<>(SnmpCachedData.oidComparator); for(int i = 0; i < id.length; i++) { log.debug("", "Making index for thread id [" + id[i] +"]"); //indexes[i] = makeOid(id[i]); @@ -277,7 +280,7 @@ public class JvmThreadInstanceTableMetaImpl // Get the request contextual cache (userData). // - final Map m = JvmContextFactory.getUserData(); + final Map m = JvmContextFactory.getUserData(); // Get the handler. // diff --git a/src/share/classes/sun/management/snmp/jvminstr/JvmThreadingMetaImpl.java b/src/share/classes/sun/management/snmp/jvminstr/JvmThreadingMetaImpl.java index 9239e7dc2..f2773c5b0 100644 --- a/src/share/classes/sun/management/snmp/jvminstr/JvmThreadingMetaImpl.java +++ b/src/share/classes/sun/management/snmp/jvminstr/JvmThreadingMetaImpl.java @@ -66,6 +66,8 @@ import sun.management.snmp.jvmmib.JvmThreadInstanceTableMeta; */ public class JvmThreadingMetaImpl extends JvmThreadingMeta { + static final long serialVersionUID = -2104788458393251457L; + /** * Constructor for the metadata associated to "JvmThreading". */ diff --git a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmClassesVerboseLevel.java b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmClassesVerboseLevel.java index caa7bc943..16113d4b1 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmClassesVerboseLevel.java +++ b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmClassesVerboseLevel.java @@ -43,10 +43,11 @@ import com.sun.jmx.snmp.Enumerated; */ public class EnumJvmClassesVerboseLevel extends Enumerated implements Serializable { + static final long serialVersionUID = -620710366914810374L; protected static Hashtable intTable = - new Hashtable(); + new Hashtable<>(); protected static Hashtable stringTable = - new Hashtable(); + new Hashtable<>(); static { intTable.put(new Integer(2), "verbose"); intTable.put(new Integer(1), "silent"); @@ -70,11 +71,11 @@ public class EnumJvmClassesVerboseLevel extends Enumerated implements Serializab super(x); } - protected Hashtable getIntTable() { + protected Hashtable getIntTable() { return intTable ; } - protected Hashtable getStringTable() { + protected Hashtable getStringTable() { return stringTable ; } diff --git a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmJITCompilerTimeMonitoring.java b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmJITCompilerTimeMonitoring.java index 038d3796d..e69bc4ebd 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmJITCompilerTimeMonitoring.java +++ b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmJITCompilerTimeMonitoring.java @@ -43,10 +43,11 @@ import com.sun.jmx.snmp.Enumerated; */ public class EnumJvmJITCompilerTimeMonitoring extends Enumerated implements Serializable { + static final long serialVersionUID = 3953565918146461236L; protected static Hashtable intTable = - new Hashtable(); + new Hashtable<>(); protected static Hashtable stringTable = - new Hashtable(); + new Hashtable<>(); static { intTable.put(new Integer(2), "supported"); intTable.put(new Integer(1), "unsupported"); @@ -70,11 +71,11 @@ public class EnumJvmJITCompilerTimeMonitoring extends Enumerated implements Seri super(x); } - protected Hashtable getIntTable() { + protected Hashtable getIntTable() { return intTable ; } - protected Hashtable getStringTable() { + protected Hashtable getStringTable() { return stringTable ; } diff --git a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemManagerState.java b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemManagerState.java index fd2a324d6..6eea58eb6 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemManagerState.java +++ b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemManagerState.java @@ -43,10 +43,12 @@ import com.sun.jmx.snmp.Enumerated; */ public class EnumJvmMemManagerState extends Enumerated implements Serializable { + static final long serialVersionUID = 8249515157795166343L; + protected static Hashtable intTable = - new Hashtable(); + new Hashtable<>(); protected static Hashtable stringTable = - new Hashtable(); + new Hashtable<>(); static { intTable.put(new Integer(2), "valid"); intTable.put(new Integer(1), "invalid"); @@ -70,11 +72,11 @@ public class EnumJvmMemManagerState extends Enumerated implements Serializable { super(x); } - protected Hashtable getIntTable() { + protected Hashtable getIntTable() { return intTable ; } - protected Hashtable getStringTable() { + protected Hashtable getStringTable() { return stringTable ; } diff --git a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemPoolCollectThreshdSupport.java b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemPoolCollectThreshdSupport.java index 5246160c1..6982ae7df 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemPoolCollectThreshdSupport.java +++ b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemPoolCollectThreshdSupport.java @@ -43,10 +43,11 @@ import com.sun.jmx.snmp.Enumerated; */ public class EnumJvmMemPoolCollectThreshdSupport extends Enumerated implements Serializable { + static final long serialVersionUID = 8610091819732806282L; protected static Hashtable intTable = - new Hashtable(); + new Hashtable<>(); protected static Hashtable stringTable = - new Hashtable(); + new Hashtable<>(); static { intTable.put(new Integer(2), "supported"); intTable.put(new Integer(1), "unsupported"); @@ -70,11 +71,11 @@ public class EnumJvmMemPoolCollectThreshdSupport extends Enumerated implements S super(x); } - protected Hashtable getIntTable() { + protected Hashtable getIntTable() { return intTable ; } - protected Hashtable getStringTable() { + protected Hashtable getStringTable() { return stringTable ; } diff --git a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemPoolState.java b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemPoolState.java index 59c8f4bb0..504699745 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemPoolState.java +++ b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemPoolState.java @@ -43,10 +43,11 @@ import com.sun.jmx.snmp.Enumerated; */ public class EnumJvmMemPoolState extends Enumerated implements Serializable { + static final long serialVersionUID = 3038175407527743027L; protected static Hashtable intTable = - new Hashtable(); + new Hashtable<>(); protected static Hashtable stringTable = - new Hashtable(); + new Hashtable<>(); static { intTable.put(new Integer(2), "valid"); intTable.put(new Integer(1), "invalid"); @@ -70,11 +71,11 @@ public class EnumJvmMemPoolState extends Enumerated implements Serializable { super(x); } - protected Hashtable getIntTable() { + protected Hashtable getIntTable() { return intTable ; } - protected Hashtable getStringTable() { + protected Hashtable getStringTable() { return stringTable ; } diff --git a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemPoolThreshdSupport.java b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemPoolThreshdSupport.java index acd00df64..1da71f93e 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemPoolThreshdSupport.java +++ b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemPoolThreshdSupport.java @@ -43,10 +43,11 @@ import com.sun.jmx.snmp.Enumerated; */ public class EnumJvmMemPoolThreshdSupport extends Enumerated implements Serializable { + static final long serialVersionUID = 7014693561120661029L; protected static Hashtable intTable = - new Hashtable(); + new Hashtable<>(); protected static Hashtable stringTable = - new Hashtable(); + new Hashtable<>(); static { intTable.put(new Integer(2), "supported"); intTable.put(new Integer(1), "unsupported"); @@ -70,11 +71,11 @@ public class EnumJvmMemPoolThreshdSupport extends Enumerated implements Serializ super(x); } - protected Hashtable getIntTable() { + protected Hashtable getIntTable() { return intTable ; } - protected Hashtable getStringTable() { + protected Hashtable getStringTable() { return stringTable ; } diff --git a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemPoolType.java b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemPoolType.java index 99f0cd49c..add9fd2a6 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemPoolType.java +++ b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemPoolType.java @@ -43,10 +43,11 @@ import com.sun.jmx.snmp.Enumerated; */ public class EnumJvmMemPoolType extends Enumerated implements Serializable { + static final long serialVersionUID = -7214498472962396555L; protected static Hashtable intTable = - new Hashtable(); + new Hashtable<>(); protected static Hashtable stringTable = - new Hashtable(); + new Hashtable<>(); static { intTable.put(new Integer(2), "heap"); intTable.put(new Integer(1), "nonheap"); @@ -70,11 +71,11 @@ public class EnumJvmMemPoolType extends Enumerated implements Serializable { super(x); } - protected Hashtable getIntTable() { + protected Hashtable getIntTable() { return intTable ; } - protected Hashtable getStringTable() { + protected Hashtable getStringTable() { return stringTable ; } diff --git a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemoryGCCall.java b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemoryGCCall.java index ecf024b26..ca19740a4 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemoryGCCall.java +++ b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemoryGCCall.java @@ -43,10 +43,11 @@ import com.sun.jmx.snmp.Enumerated; */ public class EnumJvmMemoryGCCall extends Enumerated implements Serializable { + static final long serialVersionUID = -2869147994287351375L; protected static Hashtable intTable = - new Hashtable(); + new Hashtable<>(); protected static Hashtable stringTable = - new Hashtable(); + new Hashtable<>(); static { intTable.put(new Integer(2), "supported"); intTable.put(new Integer(5), "failed"); @@ -76,11 +77,11 @@ public class EnumJvmMemoryGCCall extends Enumerated implements Serializable { super(x); } - protected Hashtable getIntTable() { + protected Hashtable getIntTable() { return intTable ; } - protected Hashtable getStringTable() { + protected Hashtable getStringTable() { return stringTable ; } diff --git a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemoryGCVerboseLevel.java b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemoryGCVerboseLevel.java index 51205085b..90a718f4d 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemoryGCVerboseLevel.java +++ b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemoryGCVerboseLevel.java @@ -43,10 +43,11 @@ import com.sun.jmx.snmp.Enumerated; */ public class EnumJvmMemoryGCVerboseLevel extends Enumerated implements Serializable { + static final long serialVersionUID = 1362427628755978190L; protected static Hashtable intTable = - new Hashtable(); + new Hashtable<>(); protected static Hashtable stringTable = - new Hashtable(); + new Hashtable<>(); static { intTable.put(new Integer(2), "verbose"); intTable.put(new Integer(1), "silent"); @@ -70,11 +71,11 @@ public class EnumJvmMemoryGCVerboseLevel extends Enumerated implements Serializa super(x); } - protected Hashtable getIntTable() { + protected Hashtable getIntTable() { return intTable ; } - protected Hashtable getStringTable() { + protected Hashtable getStringTable() { return stringTable ; } diff --git a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmRTBootClassPathSupport.java b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmRTBootClassPathSupport.java index 4ec327e0b..9d2276c4e 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmRTBootClassPathSupport.java +++ b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmRTBootClassPathSupport.java @@ -43,10 +43,11 @@ import com.sun.jmx.snmp.Enumerated; */ public class EnumJvmRTBootClassPathSupport extends Enumerated implements Serializable { + static final long serialVersionUID = -5957542680437939894L; protected static Hashtable intTable = - new Hashtable(); + new Hashtable<>(); protected static Hashtable stringTable = - new Hashtable(); + new Hashtable<>(); static { intTable.put(new Integer(2), "supported"); intTable.put(new Integer(1), "unsupported"); @@ -70,11 +71,11 @@ public class EnumJvmRTBootClassPathSupport extends Enumerated implements Seriali super(x); } - protected Hashtable getIntTable() { + protected Hashtable getIntTable() { return intTable ; } - protected Hashtable getStringTable() { + protected Hashtable getStringTable() { return stringTable ; } diff --git a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmThreadContentionMonitoring.java b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmThreadContentionMonitoring.java index 04e7b6be8..83400b9e2 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmThreadContentionMonitoring.java +++ b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmThreadContentionMonitoring.java @@ -43,10 +43,11 @@ import com.sun.jmx.snmp.Enumerated; */ public class EnumJvmThreadContentionMonitoring extends Enumerated implements Serializable { + static final long serialVersionUID = -6411827583604137210L; protected static Hashtable intTable = - new Hashtable(); + new Hashtable<>(); protected static Hashtable stringTable = - new Hashtable(); + new Hashtable<>(); static { intTable.put(new Integer(3), "enabled"); intTable.put(new Integer(4), "disabled"); @@ -72,11 +73,11 @@ public class EnumJvmThreadContentionMonitoring extends Enumerated implements Ser super(x); } - protected Hashtable getIntTable() { + protected Hashtable getIntTable() { return intTable ; } - protected Hashtable getStringTable() { + protected Hashtable getStringTable() { return stringTable ; } diff --git a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmThreadCpuTimeMonitoring.java b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmThreadCpuTimeMonitoring.java index 90193644d..aad2715c4 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/EnumJvmThreadCpuTimeMonitoring.java +++ b/src/share/classes/sun/management/snmp/jvmmib/EnumJvmThreadCpuTimeMonitoring.java @@ -43,10 +43,11 @@ import com.sun.jmx.snmp.Enumerated; */ public class EnumJvmThreadCpuTimeMonitoring extends Enumerated implements Serializable { + static final long serialVersionUID = -532837824105215699L; protected static Hashtable intTable = - new Hashtable(); + new Hashtable<>(); protected static Hashtable stringTable = - new Hashtable(); + new Hashtable<>(); static { intTable.put(new Integer(3), "enabled"); intTable.put(new Integer(4), "disabled"); @@ -72,11 +73,11 @@ public class EnumJvmThreadCpuTimeMonitoring extends Enumerated implements Serial super(x); } - protected Hashtable getIntTable() { + protected Hashtable getIntTable() { return intTable ; } - protected Hashtable getStringTable() { + protected Hashtable getStringTable() { return stringTable ; } diff --git a/src/share/classes/sun/management/snmp/jvmmib/JVM_MANAGEMENT_MIB.java b/src/share/classes/sun/management/snmp/jvmmib/JVM_MANAGEMENT_MIB.java index 4cdf366f2..9206a4361 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JVM_MANAGEMENT_MIB.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JVM_MANAGEMENT_MIB.java @@ -53,6 +53,7 @@ import com.sun.jmx.snmp.agent.SnmpStandardObjectServer; */ public abstract class JVM_MANAGEMENT_MIB extends SnmpMib implements Serializable { + static final long serialVersionUID = 6895037919735816732L; /** * Default constructor. Initialize the Mib tree. */ diff --git a/src/share/classes/sun/management/snmp/jvmmib/JVM_MANAGEMENT_MIBOidTable.java b/src/share/classes/sun/management/snmp/jvmmib/JVM_MANAGEMENT_MIBOidTable.java index 1f48df65c..e9a896ebf 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JVM_MANAGEMENT_MIBOidTable.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JVM_MANAGEMENT_MIBOidTable.java @@ -47,6 +47,7 @@ import com.sun.jmx.snmp.SnmpOidTableSupport; */ public class JVM_MANAGEMENT_MIBOidTable extends SnmpOidTableSupport implements Serializable { + static final long serialVersionUID = -5010870014488732061L; /** * Default constructor. Initialize the Mib tree. */ diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmClassLoadingMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmClassLoadingMeta.java index a3182136f..806e3e368 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmClassLoadingMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmClassLoadingMeta.java @@ -70,6 +70,7 @@ import com.sun.jmx.snmp.SnmpDefinitions; public class JvmClassLoadingMeta extends SnmpMibGroup implements Serializable, SnmpStandardMetaServer { + static final long serialVersionUID = 5722857476941218568L; /** * Constructor for the metadata associated to "JvmClassLoading". */ diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmCompilationMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmCompilationMeta.java index 0fda62cbf..ab805b348 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmCompilationMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmCompilationMeta.java @@ -70,6 +70,7 @@ import com.sun.jmx.snmp.SnmpDefinitions; public class JvmCompilationMeta extends SnmpMibGroup implements Serializable, SnmpStandardMetaServer { + static final long serialVersionUID = -95492874115033638L; /** * Constructor for the metadata associated to "JvmCompilation". */ diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmMemGCEntryMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmMemGCEntryMeta.java index c42193768..4ee165ab1 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmMemGCEntryMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmMemGCEntryMeta.java @@ -71,6 +71,7 @@ import com.sun.jmx.snmp.SnmpDefinitions; public class JvmMemGCEntryMeta extends SnmpMibEntry implements Serializable, SnmpStandardMetaServer { + static final long serialVersionUID = 6082082529298387063L; /** * Constructor for the metadata associated to "JvmMemGCEntry". */ diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmMemGCTableMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmMemGCTableMeta.java index 58ed92c85..2eff503a2 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmMemGCTableMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmMemGCTableMeta.java @@ -68,6 +68,7 @@ import com.sun.jmx.snmp.agent.SnmpStandardObjectServer; */ public class JvmMemGCTableMeta extends SnmpMibTable implements Serializable { + static final long serialVersionUID = -8843296871149264612L; /** * Constructor for the table. Initialize metadata for "JvmMemGCTableMeta". * The reference on the MBean server is updated so the entries created through an SNMP SET will be AUTOMATICALLY REGISTERED in Java DMK. diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmMemManagerEntryMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmMemManagerEntryMeta.java index dba777920..812ce8c6c 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmMemManagerEntryMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmMemManagerEntryMeta.java @@ -71,6 +71,7 @@ import com.sun.jmx.snmp.SnmpDefinitions; public class JvmMemManagerEntryMeta extends SnmpMibEntry implements Serializable, SnmpStandardMetaServer { + static final long serialVersionUID = 8166956416408970453L; /** * Constructor for the metadata associated to "JvmMemManagerEntry". */ diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmMemManagerTableMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmMemManagerTableMeta.java index 3247b3f2f..cb0d502b4 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmMemManagerTableMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmMemManagerTableMeta.java @@ -68,6 +68,7 @@ import com.sun.jmx.snmp.agent.SnmpStandardObjectServer; */ public class JvmMemManagerTableMeta extends SnmpMibTable implements Serializable { + static final long serialVersionUID = 5026520607518015233L; /** * Constructor for the table. Initialize metadata for "JvmMemManagerTableMeta". * The reference on the MBean server is updated so the entries created through an SNMP SET will be AUTOMATICALLY REGISTERED in Java DMK. diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmMemMgrPoolRelEntryMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmMemMgrPoolRelEntryMeta.java index 00a1c588f..143b93ce2 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmMemMgrPoolRelEntryMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmMemMgrPoolRelEntryMeta.java @@ -71,6 +71,7 @@ import com.sun.jmx.snmp.SnmpDefinitions; public class JvmMemMgrPoolRelEntryMeta extends SnmpMibEntry implements Serializable, SnmpStandardMetaServer { + static final long serialVersionUID = 7414270971113459798L; /** * Constructor for the metadata associated to "JvmMemMgrPoolRelEntry". */ diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmMemMgrPoolRelTableMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmMemMgrPoolRelTableMeta.java index 1cf86879d..62af9f740 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmMemMgrPoolRelTableMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmMemMgrPoolRelTableMeta.java @@ -68,6 +68,7 @@ import com.sun.jmx.snmp.agent.SnmpStandardObjectServer; */ public class JvmMemMgrPoolRelTableMeta extends SnmpMibTable implements Serializable { + static final long serialVersionUID = -310733366542788998L; /** * Constructor for the table. Initialize metadata for "JvmMemMgrPoolRelTableMeta". * The reference on the MBean server is updated so the entries created through an SNMP SET will be AUTOMATICALLY REGISTERED in Java DMK. diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmMemPoolEntryMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmMemPoolEntryMeta.java index 14860291a..85cf52813 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmMemPoolEntryMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmMemPoolEntryMeta.java @@ -71,6 +71,7 @@ import com.sun.jmx.snmp.SnmpDefinitions; public class JvmMemPoolEntryMeta extends SnmpMibEntry implements Serializable, SnmpStandardMetaServer { + static final long serialVersionUID = 7220682779249102830L; /** * Constructor for the metadata associated to "JvmMemPoolEntry". */ diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmMemPoolTableMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmMemPoolTableMeta.java index 43c8ec7fa..150e4eebe 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmMemPoolTableMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmMemPoolTableMeta.java @@ -68,6 +68,8 @@ import com.sun.jmx.snmp.agent.SnmpStandardObjectServer; */ public class JvmMemPoolTableMeta extends SnmpMibTable implements Serializable { + static final long serialVersionUID = -2799470815264898659L; + /** * Constructor for the table. Initialize metadata for "JvmMemPoolTableMeta". * The reference on the MBean server is updated so the entries created through an SNMP SET will be AUTOMATICALLY REGISTERED in Java DMK. diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmOSMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmOSMeta.java index f3ab763c9..971b606a9 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmOSMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmOSMeta.java @@ -70,6 +70,8 @@ import com.sun.jmx.snmp.SnmpDefinitions; public class JvmOSMeta extends SnmpMibGroup implements Serializable, SnmpStandardMetaServer { + static final long serialVersionUID = -2024138733580127133L; + /** * Constructor for the metadata associated to "JvmOS". */ diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmRTBootClassPathEntryMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmRTBootClassPathEntryMeta.java index 3516ba7d3..d0346a340 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmRTBootClassPathEntryMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmRTBootClassPathEntryMeta.java @@ -71,6 +71,7 @@ import com.sun.jmx.snmp.SnmpDefinitions; public class JvmRTBootClassPathEntryMeta extends SnmpMibEntry implements Serializable, SnmpStandardMetaServer { + static final long serialVersionUID = 7703840715080588941L; /** * Constructor for the metadata associated to "JvmRTBootClassPathEntry". */ diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmRTBootClassPathTableMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmRTBootClassPathTableMeta.java index 91684f765..1b732a612 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmRTBootClassPathTableMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmRTBootClassPathTableMeta.java @@ -68,6 +68,7 @@ import com.sun.jmx.snmp.agent.SnmpStandardObjectServer; */ public class JvmRTBootClassPathTableMeta extends SnmpMibTable implements Serializable { + static final long serialVersionUID = 42471379600792135L; /** * Constructor for the table. Initialize metadata for "JvmRTBootClassPathTableMeta". * The reference on the MBean server is updated so the entries created through an SNMP SET will be AUTOMATICALLY REGISTERED in Java DMK. diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmRTClassPathEntryMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmRTClassPathEntryMeta.java index 2b0089c03..2c8464d8c 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmRTClassPathEntryMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmRTClassPathEntryMeta.java @@ -71,6 +71,7 @@ import com.sun.jmx.snmp.SnmpDefinitions; public class JvmRTClassPathEntryMeta extends SnmpMibEntry implements Serializable, SnmpStandardMetaServer { + static final long serialVersionUID = 3388703998226830801L; /** * Constructor for the metadata associated to "JvmRTClassPathEntry". */ diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmRTClassPathTableMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmRTClassPathTableMeta.java index 12719afe2..1cf893077 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmRTClassPathTableMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmRTClassPathTableMeta.java @@ -68,6 +68,7 @@ import com.sun.jmx.snmp.agent.SnmpStandardObjectServer; */ public class JvmRTClassPathTableMeta extends SnmpMibTable implements Serializable { + static final long serialVersionUID = -1518727175345404443L; /** * Constructor for the table. Initialize metadata for "JvmRTClassPathTableMeta". * The reference on the MBean server is updated so the entries created through an SNMP SET will be AUTOMATICALLY REGISTERED in Java DMK. diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmRTInputArgsEntryMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmRTInputArgsEntryMeta.java index dcb866017..1a8dcf0e4 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmRTInputArgsEntryMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmRTInputArgsEntryMeta.java @@ -71,6 +71,7 @@ import com.sun.jmx.snmp.SnmpDefinitions; public class JvmRTInputArgsEntryMeta extends SnmpMibEntry implements Serializable, SnmpStandardMetaServer { + static final long serialVersionUID = -7729576810347358025L; /** * Constructor for the metadata associated to "JvmRTInputArgsEntry". */ diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmRTInputArgsTableMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmRTInputArgsTableMeta.java index cf7c83628..8ee7982ef 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmRTInputArgsTableMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmRTInputArgsTableMeta.java @@ -68,6 +68,7 @@ import com.sun.jmx.snmp.agent.SnmpStandardObjectServer; */ public class JvmRTInputArgsTableMeta extends SnmpMibTable implements Serializable { + static final long serialVersionUID = 5395531763015738645L; /** * Constructor for the table. Initialize metadata for "JvmRTInputArgsTableMeta". * The reference on the MBean server is updated so the entries created through an SNMP SET will be AUTOMATICALLY REGISTERED in Java DMK. diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmRTLibraryPathEntryMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmRTLibraryPathEntryMeta.java index 81a4e6861..f89ac7495 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmRTLibraryPathEntryMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmRTLibraryPathEntryMeta.java @@ -71,6 +71,7 @@ import com.sun.jmx.snmp.SnmpDefinitions; public class JvmRTLibraryPathEntryMeta extends SnmpMibEntry implements Serializable, SnmpStandardMetaServer { + static final long serialVersionUID = -5851555586263475792L; /** * Constructor for the metadata associated to "JvmRTLibraryPathEntry". */ diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmRTLibraryPathTableMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmRTLibraryPathTableMeta.java index b052f87b3..5f9e11631 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmRTLibraryPathTableMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmRTLibraryPathTableMeta.java @@ -68,6 +68,7 @@ import com.sun.jmx.snmp.agent.SnmpStandardObjectServer; */ public class JvmRTLibraryPathTableMeta extends SnmpMibTable implements Serializable { + static final long serialVersionUID = -632403620113109468L; /** * Constructor for the table. Initialize metadata for "JvmRTLibraryPathTableMeta". * The reference on the MBean server is updated so the entries created through an SNMP SET will be AUTOMATICALLY REGISTERED in Java DMK. diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmRuntimeMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmRuntimeMeta.java index 377b6e785..d0c48263d 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmRuntimeMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmRuntimeMeta.java @@ -70,6 +70,7 @@ import com.sun.jmx.snmp.SnmpDefinitions; public class JvmRuntimeMeta extends SnmpMibGroup implements Serializable, SnmpStandardMetaServer { + static final long serialVersionUID = 1994595220765880109L; /** * Constructor for the metadata associated to "JvmRuntime". */ diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmThreadInstanceEntryMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmThreadInstanceEntryMeta.java index f921e022c..a6c30c146 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmThreadInstanceEntryMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmThreadInstanceEntryMeta.java @@ -71,6 +71,7 @@ import com.sun.jmx.snmp.SnmpDefinitions; public class JvmThreadInstanceEntryMeta extends SnmpMibEntry implements Serializable, SnmpStandardMetaServer { + static final long serialVersionUID = -2015330111801477399L; /** * Constructor for the metadata associated to "JvmThreadInstanceEntry". */ diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmThreadInstanceTableMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmThreadInstanceTableMeta.java index 3f2a436f8..68613ba57 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmThreadInstanceTableMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmThreadInstanceTableMeta.java @@ -68,6 +68,7 @@ import com.sun.jmx.snmp.agent.SnmpStandardObjectServer; */ public class JvmThreadInstanceTableMeta extends SnmpMibTable implements Serializable { + static final long serialVersionUID = 2519514732589115954L; /** * Constructor for the table. Initialize metadata for "JvmThreadInstanceTableMeta". * The reference on the MBean server is updated so the entries created through an SNMP SET will be AUTOMATICALLY REGISTERED in Java DMK. diff --git a/src/share/classes/sun/management/snmp/jvmmib/JvmThreadingMeta.java b/src/share/classes/sun/management/snmp/jvmmib/JvmThreadingMeta.java index 39d3267eb..6d81f9437 100644 --- a/src/share/classes/sun/management/snmp/jvmmib/JvmThreadingMeta.java +++ b/src/share/classes/sun/management/snmp/jvmmib/JvmThreadingMeta.java @@ -70,6 +70,7 @@ import com.sun.jmx.snmp.SnmpDefinitions; public class JvmThreadingMeta extends SnmpMibGroup implements Serializable, SnmpStandardMetaServer { + static final long serialVersionUID = 5223833578005322854L; /** * Constructor for the metadata associated to "JvmThreading". */ diff --git a/src/share/classes/sun/management/snmp/util/MibLogger.java b/src/share/classes/sun/management/snmp/util/MibLogger.java index 51fa0a0c2..4d1a5f07d 100644 --- a/src/share/classes/sun/management/snmp/util/MibLogger.java +++ b/src/share/classes/sun/management/snmp/util/MibLogger.java @@ -32,7 +32,7 @@ public class MibLogger { final Logger logger; final String className; - static String getClassName(Class clazz) { + static String getClassName(Class clazz) { if (clazz == null) return null; if (clazz.isArray()) return getClassName(clazz.getComponentType()) + "[]"; @@ -44,7 +44,7 @@ public class MibLogger { else return fullname.substring(lastpoint+1,len); } - static String getLoggerName(Class clazz) { + static String getLoggerName(Class clazz) { if (clazz == null) return "sun.management.snmp.jvminstr"; Package p = clazz.getPackage(); if (p == null) return "sun.management.snmp.jvminstr"; @@ -53,11 +53,11 @@ public class MibLogger { else return pname; } - public MibLogger(Class clazz) { + public MibLogger(Class clazz) { this(getLoggerName(clazz),getClassName(clazz)); } - public MibLogger(Class clazz, String postfix) { + public MibLogger(Class clazz, String postfix) { this(getLoggerName(clazz)+((postfix==null)?"":"."+postfix), getClassName(clazz)); } diff --git a/src/share/classes/sun/management/snmp/util/SnmpListTableCache.java b/src/share/classes/sun/management/snmp/util/SnmpListTableCache.java index f2aab9f18..634f2bff0 100644 --- a/src/share/classes/sun/management/snmp/util/SnmpListTableCache.java +++ b/src/share/classes/sun/management/snmp/util/SnmpListTableCache.java @@ -59,7 +59,7 @@ public abstract class SnmpListTableCache extends SnmpTableCache { * rawDatas list iterator. * @param item The raw data object for which an index must be determined. **/ - protected abstract SnmpOid getIndex(Object context, List rawDatas, + protected abstract SnmpOid getIndex(Object context, List rawDatas, int rank, Object item); /** @@ -75,7 +75,7 @@ public abstract class SnmpListTableCache extends SnmpTableCache { * extracted. * @return By default item is returned. **/ - protected Object getData(Object context, List rawDatas, + protected Object getData(Object context, List rawDatas, int rank, Object item) { return item; } @@ -95,14 +95,14 @@ public abstract class SnmpListTableCache extends SnmpTableCache { * computed. * @return the computed cached data. **/ - protected SnmpCachedData updateCachedDatas(Object context, List rawDatas) { + protected SnmpCachedData updateCachedDatas(Object context, List rawDatas) { final int size = ((rawDatas == null)?0:rawDatas.size()); if (size == 0) return null; final long time = System.currentTimeMillis(); - final Iterator it = rawDatas.iterator(); + final Iterator it = rawDatas.iterator(); final TreeMap map = - new TreeMap(SnmpCachedData.oidComparator); + new TreeMap<>(SnmpCachedData.oidComparator); for (int rank=0; it.hasNext() ; rank++) { final Object item = it.next(); final SnmpOid index = getIndex(context, rawDatas, rank, item); diff --git a/src/share/classes/sun/management/snmp/util/SnmpNamedListTableCache.java b/src/share/classes/sun/management/snmp/util/SnmpNamedListTableCache.java index b3955f3b4..494919d69 100644 --- a/src/share/classes/sun/management/snmp/util/SnmpNamedListTableCache.java +++ b/src/share/classes/sun/management/snmp/util/SnmpNamedListTableCache.java @@ -55,7 +55,7 @@ public abstract class SnmpNamedListTableCache extends SnmpListTableCache { * This map associate an entry name with the SnmpOid index that's * been allocated for it. **/ - protected TreeMap names = new TreeMap(); + protected TreeMap names = new TreeMap<>(); /** * The last allocate index. @@ -80,7 +80,7 @@ public abstract class SnmpNamedListTableCache extends SnmpListTableCache { * rawDatas list iterator. * @param item The raw data object for which a key name must be determined. **/ - protected abstract String getKey(Object context, List rawDatas, + protected abstract String getKey(Object context, List rawDatas, int rank, Object item); /** @@ -97,7 +97,7 @@ public abstract class SnmpNamedListTableCache extends SnmpListTableCache { * rawDatas list iterator. * @param item The raw data object for which an index must be determined. **/ - protected SnmpOid makeIndex(Object context, List rawDatas, + protected SnmpOid makeIndex(Object context, List rawDatas, int rank, Object item) { // check we are in the limits of an unsigned32. @@ -151,7 +151,7 @@ public abstract class SnmpNamedListTableCache extends SnmpListTableCache { * rawDatas list iterator. * @param item The raw data object for which an index must be determined. **/ - protected SnmpOid getIndex(Object context, List rawDatas, + protected SnmpOid getIndex(Object context, List rawDatas, int rank, Object item) { final String key = getKey(context,rawDatas,rank,item); final Object index = (names==null||key==null)?null:names.get(key); @@ -174,8 +174,8 @@ public abstract class SnmpNamedListTableCache extends SnmpListTableCache { * @param rawDatas The table datas from which the cached data will be * computed. **/ - protected SnmpCachedData updateCachedDatas(Object context, List rawDatas) { - TreeMap ctxt = new TreeMap(); + protected SnmpCachedData updateCachedDatas(Object context, List rawDatas) { + TreeMap ctxt = new TreeMap<>(); final SnmpCachedData result = super.updateCachedDatas(context,rawDatas); names = ctxt; @@ -191,7 +191,7 @@ public abstract class SnmpNamedListTableCache extends SnmpListTableCache { * the {@link JvmContextFactory}. * **/ - protected abstract List loadRawDatas(Map userData); + protected abstract List loadRawDatas(Map userData); /** *The name under which the raw data is to be found/put in @@ -212,16 +212,16 @@ public abstract class SnmpNamedListTableCache extends SnmpListTableCache { * the request contextual cache. * **/ - protected List getRawDatas(Map userData, String key) { - List rawDatas = null; + protected List getRawDatas(Map userData, String key) { + List rawDatas = null; // Look for memory manager list in request contextual cache. if (userData != null) - rawDatas = (List) userData.get(key); + rawDatas = (List)userData.get(key); if (rawDatas == null) { // No list in contextual cache, get it from API - rawDatas = loadRawDatas(userData); + rawDatas = loadRawDatas(userData); // Put list in cache... @@ -250,12 +250,12 @@ public abstract class SnmpNamedListTableCache extends SnmpListTableCache { (context instanceof Map)?Util.>cast(context):null; // Look for memory manager list in request contextual cache. - final List rawDatas = getRawDatas(userData,getRawDatasKey()); + final List rawDatas = getRawDatas(userData,getRawDatasKey()); log.debug("updateCachedDatas","rawDatas.size()=" + ((rawDatas==null)?"":""+rawDatas.size())); - TreeMap ctxt = new TreeMap(); + TreeMap ctxt = new TreeMap<>(); final SnmpCachedData result = super.updateCachedDatas(ctxt,rawDatas); names = ctxt; diff --git a/src/share/classes/sun/management/snmp/util/SnmpTableCache.java b/src/share/classes/sun/management/snmp/util/SnmpTableCache.java index d65e5afe9..0786f210b 100644 --- a/src/share/classes/sun/management/snmp/util/SnmpTableCache.java +++ b/src/share/classes/sun/management/snmp/util/SnmpTableCache.java @@ -98,7 +98,7 @@ public abstract class SnmpTableCache implements Serializable { final SnmpCachedData cached = getCachedDatas(); if (cached != null) return cached; final SnmpCachedData computedDatas = updateCachedDatas(context); - if (validity != 0) datas = new WeakReference(computedDatas); + if (validity != 0) datas = new WeakReference<>(computedDatas); return computedDatas; } -- GitLab