diff --git a/src/share/classes/java/security/Signature.java b/src/share/classes/java/security/Signature.java index 72d2b0883c3380ea583b87df22d2fb1da530cdcb..cf9e6d6cf0c59a449e489d4bbc3a94e99dc97d7e 100644 --- a/src/share/classes/java/security/Signature.java +++ b/src/share/classes/java/security/Signature.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1996, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1996, 2012, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -658,7 +658,7 @@ public abstract class Signature extends SignatureSpi { throws SignatureException { if (state == VERIFY) { if ((signature == null) || (offset < 0) || (length < 0) || - (offset + length > signature.length)) { + (length > signature.length - offset)) { throw new IllegalArgumentException("Bad arguments"); } diff --git a/test/java/security/Signature/VerifyRangeCheckOverflow.java b/test/java/security/Signature/VerifyRangeCheckOverflow.java new file mode 100644 index 0000000000000000000000000000000000000000..9077cc2c120f638ebac9bdb6a4fe11f0a869ad9a --- /dev/null +++ b/test/java/security/Signature/VerifyRangeCheckOverflow.java @@ -0,0 +1,56 @@ +/* + * Copyright (c) 2012 Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * Portions Copyright (c) 2012 IBM Corporation + */ + +/* @test + * @bug 7172149 + * @summary AIOOBE from Signature.verify after integer overflow + * @author Jonathan Lu + */ + +import java.security.KeyPair; +import java.security.KeyPairGenerator; +import java.security.PublicKey; +import java.security.Signature; + +public class VerifyRangeCheckOverflow { + + public static void main(String[] args) throws Exception { + KeyPairGenerator keyPairGenerator = KeyPairGenerator.getInstance("DSA"); + keyPairGenerator.initialize(1024); + KeyPair keys = keyPairGenerator.generateKeyPair(); + PublicKey publicKey = keys.getPublic(); + byte[] sigBytes = new byte[100]; + + Signature signature = Signature.getInstance("SHA1withDSA"); + signature.initVerify(publicKey); + try { + signature.verify(sigBytes, Integer.MAX_VALUE, 1); + } catch (IllegalArgumentException ex) { + // Expected + } + } +}